[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-12-07 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 6: Code-Review+2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-12-07 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 6: Code-Review+1 > Patch Set 5: > > Updated t

[Impala-ASF-CR] Fix for startup crash in scheduler-benchmark.

2020-11-23 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16778 to look at the new patch set (#2). Change subject: Fix for startup crash in scheduler-benchmark.

[Impala-ASF-CR] Fix for run-time crash in scheduler-benchmark

2020-11-23 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16778 ) Change subject: Fix for run-time crash in scheduler-benchmark .. Patch Set 1: Small fix to get the scheduler benchmark running again

[Impala-ASF-CR] Fix for run-time crash in scheduler-benchmark

2020-11-23 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16778 Change subject: Fix for run-time crash in scheduler-benchmark .. Fix for run-time crash in scheduler-benchmark Updated scheduler-benc

[Impala-ASF-CR] IMPALA-10314: Optimize planning time for simple limits

2020-11-23 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16723 ) Change subject: IMPALA-10314: Optimize planning time for simple limits .. Patch Set 11: (4 comments) Just a couple corner cases I h

[Impala-ASF-CR] IMPALA-10320: Specify expression selectivity for BoolLiteral.

2020-11-11 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16714 Change subject: IMPALA-10320: Specify expression selectivity for BoolLiteral. .. IMPALA-10320: Specify expression selectivity for Bool

[Impala-ASF-CR] IMPALA-10252: fix invalid runtime filters for outer joins

2020-10-30 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16622 ) Change subject: IMPALA-10252: fix invalid runtime filters for outer joins .. Patch Set 5: Code-Review+1 Good catch! Made me realize

[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile

2020-10-26 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 7: Code-Review+1 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-7097 Print EC info in the query plan and profile

2020-10-22 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16587 ) Change subject: IMPALA-7097 Print EC info in the query plan and profile .. Patch Set 6: Code-Review+1 (1 comment) Just a small nitp

[Impala-ASF-CR] (WIP) IMPALA-10262: RPM/DEB Packaging Support

2020-10-19 Thread Shant Hovsepian (Code Review)
Hello Quanlong Huang, Grant Henke, Tim Armstrong, Joe McDonnell, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16612 to look at the new patch set (#2). Change subject: (WIP) IMPALA-10262: RPM/DEB Packaging Support ..

[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support

2020-10-19 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16612 ) Change subject: IMPALA-10262: RPM/DEB Packaging Support .. Patch Set 1: Work in progress, just wanted to see if anyone has any objec

[Impala-ASF-CR] IMPALA-10262: RPM/DEB Packaging Support

2020-10-19 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16612 Change subject: IMPALA-10262: RPM/DEB Packaging Support .. IMPALA-10262: RPM/DEB Packaging Support cmake -DBUILD_PACKAGES=ON make pac

[Impala-ASF-CR] IMPALA-6671: [WIP] Skip locked tables from topic updates

2020-10-07 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16549 ) Change subject: IMPALA-6671: [WIP] Skip locked tables from topic updates .. Patch Set 1: (6 comments) Thanks for working on this Vi

[Impala-ASF-CR] IMPALA-9974: Join elimination based on referential integrity.

2020-10-06 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16182 Change subject: IMPALA-9974: Join elimination based on referential integrity. .. IMPALA-9974: Join elimination based on referential in

[Impala-ASF-CR] IMPALA-10112: Remove FpRateTooHigh() check for bloom filter

2020-09-25 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16499 ) Change subject: IMPALA-10112: Remove FpRateTooHigh() check for bloom filter .. Patch Set 2: Code-Review+1 -- To view, visit http://

[Impala-ASF-CR] IMPALA-10185 Use bool stats for selectivity calculations.

2020-09-23 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16462 ) Change subject: IMPALA-10185 Use bool stats for selectivity calculations. .. Patch Set 2: Just a small change nothing urgent. -- T

[Impala-ASF-CR] IMPALA-10185 Use bool stats for selectivity calculations.

2020-09-23 Thread Shant Hovsepian (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16462 to look at the new patch set (#2). Change subject: IMPALA-10185 Use bool stats for selectivity calculations. ..

[Impala-ASF-CR] IMPALA-10112: Remove FpRateTooHigh() check for blom filter

2020-09-23 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16499 ) Change subject: IMPALA-10112: Remove FpRateTooHigh() check for blom filter .. Patch Set 1: (4 comments) Thanks for implementing and

[Impala-ASF-CR] IMPALA-5022 part 1: Implement core functions of outer join simplification

2020-09-22 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022 part 1: Implement core functions of outer join simplification .. Patch Set 22: Code-Review+1 Xianqing,

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: Code-Review+1 (2 comments) I don't feel as strongly about r

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-14 Thread Shant Hovsepian (Code Review)
Hello Quanlong Huang, Vihang Karajgaonkar, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16428 to look at the new patch set (#2). Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED ..

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16447 ) Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. Patch Set 1: Small docs typo fix. -- To view, visit http

[Impala-ASF-CR] IMPALA-10167: Docs typo for DEFAULT TRANSACTIONAL TYPE

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16447 Change subject: IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE .. IMPALA-10167: Docs typo for DEFAULT_TRANSACTIONAL_TYPE Fix

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-12 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-11 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (1 comment) http://gerrit.cloudera.org:8080/#/c/16242/17/te

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-10 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (6 comments) http://gerrit.cloudera.org:8080/#/c/16242/13//

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-08 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16428 ) Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. Patch Set 1: Hi guys I tried to follow the standard of copyin

[Impala-ASF-CR] IMPALA-8291: Show constraints in DESCRIBE FORMATTED

2020-09-08 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16428 Change subject: IMPALA-8291: Show constraints in DESCRIBE FORMATTED .. IMPALA-8291: Show constraints in DESCRIBE FORMATTED Support fo

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-31 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 12: > Patch Set 12: Verified-1 > > Build faile

[Impala-ASF-CR] IMPALA-10064: Support constant propagation for eligible range predicates

2020-08-31 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16346 ) Change subject: IMPALA-10064: Support constant propagation for eligible range predicates .. Patch Set 9: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-31 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 11: (10 comments) Yeah I guess some of those

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-31 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#11). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ..

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-31 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-10099: Push down DISTINCT in Set operations

2020-08-29 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16350 ) Change subject: IMPALA-10099: Push down DISTINCT in Set operations .. Patch Set 4: > Patch Set 3: > > (1 comment) Good point. The f

[Impala-ASF-CR] IMPALA-10099: Push down DISTINCT in Set operations

2020-08-29 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16350 to look at the new patch set (#4). Change subject: IMPALA-10099: Push down DISTINCT in Set operations .

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-29 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#10). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ..

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-29 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#9). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-28 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 8: (1 comment) > Patch Set 8: > > I wonder if

[Impala-ASF-CR] IMPALA-10110: bloom filter target fpp query option

2020-08-28 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16377 ) Change subject: IMPALA-10110: bloom filter target fpp query option .. Patch Set 5: Code-Review+1 (1 comment) http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-10064: Support constant propagation for eligible range predicates

2020-08-28 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16346 ) Change subject: IMPALA-10064: Support constant propagation for eligible range predicates .. Patch Set 8: (5 comments) http://gerri

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-28 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 8: This is getting a little uglier now. Turns

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-27 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#8). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-10099: Push down DISTINCT in Set operations

2020-08-27 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16350 ) Change subject: IMPALA-10099: Push down DISTINCT in Set operations .. Patch Set 3: Small optimization for the set operation rewrites

[Impala-ASF-CR] IMPALA-10046: Support constant propagation for eligible range predicates

2020-08-27 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16346 ) Change subject: IMPALA-10046: Support constant propagation for eligible range predicates .. Patch Set 7: (7 comments) Nice additio

[Impala-ASF-CR] IMPALA-10110: allow setting bloom filter fpp

2020-08-27 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16377 ) Change subject: IMPALA-10110: allow setting bloom filter fpp .. Patch Set 4: Code-Review+1 (2 comments) Non critical suggestions. T

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-27 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-27 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#6). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-26 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#5). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-10099: Push down DISTINCT in Set operations

2020-08-26 Thread Shant Hovsepian (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16350 to look at the new patch set (#3). Change subject: IMPALA-10099: Push down DISTINCT in Set operations .. I

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-26 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#8). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#7). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 6: Too many parallel CR had some things sneak

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-25 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#6). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 4: (2 comments) > Patch Set 3: > > (1 comment

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-24 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#4). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16345 ) Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#5). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-24 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16345 to look at the new patch set (#4). Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS ...

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-23 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#3). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-10099: Push down DISTINCT for SetOperations

2020-08-23 Thread Shant Hovsepian (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16350 to look at the new patch set (#2). Change subject: IMPALA-10099: Push down DISTINCT for SetOperations .. I

[Impala-ASF-CR] IMPALA-10099: Push down DISTINCT for SetOperations

2020-08-21 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16350 Change subject: IMPALA-10099: Push down DISTINCT for SetOperations .. IMPALA-10099: Push down DISTINCT for SetOperations Testing: *

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-21 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Qifan Chen, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16349 to look at the new patch set (#2). Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. ...

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-21 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16280 to look at the new patch set (#7). Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. ..

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-20 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16349 ) Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. Patch Set 1: This is a bit of a lazy fix, handling only

[Impala-ASF-CR] IMPALA-7310: Partial fix for NDV cardinality with NULLs.

2020-08-20 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16349 Change subject: IMPALA-7310: Partial fix for NDV cardinality with NULLs. .. IMPALA-7310: Partial fix for NDV cardinality with NULLs.

[Impala-ASF-CR] IMPALA-10095: Include query plan tests for all of TPC-DS

2020-08-20 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16345 Change subject: IMPALA-10095: Include query plan tests for all of TPC-DS .. IMPALA-10095: Include query plan tests for all of TPC-DS

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-20 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16280 to look at the new patch set (#6). Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. ..

[Impala-ASF-CR] IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows

2020-08-19 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16338 ) Change subject: IMPALA-7782: fix constant NOT IN subqueries that can return 0 rows .. Patch Set 1: Code-Review+1 Nice catch. -- T

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-19 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 5: (2 comments) > Patch Set 4: > > Agree with

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-19 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16280 to look at the new patch set (#5). Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. ..

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-07 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-06 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Fang-Yu Rao, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16280 to look at the new patch set (#4). Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. ..

[Impala-ASF-CR] IMPALA-5022: Outer join simplification

2020-08-04 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16266 ) Change subject: IMPALA-5022: Outer join simplification .. Patch Set 5: (10 comments) Hi Xianqing, thank you so much for this contri

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-03 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16280 ) Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. Patch Set 1: Adding the missing tpc-ds queries. Easy spo

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-03 Thread Shant Hovsepian (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16280 to look at the new patch set (#2). Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload.

[Impala-ASF-CR] IMPALA-10034: Add remaining TPC-DS queries to workload.

2020-08-03 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16280 Change subject: IMPALA-10034: Add remaining TPC-DS queries to workload. .. IMPALA-10034: Add remaining TPC-DS queries to workload. In

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 11: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-30 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#11). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] ..

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-22 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 9: (15 comments) Thanks for all the test suggesti

[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException

2020-07-22 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16212 ) Change subject: IMPALA-9929: Subquery error should throw AnalysisException .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException

2020-07-22 Thread Shant Hovsepian (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16212 to look at the new patch set (#2). Change subject: IMPALA-9929: Subquery error should throw AnalysisException ..

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-22 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#9). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] ...

[Impala-ASF-CR](asf-site) Add link to slack channel on community

2020-07-19 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16024 ) Change subject: Add link to slack channel on community .. Patch Set 1: Code-Review+1 > Patch Set 1: > > Could we just use the-asf.sl

[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException

2020-07-18 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16212 ) Change subject: IMPALA-9929: Subquery error should throw AnalysisException .. Patch Set 1: Quick fix, Thanks! -- To view, visit ht

[Impala-ASF-CR] IMPALA-9929: Subquery error should throw AnalysisException

2020-07-18 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16212 Change subject: IMPALA-9929: Subquery error should throw AnalysisException .. IMPALA-9929: Subquery error should throw AnalysisExcepti

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16123 ) Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] .. Patch Set 8: (8 comments) > Patch Set 5: > > (6 comments)

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Shant Hovsepian (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#8). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] ...

[Impala-ASF-CR] IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT]

2020-07-17 Thread Shant Hovsepian (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#7). Change subject: IMPALA-9943,IMPALA-4974: INTERSECT/EXCEPT [DISTINCT] ...

[Impala-ASF-CR] IMPALA-9943, IMPALA-4974: INTERSECT and EXCEPT DISTINCT Support.

2020-07-16 Thread Shant Hovsepian (Code Review)
Hello David Rorke, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16123 to look at the new patch set (#6). Change subject: IMPALA-9943, IMPALA-4974: INTERSECT and EXCEPT DISTINCT Support. ...

[Impala-ASF-CR] IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT

2020-07-12 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16171 ) Change subject: IMPALA-9949: fix SELECT list subqueries with HAVING/LIMIT .. Patch Set 5: Code-Review+1 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5226: handle single subquery in or predicate

2020-07-08 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16152 ) Change subject: IMPALA-5226: handle single subquery in or predicate .. Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloude

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-07 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 12: Code-Review+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-9917: grouping() and grouping id() support

2020-07-06 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16140 ) Change subject: IMPALA-9917: grouping() and grouping_id() support .. Patch Set 7: (3 comments) Grouping Sets are usually useful whe

[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

2020-07-04 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16052 to look at the new patch set (#5). Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

[Impala-ASF-CR] IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

2020-07-04 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16052 to look at the new patch set (#4). Change subject: IMPALA-9784, IMPALA-9905: Uncorrelated subqueries in HAVING.

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

2020-07-04 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16007 to look at the new patch set (#9). Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

2020-07-04 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .. Patch Set 8: (11 comments) Addressed some comment

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

2020-07-04 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16007 ) Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .. Patch Set 8: (1 comment) > Patch Set 7: Code-Revi

[Impala-ASF-CR] IMPALA-8954: Uncorrelated scalar subqueries in the select list

2020-07-04 Thread Shant Hovsepian (Code Review)
Hello Aman Sinha, Fang-Yu Rao, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16007 to look at the new patch set (#8). Change subject: IMPALA-8954: Uncorrelated scalar subqueries in the select list .

  1   2   >