[native-toolchain-CR] Don't use MADV FREE on linux

2020-05-19 Thread helifu (Code Review)
helifu has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/15955 ) Change subject: Don't use MADV_FREE on linux .. Don't use MADV_FREE on linux Change-Id: I5e6ca41f054e17ce4f30d6c6cd58da3c358af11a --- M

[native-toolchain-CR] Don't use MADV FREE on linux

2020-05-19 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15955 Change subject: Don't use MADV_FREE on linux .. Don't use MADV_FREE on linux Change-Id: I5e6ca41f054e17ce4f30d6c6cd58da3c358af11a --- M

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 13: > > Patch Set 13: > > > > > Thanks for the fix.

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-03 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 13: > Thanks for the fix. should i rebase to the

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-05-03 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#12). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-29 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 9: It seems there is something wrong with hdfs

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-27 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#9). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 8: (1 comment) --helifu Apr 10 8:47 AM↩ Patch Set 1:

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-27 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#8). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-27 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 7: (5 comments)

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-25 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#7). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-25 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#6). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-25 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#5). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-24 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-24 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#4). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-24 Thread helifu (Code Review)
Hello Thomas Marshall, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#3). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-24 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 2: (6 comments) sorry for the late update.

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12977 to look at the new patch set (#2). Change subject: IMPALA-5351: Support storing column comment of kudu table

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12977 ) Change subject: IMPALA-5351: Support storing column comment of kudu table .. Patch Set 1: The latest kudu client is required, otherwise the

[Impala-ASF-CR] IMPALA-5351: Support storing column comment of kudu table

2019-04-09 Thread helifu (Code Review)
helifu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12977 Change subject: IMPALA-5351: Support storing column comment of kudu table .. IMPALA-5351: Support storing column comment of kudu table This