[Impala-ASF-CR] IMPALA-5675: Support UTF-8 VARCHAR and CHAR types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 VARCHAR and CHAR types .. Patch Set 21: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 VARCHAR and CHAR types

2022-05-28 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#21). Change subject: IMPALA-5675: Support UTF-8 VARCHAR and CHAR types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 VARCHAR and CHAR types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 VARCHAR and CHAR types .. Patch Set 20: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 VARCHAR and CHAR types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 VARCHAR and CHAR types .. Patch Set 20: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 VARCHAR and CHAR types

2022-05-28 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#20). Change subject: IMPALA-5675: Support UTF-8 VARCHAR and CHAR types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 19: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#19). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 19: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 18: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 18: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 18: (8 comments) Resolved the remaining comments. ht

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-28 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#18). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 17: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-25 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 17: (23 comments) Resolved most of the comments. htt

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 17: (6 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-25 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#17). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 16: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-24 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 16: (11 comments) http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-24 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 16: (7 comments) Resolving some comments. Still WIP.

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-24 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#16). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: Verified+1 -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-19 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: > Patch Set 15: Verified-1 > > Build failed: https

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: Verified-1 Build failed: https://jenkins.im

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: Build started: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-18 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: (8 comments) Thanks Qifan's feedbacks! I'm revivi

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-18 Thread Quanlong Huang (Code Review)
Hello Qifan Chen, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#15). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2022-05-18 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 15: (4 comments) http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-23 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: (16 comments) Looks good. I think we should maintain

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: (26 comments) Started the review maybe 1/3 way throug

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: Build Successful https://jenkins.impala.io

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types .. Patch Set 14: (5 comments) Thanks for your review, Tim! Address

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char types

2021-02-22 Thread Quanlong Huang (Code Review)
Hello Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#14). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char types ..

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-12 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 13: (5 comments) I looked at the backend change and the appr

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 13: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-10 Thread Quanlong Huang (Code Review)
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 13: Fixed some issues caused by unexpected data loading. -

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-10 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#13). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. IMPALA-

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 12: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-09 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#12). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. IMPALA-

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16909 ) Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. Patch Set 11: Build Successful https://jenkins.impala.io/job/g

[Impala-ASF-CR] IMPALA-5675: Support UTF-8 Varchar and Char

2021-02-09 Thread Quanlong Huang (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16909 to look at the new patch set (#11). Change subject: IMPALA-5675: Support UTF-8 Varchar and Char .. IMPALA-