[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11443 Change subject: IMPALA-6202. mod and % are not equivalent. .. IMPALA-6202. mod and % are not equivalent. Currently typeof(9.9 % 3) is D

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 1: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11443/1/testda

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Vuk Ercegovac (Code Review)
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/11443/1/f

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. IMPALA-6202. mod and % are not equivalent. Currently typeof(9.9 % 3) is DE

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 2: Hi Dan and Vuk, thanks a lot for your review comments. I ju

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 2: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 2: > (2 comments) Very good suggestion Vuk, I tried it out, a

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 2: I'm thinking about a different approach now, say, we can pr

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. IMPALA-6202. mod and % are not equivalent. Currently typeof(9.9 % 3) is DE

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Yongjun Zhang (Code Review)
Yongjun Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 3: Uploaded a quick v3 to prove concept, it seems to be a much

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 3: Build Successful https://jenkins.impala.io/job/ger

[Impala-ASF-CR] IMPALA-6202. mod and % are not equivalent.

2018-09-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/11443 ) Change subject: IMPALA-6202. mod and % are not equivalent. .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/