[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. IMPALA-9979: part 2: partitioned top-n Planner changes:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 35: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 35: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 35: Build started:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-09 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 34: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-09 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 34: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-09 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#34). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-09 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 33: (2 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 33: (3 comments) Just one other comment after which I am ready to

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (21 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 32: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 31: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#32). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#31). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: Code-Review+1 With the exception of small number of review

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-08 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (5 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-05 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (15 comments) This is a complex optimization. Nice work on

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-04 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: > Patch Set 30: Code-Review+1 > > BE part and tests look good to

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-03 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: Code-Review+1 BE part and tests look good to me --

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 30: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#30). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 29: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 29: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Thomas Tauber-Marshall, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#29). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-02 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 28: (7 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-02-01 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 28: (7 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 28: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#28). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Rebased onto master after the previous patch was merged --

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 27: Build started:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-25 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#27). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-15 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 26: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-15 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#26). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 25: Latest patchset fixes the test failure and is ready for

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 24: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 25: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#25). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 24: Build started:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-14 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 23: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 24: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 23: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#24). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 23: Build started:

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 23: (2 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#23). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 22: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 22: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 21: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#22). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#21). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2021-01-13 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 21: (4 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 20: Build Failed

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 19: (1 comment) Just another WIP, but I made some progress

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#20). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 19: Code-Review+1 (8 comments) Looks good and thanks a lot for the

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 19: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 19: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 19: This is the rebased version, using the new PriorityQueue

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-08 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#19). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 18: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 18: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (27 comments) Pushing out the changes I've done so far. I'm

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-10-07 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Qifan Chen, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#18). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-14 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: Code-Review+1 (2 comments) I don't feel as strongly about

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-13 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (5 comments) Looks very good!

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-11 Thread Aman Sinha (Code Review)
Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (5 comments) Sending initial comments. The patch looks in

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-11 Thread Qifan Chen (Code Review)
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (8 comments) 1st batch of comments. Will try to find some time

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-11 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (1 comment)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-10 Thread Shant Hovsepian (Code Review)
Shant Hovsepian has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: (6 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-10 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 17: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-10 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#17). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-09-10 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 15: (3 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-08-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 16: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-08-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 15: (3 comments) This is ready for review. I still need to look

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-08-11 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#16). Change subject: IMPALA-9979: part 2: partitioned top-n

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-31 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 12: (2 comments)

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16242 ) Change subject: IMPALA-9979: part 2: partitioned top-n .. Patch Set 12: Build Successful

[Impala-ASF-CR] IMPALA-9979: part 2: partitioned top-n

2020-07-30 Thread Tim Armstrong (Code Review)
Hello Aman Sinha, Shant Hovsepian, David Rorke, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/16242 to look at the new patch set (#12). Change subject: IMPALA-9979: part 2: partitioned top-n