[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 1: (4 comments) Thanks for the

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 2: > It seems good to me, but I

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (7 comments) Thanks for the reviews http://gerr

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-26 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts to

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-29 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (5 comments) Thanks Thomas and Csaba for reviews

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts to

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: I added a new patch because r

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 2: (4 comments) Thanks Csaba http://gerrit.clouder

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-30 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: (21 comments) Thanks for rev

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-10-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts to

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. Patch Set 4: (1 comment) I agree that mai

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-01 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts to

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-11-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-6658: improve Parquet RLE for low bit widths

2018-11-05 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/11582 ) Change subject: IMPALA-6658: improve Parquet RLE for low bit widths .. IMPALA-6658: improve Parquet RLE for low bit widths RleEncoder b

[Impala-ASF-CR] IMPALA-5821: Add query with implicit casts to extended explain output.

2018-11-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/11719 ) Change subject: IMPALA-5821: Add query with implicit casts to extended explain output. .. IMPALA-5821: Add query with implicit casts to

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11942 Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In IMPA

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In IMPAL

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 2: (6 comments) Thanks Paul for the interesting r

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In IMPAL

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. IMPALA-7801: Remove toSql() from ParseNode interface. In IMPAL

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-16 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: reviewers should ignore patch set 3 which is ve

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has removed Vuk Ercegovac from this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Removed reviewer Vuk Ercegovac. -- To view, visit ht

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: I'm not happy with using ORIGINAL as the defaul

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Patch Set 4: Thanks Csaba, hope you didn't waste too much ti

[Impala-ASF-CR] IMPALA-7801: Remove toSql() from ParseNode interface.

2018-11-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has abandoned this change. ( http://gerrit.cloudera.org:8080/11942 ) Change subject: IMPALA-7801: Remove toSql() from ParseNode interface. .. Abandoned Will let Paul Rogers fix (or at least think about) in a big

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-11-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 2: (2 comments) Looks like a useful change

[Impala-ASF-CR] IMPALA-6924: Add child queries to profile in compute stats

2018-12-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/11977 ) Change subject: IMPALA-6924: Add child queries to profile in compute stats .. Patch Set 4: Code-Review+1 (5 comments) This all looks

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12068 Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTup

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupl

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupl

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. Patch Set 3: I tested performance of the two scalar

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12102 Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. IMPALA-7183: Include remote host when loggi

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2018-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupl

[Impala-ASF-CR] IMPALA-7183: Include remote host when logging unknown execution status.

2018-12-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12102 ) Change subject: IMPALA-7183: Include remote host when logging unknown execution status. .. IMPALA-7183: Include remote host when loggin

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12142 Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the Coor

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the Coord

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 1: (6 comments) Thanks for the helpful review http:

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-02 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the Coord

[Impala-ASF-CR] IMPALA-8047 Support .proto files in .clang-format

2019-01-04 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12165 Change subject: IMPALA-8047 Support .proto files in .clang-format .. IMPALA-8047 Support .proto files in .clang-format The .proto file

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. Patch Set 3: (11 comments) Thanks for the code reviews http:/

[Impala-ASF-CR] IMPALA-7468: Port CancelQueryFInstances() to KRPC.

2019-01-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/12142 ) Change subject: IMPALA-7468: Port CancelQueryFInstances() to KRPC. .. IMPALA-7468: Port CancelQueryFInstances() to KRPC. When the Coord

[Impala-ASF-CR] IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr.

2019-01-09 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/12068 ) Change subject: IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupleIdExpr. .. IMPALA-7657: Codegen IsNotEmptyPredicate and ValidTupl

[Impala-ASF-CR] IMPALA-1653: Don't close hiveserver2 session when connection is closed

2019-05-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13306 ) Change subject: IMPALA-1653: Don't close hiveserver2 session when connection is closed .. Patch Set 2: (1 comment) http://gerrit.cl

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13307 Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. WIP IMPALA-8536: Add Scalable Pool Config

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 1: (6 comments) Thanks for t

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. WIP IMPALA-8536: Add Scalable Pool Configu

[Impala-ASF-CR] WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-14 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: WIP IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 2: I have realized that there

[Impala-ASF-CR] [WIP] IMPALA-8473: publish lineage info via hook

2019-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: [WIP] IMPALA-8473: publish lineage info via hook .. Patch Set 12: (4 comments) A few thoughts on things that can go

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (7 comments) Thanks Radford for working through these is

[native-toolchain-CR] Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings.

2019-05-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13383 Change subject: Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl warnings. .. Patch Thrift to 0.9.3-p6 to eliminate erroneous ssl wa

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-20 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/13352/14

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-21 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 14: (1 comment) Thanks Radford, I think you'e making progres

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 16: (3 comments) I added a few comments based on recent chan

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 19: Code-Review+1 (3 comments) I left a few comments but thi

[Impala-ASF-CR] IMPALA-8473: publish lineage info via hook

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13352 ) Change subject: IMPALA-8473: publish lineage info via hook .. Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/13352/1

[Impala-ASF-CR] IMPALA-8333: Remove Impala Shell warnings part 2

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13404 Change subject: IMPALA-8333: Remove Impala Shell warnings part 2 .. IMPALA-8333: Remove Impala Shell warnings part 2 Set IMPALA_TOOLCH

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 10: (1 comment) Patch set 11 uses the agreed approach. http://g

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-05-23 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRet

[Impala-ASF-CR] IMPALA-8333: Remove Impala Shell warnings part 2

2019-05-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13404 ) Change subject: IMPALA-8333: Remove Impala Shell warnings part 2 .. Patch Set 2: No-one picked this up so I am picking on you (Thomas

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 4: (22 comments) Thanks Tim and

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-05-31 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 5: It's actually easy (form a cod

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-03 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#6). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#7). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-06 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 7: (21 comments) Addressing revi

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. IMPALA-8143: Enhance DoRpcWithRetry(). Allow callers of RpcMgr::DoRpcWithRet

[Impala-ASF-CR] IMPALA-8143: Enhance DoRpcWithRetry().

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/12672 ) Change subject: IMPALA-8143: Enhance DoRpcWithRetry(). .. Patch Set 12: (5 comments) Thanks Michael, I believe I addressed the nits.

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 7: (1 comment) I'm not happy wit

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-07 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 7: In fact I am removing my Clust

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-10 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-11 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#9). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration t

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 10: (17 comments) Thanks for the

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 10: (1 comment) New patch coming

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#11). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 12: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-12 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#12). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#13). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-13 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 13: (1 comment) http://gerrit.cl

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#14). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-17 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 14: (32 comments) Thanks Lars fo

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has uploaded a new patch set (#15). ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. IMPALA-8536: Add Scalable Pool Configuration

[Impala-ASF-CR] IMPALA-8536: Add Scalable Pool Configuration to Admission Controller.

2019-06-18 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13307 ) Change subject: IMPALA-8536: Add Scalable Pool Configuration to Admission Controller. .. Patch Set 16: Code-Review+2 (4 comments) B

[Impala-ASF-CR] IMPALA-8584: Add cookie support to the HTTP HS2 server

2019-06-19 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13672 ) Change subject: IMPALA-8584: Add cookie support to the HTTP HS2 server .. Patch Set 2: (3 comments) Just nits http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()

2019-06-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 ) Change subject: IMPALA-8713: fix stack overflow in unhex() .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-8689: test hive impala interop failing with "Timeout >7200s"

2019-06-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13755 ) Change subject: IMPALA-8689: test_hive_impala_interop failing with "Timeout >7200s" .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] WIP IMPALA-8484: Run queries on disjoint executor groups

2019-06-27 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13550 ) Change subject: WIP IMPALA-8484: Run queries on disjoint executor groups .. Patch Set 7: (3 comments) a few early comments/questions

[Impala-ASF-CR] WIP IMPALA-8484: Run queries on disjoint executor groups

2019-06-28 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13550 ) Change subject: WIP IMPALA-8484: Run queries on disjoint executor groups .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5149: Provide query profile in JSON format

2019-07-22 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13801 ) Change subject: IMPALA-5149: Provide query profile in JSON format .. Patch Set 8: Should the json include the explicit version number

[Impala-ASF-CR] IMPALA-8615: [DOCS] Document the scalable admission control parameters

2019-07-24 Thread Andrew Sherman (Code Review)
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13906 ) Change subject: IMPALA-8615: [DOCS] Document the scalable admission control parameters .. Patch Set 2: (1 comment) This basically l

<    1   2   3   4   5   6   7   >