[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#10). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ..

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Sailesh Mukil, Joe McDonnell, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10769 to look at the new patch set (#15). Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. Patch Set 5: Code-Review+2 Rebased, carrying Michael's +2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 7: Code-Review+2 Rebased, carrying Michael's +2. -- To v

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 10: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 10: Code-Review+2 Rebased and addressed the final

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's +2. -- To

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: Code-Review+2 Rebased, carrying Michael's +2

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 15: Code-Review+2 Rebased and addressed the final comm

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 11: That carried +2 was from Sailesh, obviously.

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#11). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ..

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10757 to look at the new patch set (#8). Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. IMPALA-7006: A

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10760 to look at the new patch set (#13). Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-11 Thread Lars Volker (Code Review)
Hello Michael Ho, Henry Robinson, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/10758 to look at the new patch set (#12). Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. ..

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. Patch Set 6: Code-Review+2 Rebased, carrying Michael's +2 -- To view, visit http:/

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 9: Code-Review+2 Removed .rej file, rebased, carrying Mich

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 12: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 13: Code-Review+2 Fixed shared linking, carrying Michael'

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 13: Code-Review+2 Rebased, carrying Sailesh's +2

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 13: Code-Review+2 Rebased, carrying Michael's

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. Patch Set 17: Code-Review+2 Rebased, carrying Michael's +2. --

[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 ) Change subject: IMPALA-6677: [DOCS] Document the next_day function .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/108

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/10756 To

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cl

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. Patch Set 13: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. Patch Set 12: Verified+1 -- To view, visit http://gerri

[Impala-ASF-CR] IMPALA-7006: Pick parts of recent Kudu gutil changes

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10769 ) Change subject: IMPALA-7006: Pick parts of recent Kudu gutil changes .. IMPALA-7006: Pick parts of recent Kudu gutil changes - I

[Impala-ASF-CR] IMPALA-7006: Remove KRPC folders

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10756 ) Change subject: IMPALA-7006: Remove KRPC folders .. IMPALA-7006: Remove KRPC folders Change-Id: Ic677484c27ed18b105da0a6b0901df4

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. IMPALA-5129: Use Kudu's Kinit code to avoid expensi

[Impala-ASF-CR] IMPALA-7006: [KSECURITY] Update security library integration

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10759 ) Change subject: IMPALA-7006: [KSECURITY] Update security library integration .. IMPALA-7006: [KSECURITY] Update security library

[Impala-ASF-CR] IMPALA-4669: [KRPC] Add kudu rpc library to build

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10760 ) Change subject: IMPALA-4669: [KRPC] Add kudu_rpc library to build .. IMPALA-4669: [KRPC] Add kudu_rpc library to build NOTE: Thi

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. IMPALA-7006: Add KRPC folders from kudu@334ecafd cp -a ~/che

[Impala-ASF-CR] IMPALA-7006: Add KRPC folders from kudu@334ecafd

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10757 ) Change subject: IMPALA-7006: Add KRPC folders from kudu@334ecafd .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.or

[Impala-ASF-CR] IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10763 ) Change subject: IMPALA-5129: Use Kudu's Kinit code to avoid expensive fork .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.

[Impala-ASF-CR] KUDU-2305: Limit sidecars to INT MAX and fortify socket code

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10765 ) Change subject: KUDU-2305: Limit sidecars to INT_MAX and fortify socket code .. KUDU-2305: Limit sidecars to INT_MAX and fortify

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10758 ) Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. IMPALA-4669: [KUTIL] Add kudu_util library to the bui

[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 ) Change subject: IMPALA-6677: [DOCS] Document the next_day function .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/108

[Impala-ASF-CR] IMPALA-6677: [DOCS] Document the next day function

2018-07-12 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10893 ) Change subject: IMPALA-6677: [DOCS] Document the next_day function .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/108

[Impala-ASF-CR] IMPALA-6214: Determine and warn about stuck fragment instances.

2018-07-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11021 ) Change subject: IMPALA-6214: Determine and warn about stuck fragment instances. .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-07-31 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 6: (7 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 8: (7 comments) http://gerrit.c

[Impala-ASF-CR] IMPALA-7442: reduce mem requirement of semi-joins-exhaustive

2018-08-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11223 ) Change subject: IMPALA-7442: reduce mem requirement of semi-joins-exhaustive .. Patch Set 2: Code-Review+2 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 10: (4 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-7449: Fix network throughput calculation of DataStreamSender

2018-08-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11241 ) Change subject: IMPALA-7449: Fix network throughput calculation of DataStreamSender .. Patch Set 4: Code-Review+2 -- To view, visit ht

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Should we also looks at https://issues.apache.org/jira/browse/I

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 12: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-7433: reduce logging on executors

2018-08-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/11202 ) Change subject: IMPALA-7433: reduce logging on executors .. Patch Set 4: Thx for your comments. -- To view, visit http://gerrit.cloude

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 12: (2 comments) http://gerrit.

[Impala-ASF-CR] IMPALA-6271: Impala daemon should log a message when it's being shut down

2018-08-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/10847 ) Change subject: IMPALA-6271: Impala daemon should log a message when it's being shut down .. Patch Set 14: Code-Review+1 (1 comment) L

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-15 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 2: > > Based on my reading of

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 ) Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning .. Patch Set 3: (4 comments) http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4985: use parquet stats of nested types for dynamic pruning

2017-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8480 ) Change subject: IMPALA-4985: use parquet stats of nested types for dynamic pruning .. Patch Set 4: Code-Review+1 -- To view, visit http

[Impala-ASF-CR] IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT

2017-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8400 ) Change subject: IMPALA-4167: Support insert plan hints for CREATE TABLE AS SELECT .. Patch Set 4: (7 comments) http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-16 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > >

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > Dan, what's your tak

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 3: > Patch Set 3: > > > > Patch Set 3: > >

[Impala-ASF-CR] IMPALA-6109: xfail TestHdfsUnknownErrors::test hdfs safe mode error 255

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8590 Change subject: IMPALA-6109: xfail TestHdfsUnknownErrors::test_hdfs_safe_mode_error_255 .. IMPALA-6109: xfail TestHdfsUnknownErrors::test_

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-17 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 5: (4 comments) http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 6: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 7: Code-Review+2 -- To view, visit http://g

[Impala-ASF-CR](asf-site) Make wording around adopters of Impala more consistent.

2017-11-20 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8609 Change subject: Make wording around adopters of Impala more consistent. .. Make wording around adopters of Impala more consistent. Change-

[Impala-ASF-CR] IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo

2017-11-20 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8546 ) Change subject: IMPALA-5624: Replace "ls -l" with opendir() in ProcessStateInfo .. Patch Set 7: Flaky test, will restart the Jenkins job.

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8612/1/be/CMake

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/8612/1//COMMIT

[Impala-ASF-CR] IMPALA-6206: Fix data load failure with -notests

2017-11-21 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8580 ) Change subject: IMPALA-6206: Fix data load failure with -notests .. Patch Set 3: Code-Review+2 (1 comment) Thanks for fixing this http:

[Impala-ASF-CR](asf-site) Make wording around adopters of Impala more consistent.

2017-11-26 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8609 ) Change subject: Make wording around adopters of Impala more consistent. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloud

[Impala-ASF-CR](asf-site) Make wording around adopters of Impala more consistent.

2017-11-26 Thread Lars Volker (Code Review)
Lars Volker has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8609 ) Change subject: Make wording around adopters of Impala more consistent. .. Make wording around adopters of Impala more consistent.

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-11-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 4: (9 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8669 Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. IMPALA-6255: Add device names to DiskIoMgr thread names This ch

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. IMPALA-6255: Add device names to DiskIoMgr thread names This cha

[Impala-ASF-CR] Remove "incubator-" from URLs.

2017-11-29 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/8698 ) Change subject: Remove "incubator-" from URLs. .. Abandoned Tim was faster :) -- To view, visit http://gerrit.cloudera.org:8080/8698 To unsubscribe

[Impala-ASF-CR] Remove "incubator-" from URLs.

2017-11-29 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8698 Change subject: Remove "incubator-" from URLs. .. Remove "incubator-" from URLs. I did this with the help of this command: git grep -l in

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8669 to look at the new patch set (#3). Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names ...

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 3: > Patch Set 2: > > For future reference here's a

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8669 to look at the new patch set (#4). Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names ...

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 4: Code-Review+2 (1 comment) Carrying Tim's +2 htt

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 5: Code-Review+2 rebased, carrying Tim's +2 -- To

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8669 to look at the new patch set (#5). Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names ...

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Hello Tim Armstrong, Alex Behm, Bikramjeet Vig, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8669 to look at the new patch set (#6). Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names ...

[Impala-ASF-CR] IMPALA-6255: Add device names to DiskIoMgr thread names

2017-11-30 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8669 ) Change subject: IMPALA-6255: Add device names to DiskIoMgr thread names .. Patch Set 6: Code-Review+2 Changed thread names for out-of-ran

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (7 comments) Thank you for working on this. Plea

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8758 Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. IMPALA-6190/6246: Add instances tab and event sequence This chan

[Impala-ASF-CR] IMPALA-6232: Disable file handle cache by default

2017-12-04 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8750 ) Change subject: IMPALA-6232: Disable file handle cache by default .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/8750/3

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 2: PS2 passed a private build: https://jenkins.impal

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-05 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 2: > Patch Set 2: > > Can you link to a full profile

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/8777/1//C

[Impala-ASF-CR] IMPALA-6281: Fix use-after-free in InitAuth()

2017-12-06 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8777 ) Change subject: IMPALA-6281: Fix use-after-free in InitAuth() .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-4132: Use -fno-omit-frame-pointer

2017-12-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8612 ) Change subject: IMPALA-4132: Use -fno-omit-frame-pointer .. Patch Set 2: > Patch Set 2: > > I spoke to Gabor about this a few days ago. I

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8758 ) Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-6190/6246: Add instances tab and event sequence

2017-12-07 Thread Lars Volker (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8758 to look at the new patch set (#3). Change subject: IMPALA-6190/6246: Add instances tab and event sequence .. IMPALA-619

[Impala-ASF-CR] IMPALA-3703: Store query context in thread-local variables

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8621 ) Change subject: IMPALA-3703: Store query context in thread-local variables .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5993: Fix the file offset in value parsing error

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/8747 ) Change subject: IMPALA-5993: Fix the file offset in value parsing error .. Patch Set 4: Can you adjust the logging details according to t

[Impala-ASF-CR] Add .pep8rc for Impala's Python style

2017-12-08 Thread Lars Volker (Code Review)
Lars Volker has abandoned this change. ( http://gerrit.cloudera.org:8080/5829 ) Change subject: Add .pep8rc for Impala's Python style .. Abandoned Not finding time to work on this one. -- To view, visit http://gerrit.cloudera.o

<    8   9   10   11   12   13   14   >