[Impala-ASF-CR] [PROTOTYPE] IMPALA-5872: Test case builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: [PROTOTYPE] IMPALA-5872: Test case builder for query planner .. Patch Set 1: (8 comments) Very nice. Far simpler than w

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: (3 comments) http://gerrit.clouder

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

Hello Bharath Vissapragada, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12192 to look at the new patch set (#2). Change subject: IMPALA-8058: Fallback for HBase key scan range estimation ..

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 2: (3 comments) Addressed code review comments.

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#10). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 10: Rebased on latest master. Added a few minor outpu

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12145 Change subject: IMPALA-8034: Improve planner tests .. IMPALA-8034: Improve planner tests The FE PlannerTest cases are good, but often unr

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#11). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Looks like some e-to-e test "golden" files need u

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12248 Change subject: IMPALA-8095: Detailed expression cardinality tests .. IMPALA-8095: Detailed expression cardinality tests Cardinality is a

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 11: Pre-review tests now pass again. Please go ahead

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12009 to look at the new patch set (#12). Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .

[Impala-ASF-CR] IMPALA-7905: Hive keywords not quoted for identifiers

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12009 ) Change subject: IMPALA-7905: Hive keywords not quoted for identifiers .. Patch Set 12: (1 comment) Addressed the code review comment.

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11953 to look at the new patch set (#3). Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs ...

[Impala-ASF-CR] IMPALA-7866: Predicates, helpers for implicit casts, slot refs

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11953 ) Change subject: IMPALA-7866: Predicates, helpers for implicit casts, slot refs .. Patch Set 2: Rebased on latest master to resolve merge

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#3). Change subject: IMPALA-8095: Detailed expression cardinality tests .. I

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 2: Rebased on latest master. A catalog_.close() line was

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12143 to look at the new patch set (#2). Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes ..

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 2: Rebased on latest master. Resolved check style i

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/11915 to look at the new patch set (#3). Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging ...

[Impala-ASF-CR] IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11915 ) Change subject: IMPALA-7841 (Part 1): Refactor SelectStmt for easier debugging .. Patch Set 3: (1 comment) Addressed review comment. Re

[Impala-ASF-CR] IMPALA-7968, Part 1: JSON serialization framework

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12079 ) Change subject: IMPALA-7968, Part 1: JSON serialization framework .. Patch Set 8: Hi Bharath, Fredy gave this a +1. Can you take a quick

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 1: Hi Bharath, this one should be a simple one; please tak

[Impala-ASF-CR] IMPALA-7970 : Add support for metastore event based automatic invalidate

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12118 ) Change subject: IMPALA-7970 : Add support for metastore event based automatic invalidate .. Patch Set 22: (3 comments) Thanks much for

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 2: (3 comments) Minor suggestions, otherwise looks pretty

[Impala-ASF-CR] IMPALA-7929. Impala query on HBASE table failing with InternalException.

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12213 ) Change subject: IMPALA-7929. Impala query on HBASE table failing with InternalException. .. Patch Set 3: (1 comment) http://gerrit.clo

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#4). Change subject: IMPALA-8095: Detailed expression cardinality tests .

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 4: Fixed check style issues. -- To view, visit http://

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12144 to look at the new patch set (#3). Change subject: IMPALA-8041, Part 2: Refactor SELECT list ..

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 2: (6 comments) Thanks Fredy for the review. Addressed your comm

[Impala-ASF-CR] IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S)

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12181 ) Change subject: IMPALA-7832: Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN(S) .. Patch Set 8: Code-Review+1 LGTM -- To view, vi

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

Hello Bharath Vissapragada, Zoram Thanga, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12192 to look at the new patch set (#3). Change subject: IMPALA-8058: Fallback for HBase key scan range estimation ..

[Impala-ASF-CR] IMPALA-8058: Fallback for HBase key scan range estimation

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12192 ) Change subject: IMPALA-8058: Fallback for HBase key scan range estimation .. Patch Set 2: (2 comments) Hi Bharath, Thanks much for the

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#5). Change subject: IMPALA-8095: Detailed expression cardinality tests ..

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 5: (4 comments) Thanks for the review Tim. Addressed re

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12143 to look at the new patch set (#3). Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes ..

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12143 ) Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes .. Patch Set 2: Rebased on latest master -- To view, visit htt

[Impala-ASF-CR] IMPALA-7867 (Part 5): Collection cleanup in analyzer

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12266 ) Change subject: IMPALA-7867 (Part 5): Collection cleanup in analyzer .. Patch Set 2: Second-to-last collection cleanup patch. Almost the

[Impala-ASF-CR] IMPALA-7867 (Part 5): Collection cleanup in analyzer

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12266 Change subject: IMPALA-7867 (Part 5): Collection cleanup in analyzer .. IMPALA-7867 (Part 5): Collection cleanup in analyzer Continues th

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

Paul Rogers has uploaded a new patch set (#2) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. IMPALA-7450.

[Impala-ASF-CR] IMPALA-7450. Set thread name during refresh/load operations

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11228 ) Change subject: IMPALA-7450. Set thread name during refresh/load operations .. Patch Set 2: (5 comments) Applied code review comments.

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 3: (12 comments) Bharath, ap

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

Paul Rogers has uploaded a new patch set (#3) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog ..

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 ) Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. Patch Set 1: Code-Review+1 Thanks for jumping

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

Paul Rogers has uploaded a new patch set (#4) to the change originally created by Todd Lipcon. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog ..

[Impala-ASF-CR] IMPALA-7540. Intern most repetitive strings and network addresses in catalog

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/11158 ) Change subject: IMPALA-7540. Intern most repetitive strings and network addresses in catalog .. Patch Set 3: (2 comments) Addressed re

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 2: (8 comments) Added a few comments. Verified that CAST(ex

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 3: (6 comments) Just a few minor comments. As noted before

[Impala-ASF-CR] IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12288 ) Change subject: IMPALA-8129: Don't test exact value of ExchangeScanRatio on S3 and EC .. Patch Set 4: (1 comment) Hi Lars, thanks for

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12145 ) Change subject: IMPALA-8034: Improve planner tests .. Patch Set 3: Bharath, can you take a look at this one? Would be very helpful to ge

[Impala-ASF-CR] Logging current database context when logging analyzing queries.

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12301 ) Change subject: Logging current database context when logging analyzing queries. .. Patch Set 1: (1 comment) This is a one-line change,

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 3: (1 comment) Key question here is the syntax of the forma

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12317 Change subject: IMPALA-8148: Misc. FE code cleanup .. IMPALA-8148: Misc. FE code cleanup Roll-up of a bunch of minor code cleanup and ref

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12317 ) Change subject: IMPALA-8148: Misc. FE code cleanup .. Patch Set 2: Passed pre-review tests: https://jenkins.impala.io/job/pre-review-tes

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12317 to look at the new patch set (#3). Change subject: IMPALA-8148: Misc. FE code cleanup ...

[Impala-ASF-CR] IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12334 ) Change subject: IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure .. Patch Set 4: (2 comments) Thanks for cleaning th

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 5: (8 comments) Reviewed the latest changes. Looking good.

[Impala-ASF-CR] IMPALA-8156: Add format options to the EXPLAIN statement

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12340 Change subject: IMPALA-8156: Add format options to the EXPLAIN statement .. IMPALA-8156: Add format options to the EXPLAIN statement Adds

[Impala-ASF-CR] IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12334 ) Change subject: IMPALA-8150: Fix buggy AuditingTest::TestAccessEventsOnAuthFailure .. Patch Set 5: Code-Review+1 The changes look sound

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12360 ) Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. Patch Set 1: (3 comments) Thanks for the improvement.

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12145 ) Change subject: IMPALA-8034: Improve planner tests .. Patch Set 4: (10 comments) Addressed code review comments and rebased on master.

[Impala-ASF-CR] IMPALA-8034: Improve planner tests

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12145 to look at the new patch set (#4). Change subject: IMPALA-8034: Improve planner tests ...

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

Paul Rogers has uploaded a new patch set (#10). ( http://gerrit.cloudera.org:8080/12265 ) Change subject: IMPALA-8106: Cleanup of literal expression nodes .. IMPALA-8106: Cleanup of literal expression nodes IMPALA-7902 cleaned

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12317 to look at the new patch set (#4). Change subject: IMPALA-8148: Misc. FE code cleanup .

[Impala-ASF-CR] IMPALA-8103: In Analyzed Query use /* and */ to delimit hints.

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12360 ) Change subject: IMPALA-8103: In Analyzed Query use /* and */ to delimit hints. .. Patch Set 2: Code-Review+2 (1 comment) http://gerrit.

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12317 to look at the new patch set (#5). Change subject: IMPALA-8148: Misc. FE code cleanup .

[Impala-ASF-CR] IMPALA-8148: Misc. FE code cleanup

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12317 to look at the new patch set (#6). Change subject: IMPALA-8148: Misc. FE code cleanup .

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12265 to look at the new patch set (#11). Change subject: IMPALA-8106: Cleanup of literal expression nodes .. IM

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 1: (10 comments) Thanks for this a

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (9 comments) http://gerrit.cloudera.org:8080/#/c/12221/

[Impala-ASF-CR] IMPALA-8156: Add format options to the EXPLAIN statement

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12340 ) Change subject: IMPALA-8156: Add format options to the EXPLAIN statement .. Patch Set 1: This version is for preview: do we like the ide

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12033 to look at the new patch set (#2). Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Hello Bharath Vissapragada, Fredy Wijaya, Tim Armstrong, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12248 to look at the new patch set (#6). Change subject: IMPALA-8095: Detailed expression cardinality tests ..

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: (5 comments) Thanks for the review Bharath. Addresse

[Impala-ASF-CR] IMPALA-8041, Part 1: Move rewrite rules into expr nodes

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12143 to look at the new patch set (#4). Change subject: IMPALA-8041, Part 1: Move rewrite rules into expr nodes ..

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 2: (2 comments) Looks like the sty

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: Passed pre-review tests: https://jenkins.impala.io/jo

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12265 to look at the new patch set (#12). Change subject: IMPALA-8106: Cleanup of literal expression nodes .. IM

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12265 ) Change subject: IMPALA-8106: Cleanup of literal expression nodes .. Patch Set 12: Pre-review tests passed: https://jenkins.impala.io/job

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/12221/

[Impala-ASF-CR] IMPALA-8095: Detailed expression cardinality tests

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12248 ) Change subject: IMPALA-8095: Detailed expression cardinality tests .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/1224

[Impala-ASF-CR] IMPALA-5872: Testcase builder for query planner

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12221 ) Change subject: IMPALA-5872: Testcase builder for query planner .. Patch Set 9: Code-Review+2 Thanks much for all the fixes. LGTM. --

[Impala-ASF-CR] IMPALA-8177: Log DDL failures in coordinator logs

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12414 ) Change subject: IMPALA-8177: Log DDL failures in coordinator logs .. Patch Set 4: Late to the party, but we want to log detailed stack t

[Impala-ASF-CR] Additions to .gitignore

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12430 Change subject: Additions to .gitignore .. Additions to .gitignore Adds entries for Eclipse-created files and for a couple of temporary f

[Impala-ASF-CR] Additions to .gitignore

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12430 ) Change subject: Additions to .gitignore .. Patch Set 1: This is a very simple one. Please take a look at your convenience. -- To view,

[Impala-ASF-CR] IMPALA-8039: Incorrect selectivity estimate for not-equals predicate

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12427 Change subject: IMPALA-8039: Incorrect selectivity estimate for not-equals predicate .. IMPALA-8039: Incorrect selectivity estimate for n

[Impala-ASF-CR] IMPALA-8039: Incorrect selectivity estimate for not-equals predicate

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12427 ) Change subject: IMPALA-8039: Incorrect selectivity estimate for not-equals predicate .. Patch Set 2: Bharath, this is a first small sel

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 3: (5 comments) Initial, superficial review.

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12436 ) Change subject: IMPALA-8182: Add single-node plan to PlanCtx .. Patch Set 1: A simple one: just providing access to single plan nodes fo

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

Paul Rogers has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12436 Change subject: IMPALA-8182: Add single-node plan to PlanCtx .. IMPALA-8182: Add single-node plan to PlanCtx Historically, the Impala pla

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

Paul Rogers has abandoned this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Abandoned will rethink the approach. -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-7927: Enhance Rewritten SQL in test files

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12033 ) Change subject: IMPALA-7927: Enhance Rewritten SQL in test files .. Patch Set 2: Good points. Let me rethink this. The reason for the cu

[Impala-ASF-CR] IMPALA-7961: Avoid adding unmodified objects to DDL response

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12428 ) Change subject: IMPALA-7961: Avoid adding unmodified objects to DDL response .. Patch Set 5: Code-Review+2 (1 comment) LGTM. One very m

[Impala-ASF-CR] IMPALA-7976 : Add a flag to disable sync using events at a table level

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12365 ) Change subject: IMPALA-7976 : Add a flag to disable sync using events at a table level .. Patch Set 8: (3 comments) http://gerrit.clou

[Impala-ASF-CR] IMPALA-8182: Add single-node plan to PlanCtx

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12436 to look at the new patch set (#2). Change subject: IMPALA-8182: Add single-node plan to PlanCtx .

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12265 to look at the new patch set (#13). Change subject: IMPALA-8106: Cleanup of literal expression nodes

[Impala-ASF-CR] IMPALA-4018 Part1: Add FORMAT clause in CAST()

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12267 ) Change subject: IMPALA-4018 Part1: Add FORMAT clause in CAST() .. Patch Set 6: (6 comments) Great progress. Mostly nits, and one questi

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

Hello Bharath Vissapragada, Fredy Wijaya, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12144 to look at the new patch set (#4). Change subject: IMPALA-8041, Part 2: Refactor SELECT list ..

[Impala-ASF-CR] IMPALA-8041, Part 2: Refactor SELECT list

Paul Rogers has posted comments on this change. ( http://gerrit.cloudera.org:8080/12144 ) Change subject: IMPALA-8041, Part 2: Refactor SELECT list .. Patch Set 4: Rebased on master to resolve merge conflicts. This is one of s

[Impala-ASF-CR] IMPALA-8106: Cleanup of literal expression nodes

Hello Bharath Vissapragada, Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/12265 to look at the new patch set (#14). Change subject: IMPALA-8106: Cleanup of literal expression nodes

  1   2   3   4   5   >