[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#3). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 1: (12 comments) The main problem with subclassing

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-09-28 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#2). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 10: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4389 To unsubscribe,

[Impala-ASF-CR] IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls

2016-09-28 Thread anujphadke (Code Review)
anujphadke has uploaded a new change for review. http://gerrit.cloudera.org:8080/4561 Change subject: IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. IMPALA-4207: test infra: move Hive options from connection to

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4206: Add column lineage regression test. .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4180: Synchronize accesses to RuntimeState::reader contexts

2016-09-28 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/4558 Change subject: IMPALA-4180: Synchronize accesses to RuntimeState::reader_contexts_ .. IMPALA-4180: Synchronize accesses to

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 1: -Code-Review Actually, can you add a regression test for this? There was definitely missing

[Impala-ASF-CR] IMPALA-4023: don't attach buffered tuple streams to batches

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4023: don't attach buffered tuple streams to batches .. Patch Set 3: Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4448 To

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4196: Cross compile bit-byte-functions .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4557 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4196: Cross compile bit-byte-functions

2016-09-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new change for review. http://gerrit.cloudera.org:8080/4557 Change subject: IMPALA-4196: Cross compile bit-byte-functions .. IMPALA-4196: Cross compile bit-byte-functions Change-Id:

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (14 comments) Very nice! Minor nits in the code,

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/4389/6/be/src/util/openssl-util.cc

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. IMPALA-3308: Get expr-test passing on PPC64LE When using gcc 5+ (which introduced a new library ABI

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 22: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3873 To unsubscribe,

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder The main outcome of this patch is

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4206: Add column lineage regression test. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-28 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4556 to look at the new patch set (#2). Change subject: IMPALA-4206: Add column lineage regression test. ..

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4206: Add column lineage regression test. .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Private data load is green after 6.5 hours

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. IMPALA-4118: extract encryption utils from BufferedBlockMgr As groundwork for IMPALA-4118, extract

[Impala-ASF-CR] IMPALA-4118: extract encryption utils from BufferedBlockMgr

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4118: extract encryption utils from BufferedBlockMgr .. Patch Set 9: Rebase -- To view, visit http://gerrit.cloudera.org:8080/4389 To unsubscribe,

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Oh and the diff is much larger now due to having made requested

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 3: Code-Review+1 (2 comments) done; carry +1 Trying to fix a build

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Hello Sahil Takiar, David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4555 to look at the new patch set (#3). Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-28 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (2 comments)

[Impala-ASF-CR] IMPALA-4206: Add column lineage regression test.

2016-09-28 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4206: Add column lineage regression test. .. Patch Set 1: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-28 Thread Zoltan Ivanfi (Code Review)
Zoltan Ivanfi has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (3 comments)

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3201: in-memory buffer pool implementation .. Patch Set 10: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: > Just curious, what are the other modules that use cli_options?

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Code-Review+1 It looks like this job:

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/4350/9/be/src/util/blocking-queue.h File

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 6: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4186 To

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 5: I'll merge this -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 22: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3873 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 22: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/3873

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 14: (15 comments)

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#14). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#22). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-09-28 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#14). Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Tim Armstrong (Code Review)
Hello Michael Ho, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3873 to look at the new patch set (#21). Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 20: (1 comment)

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Code-Review+1 Just curious, what are the other modules that use

[Impala-ASF-CR] IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder

2016-09-28 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ builder .. Patch Set 20: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4026: Implement double-buffering for BlockingQueue

2016-09-28 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4350 to look at the new patch set (#10). Change subject: IMPALA-4026: Implement double-buffering for BlockingQueue ..

[Impala-ASF-CR] IMPALA-784: Use `-s in SHOW CREATE TABLE output

2016-09-28 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-784: Use `-s in SHOW CREATE TABLE output .. Patch Set 2: (5 comments)

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. Patch Set 1: Lots of testing to do yet. -- To view, visit

[Impala-ASF-CR] IMPALA-4207: test infra: move Hive options from connection to cluster options

2016-09-28 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/4555 Change subject: IMPALA-4207: test infra: move Hive options from connection to cluster options .. IMPALA-4207: test infra: move Hive

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2016-09-28 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4554 Change subject: IMPALA-4086: Add benchmark for simple scheduler .. IMPALA-4086: Add benchmark for simple scheduler Change-Id:

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

2016-09-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1" .. Patch Set 1: There now seem to be 5 different Gerrit changes

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

2016-09-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1" .. Patch Set 1: (2 comments)

[Impala-ASF-CR] IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1"

2016-09-28 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4057 and IMPALA-4050 Support starting webserver specified by hostname or "127.0.0.1" .. Patch Set 1: (6 comments)

[Impala-ASF-CR] IMPALA-3201: in-memory buffer pool implementation

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3201: in-memory buffer pool implementation .. Patch Set 9: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4070 To unsubscribe, visit