[Impala-ASF-CR] PREVIEW IMPALA-3644 Make predicate order deterministic

2016-10-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: PREVIEW IMPALA-3644 Make predicate order deterministic .. Patch Set 1: Thanks, Lars! Change looks good, let's wait for your validation. -- To view, visit

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 1: (3 comments) FWIW, this patch probably needs to wait for

[Impala-ASF-CR] PREVIEW IMPALA-3644 Make predicate order deterministic

2016-10-07 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4671 Change subject: PREVIEW IMPALA-3644 Make predicate order deterministic .. PREVIEW IMPALA-3644 Make predicate order deterministic This

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-07 Thread Todd Lipcon (Code Review)
Hello Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4670 to review the following change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. WIP: Use

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 9: After some discussion, moved the result materialization into Send(). The

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#9). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. IMPALA-2905: Handle coordinator fragment lifecycle like all others The plan-root fragment

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4231: fix codegen time regression .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4623/2/be/src/exec/partitioned-aggregation-node.h File

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: (1 comment)

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-07 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#5). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: Code-Review+1 (2 comments) carry Alex +1

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 14: (3 comments) thanks

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#14). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load .. Patch Set 3: (1 comment) Added a test.

[Impala-ASF-CR] IMPALA-3983/IMPALA-3974: Delete function jar resources after load

2016-10-07 Thread Bharath Vissapragada (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4617 to look at the new patch set (#4). Change subject: IMPALA-3983/IMPALA-3974: Delete function jar resources after load

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 13: Code-Review+1 (1 comment) Nice work! Please address the remaining nits. Henry or

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 13: (2 comments)

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 12: (10 comments) http://gerrit.cloudera.org:8080/#/c/4349/12//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-07 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#13). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-07 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 1: (16 comments) http://gerrit.cloudera.org:8080/#/c/4651/1//COMMIT_MSG Commit Message: PS1,

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-07 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() This patch is mostly mechanical move of codegen

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. Patch Set 8: Code-Review+2 Rebase (plus add a flag and disable the test), carry

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. Patch Set 1: Code-Review+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses

2016-10-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses

2016-10-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has submitted this change and it was merged. Change subject: IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses .. IMPALA-4232: qgen: Hive does not support aggregates inside

[Impala-ASF-CR] IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value

2016-10-07 Thread Juan Yu (Code Review)
Juan Yu has uploaded a new change for review. http://gerrit.cloudera.org:8080/4668 Change subject: IMPALA-4253: impala-server.backends.client-cache.total-clients shows negative value .. IMPALA-4253:

[Impala-ASF-CR] IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses

2016-10-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has posted comments on this change. Change subject: IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses .. Patch Set 6: (1 comment) @Taras, comments addressed.

[Impala-ASF-CR] IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses

2016-10-07 Thread Sahil Takiar (Code Review)
Sahil Takiar has uploaded a new patch set (#6). Change subject: IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses .. IMPALA-4232: qgen: Hive does not support aggregates inside specific

[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive

2016-10-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive .. Patch Set 2: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive

2016-10-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4240: qgen: Add "ParseException line missing )" to Known Errors for Hive .. Patch Set 2: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses

2016-10-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4232: qgen: Hive does not support aggregates inside specific analytic clauses .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 12: (8 comments) Almost there http://gerrit.cloudera.org:8080/#/c/4349/12//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 11: (8 comments) thanks! http://gerrit.cloudera.org:8080/#/c/4349/11//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Huaisi Xu (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#12). Change subject: IMPALA-1702: Enforce table level consistency ..

[Impala-ASF-CR] IMPALA-4135: Thrift threaded server times-out connections during high load

2016-10-07 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#8). Change subject: IMPALA-4135: Thrift threaded server times-out connections during high load .. IMPALA-4135: Thrift threaded server times-out connections during high load During

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 7: (20 comments) Thanks for your patience

[Impala-ASF-CR] IMPALA-1702: Enforce table level consistency

2016-10-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1702: Enforce table level consistency .. Patch Set 11: Code-Review+1 (1 comment) The change looks fine to me. Thanks for working on this Huaisi.

[Impala-ASF-CR] IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION

2016-10-07 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-1670,IMPALA-4141: Support multiple partitions in ALTER TABLE ADD PARTITION .. Patch Set 15: (21 comments)

[Impala-ASF-CR] IMPALA-4076: Fix runtime filter sort compare method

2016-10-07 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4076: Fix runtime filter sort compare method .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4652 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4076: Fix runtime filter sort compare method

2016-10-07 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4076: Fix runtime filter sort compare method .. IMPALA-4076: Fix runtime filter sort compare method Fixed 2 isssues: - The getSelectivity()