[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#17). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment This script bootstraps

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4674 To unsubscrib

[Impala-ASF-CR] IMPALA-3943: Address post-merge comments.

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3943: Address post-merge comments. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4696 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-3943: Address post-merge comments.

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3943: Address post-merge comments. .. IMPALA-3943: Address post-merge comments. Adds code comments and issues a warning for Parquet files with

[Impala-ASF-CR] IMPALA-4288: Separate conjunct registration from analysis.

2016-10-13 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#7). Change subject: IMPALA-4288: Separate conjunct registration from analysis. .. IMPALA-4288: Separate conjunct registration from analysis. Our existing analyze() of statemens registers

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 16: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-4291: Reduce LLVM module's preparation time

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4291: Reduce LLVM module's preparation time .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4691 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-4291: Reduce LLVM module's preparation time

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4291: Reduce LLVM module's preparation time .. IMPALA-4291: Reduce LLVM module's preparation time Previously, when creating a LlvmCodeGen obje

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4231: fix codegen time regression .. IMPALA-4231: fix codegen time regression The commit "IMPALA-3567 Part 2, IMPALA-3899: factor out PHJ buil

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4231: fix codegen time regression .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4623 To unsubscribe, visit http://gerri

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 4: > When did we decide that the change in the comment was one we > wanted? For one, I prefer havi

[Impala-ASF-CR] IMPALA-4134: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-13 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: IMPALA-4134: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4670/3/be/src/exec/kudu-table-sink.cc File b

[Impala-ASF-CR] IMPALA-4134: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-4134: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. IMPALA-4134: Use AUTO_FLUSH_BACKGROUND for Kudu sink Improves performance of writes to Kudu. Testing: Man

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 1: (3 comments) I'm taking over the patch and will update it soon. http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 4: When did we decide that the change in the comment was one we wanted? For one, I prefer hav

[Impala-ASF-CR] DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has abandoned this change. Change subject: DO NOT SUBMIT: Example diffs of http://gerrit.cloudera.org/#/c/4590/ .. Abandoned http://gerrit.cloudera.org/#/c/4590/ submitted -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has submitted this change and it was merged. Change subject: Match .clang-format more closely to actual practice. .. Match .clang-format more closely to actual practice. In order to attempt to get code like doubl

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 3: Verified+1 Can't break tests with this change, so +1 verify manually -- To view, visit http://

[Impala-ASF-CR] Match .clang-format more closely to actual practice.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Match .clang-format more closely to actual practice. .. Patch Set 3: Code-Review+2 rebase, carry +1 into +2 -- To view, visit http://gerrit.cloudera.org:8080/4590

[Impala-ASF-CR] IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3971, IMPALA-3229: Bootstrap an Impala dev environment .. Patch Set 5: Code-Review+2 Carry +1 into +2 -- To view, visit http://gerrit.cloudera.org:8080/4674

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4678/7/tests/comparison/

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4677/1/testdata/workloads/functio

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-13 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#4). Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. MT_DOP > 0 is only supported fo

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#6). Change subject: IMPALA-3739: Enable stress tests on Kudu .. IMPALA-3739: Enable stress tests on Kudu This commit modifies the stress test framework to run TPC-H and TPC-DS

[Impala-ASF-CR] IMPALA-3739: Enable stress tests on Kudu

2016-10-13 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3739: Enable stress tests on Kudu .. Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/4327/5/testdata/datasets/tpcds/tpcds_kudu_temp

[Impala-ASF-CR] IMPALA-3943: Address post-merge comments.

2016-10-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3943: Address post-merge comments. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4696 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] Buffer pool: Add basic counters to buffer pool client

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4714 Change subject: Buffer pool: Add basic counters to buffer pool client .. Buffer pool: Add basic counters to buffer pool client Change-Id

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 8: Code-Review+1 Carry David's +1 -- To view, visit http://gerrit.cloudera.org:8080/4678 To

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 8: (3 comments) Thanks for the review, Taras. Please see patch set 8. http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/4494/10/be/src/util/bit-packing-test.cc File be/src/util/bit-p

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Hello David Knupp, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4678 to look at the new patch set (#8). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#11). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support readin

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, Internal Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#16). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others ..

[Impala-ASF-CR] IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. Abandoned wrong branch -- To view, visit http://gerrit.cloudera.org:8080/4722 To uns

[Impala-ASF-CR] IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4722 Change subject: IMPALA-4277: temporary hack to avoid compile errors for HDFS block location API .. IMPALA-4277: temporary hack to avoid

[Impala-ASF-CR] IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Abandoned wrong branch -- To view, visit http://gerrit.cloudera.org:8080/4721 To unsubscribe, v

[Impala-ASF-CR] IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4721 Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. IMPALA-4277: bump Hadoop component versions exce

[Impala-ASF-CR] IMPALA-4277: allow overriding of Hive/Hadoop versions/locations

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4720 Change subject: IMPALA-4277: allow overriding of Hive/Hadoop versions/locations .. IMPALA-4277: allow overriding of Hive/Hadoop versions/

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/4678/7/tests/comparison/leopard/impal

[Impala-ASF-CR] WIP: Use AUTO FLUSH BACKGROUND for Kudu sink

2016-10-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: Use AUTO_FLUSH_BACKGROUND for Kudu sink .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4670/1/be/src/exec/kudu-table-sink.cc File be/src/

[Impala-ASF-CR] Bump Bzip2 version

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Bump Bzip2 version .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4716 To unsubscribe, visit http://gerrit.cloudera.org:8080/se

[Impala-ASF-CR] Bump Bzip2 version

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Bump Bzip2 version .. Bump Bzip2 version This picks up the latest toolchain version. The only change is that some symlinks in the previous version we

[Impala-ASF-CR] IMPALA-3718: Add test cancellation tests for Kudu

2016-10-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3718: Add test_cancellation tests for Kudu .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4700/1/tests/query_test/test_cancellation.py

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 14: Verified-1 Build failed: http://sandbox.jenkins.cloudera.com/job/impala-

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4231: fix codegen time regression .. Patch Set 5: Code-Review+2 Carry Michael's +2 -- To view, visit http://gerrit.cloudera.org:8080/4623 To unsubscribe

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-13 Thread Tim Armstrong (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4623 to look at the new patch set (#4). Change subject: IMPALA-4231: fix codegen time regression .. IMPALA-4231: fix codeg

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4231: fix codegen time regression .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4623/3/be/src/exec/partitioned-hash-join-builder-ir.cc

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 15: Marcel, any more comments? -- To view, visit http://gerrit.cloudera.org:8080/4349

[Impala-ASF-CR] IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls

2016-10-13 Thread anujphadke (Code Review)
anujphadke has abandoned this change. Change subject: IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls .

[Impala-ASF-CR] IMPALA-4231: fix codegen time regression

2016-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4231: fix codegen time regression .. Patch Set 3: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/4623/3/be/src/exec/partitioned-hash-join-bu

[Impala-ASF-CR] IMPALA-4291: Reduce LLVM module's preparation time

2016-10-13 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4691 to look at the new patch set (#4). Change subject: IMPALA-4291: Reduce LLVM module's preparation time .. IMPALA-42

[Impala-ASF-CR] IMPALA-4291: Reduce LLVM module's preparation time

2016-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4291: Reduce LLVM module's preparation time .. Patch Set 4: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/4691 To unsub

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 4: It would be good to have an additional pair of eyes since it's a significant behaviour c

[Impala-ASF-CR] Reduce LLVM module's preparation time by lazily creating the IRFunction::Type to LLVM::Function* mappings.

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Reduce LLVM module's preparation time by lazily creating the IRFunction::Type to LLVM::Function* mappings. .. Patch Set 3: Code-Review+2 -- To view, visit http

[Impala-ASF-CR] IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3342, IMPALA-3920: Adding thread counters to obtain thread stats per scanner thread, and to measure time spent in per-fragment-executor Open() and ProcessBuildInputAsync calls .

[Impala-ASF-CR] IMPALA-3943: Address post-merge comments.

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3943: Address post-merge comments. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4696 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/4494/10/be/src/util/bit-packing-test.cc File be/src/util/bit-packi

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4698/1/bin/impala-config.s

[Impala-ASF-CR](hadoop-next) IMPALA-4277: bump Hadoop component versions except for Hadoop itself

2016-10-13 Thread Charlie Helin (Code Review)
Charlie Helin has posted comments on this change. Change subject: IMPALA-4277: bump Hadoop component versions except for Hadoop itself .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4698/1/bin/impala-config.s

[Impala-ASF-CR] IMPALA-3002/1473: Cardinality observability cleanup

2016-10-13 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-3002/1473: Cardinality observability cleanup .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4679/2//COMMIT_MSG Commit Message: PS2, L

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 7: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4678 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 15: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/4402/12/be/src/runtime/co

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Henry Robinson (Code Review)
Hello Marcel Kornacker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4402 to look at the new patch set (#14). Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4651 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-13 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#4). Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() This patch is mostly mechanical move of codegen rel

[Impala-ASF-CR] IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen()

2016-10-13 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4080, IMPALA-3638: Introduce ExecNode::Codegen() .. Patch Set 3: (9 comments) http://gerrit.cloudera.org:8080/#/c/4651/3/be/src/exec/hash-join-node.cc File

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 5: (8 comments) http://gerrit.cloudera.org:8080/#/c/4678/5//COMMIT_MSG Commit Message: PS5,

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#7). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be able to run the Random Query Generator with Im

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4188: Leopard: support external Docker volumes .. Patch Set 6: Patch set 6 is a rebase, and conflicts with the commit of https://gerrit.cloudera.org/#/c/

[Impala-ASF-CR] IMPALA-4188: Leopard: support external Docker volumes

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new patch set (#6). Change subject: IMPALA-4188: Leopard: support external Docker volumes .. IMPALA-4188: Leopard: support external Docker volumes To be able to run the Random Query Generator with Im

[Impala-ASF-CR] Bump Bzip2 version

2016-10-13 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Bump Bzip2 version .. Patch Set 1: Code-Review+1 Whoops, I had completely forgotten about fixing this on this end. Thanks. -- To view, visit http://gerrit.clou

[Impala-ASF-CR] Bump Bzip2 version

2016-10-13 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Bump Bzip2 version .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settin

[Impala-ASF-CR] Bump Bzip2 version

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4716 Change subject: Bump Bzip2 version .. Bump Bzip2 version This picks up the latest toolchain version. The only change is that some symlin

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#10). Change subject: IMPALA-4123: Fast bit unpacking .. IMPALA-4123: Fast bit unpacking Adds utility functions for fast unpacking of batches of bit-packed values. These support readin

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 7: (3 comments) Sorry about that - I wish there was a good way to see whether I've responded to all of the comment

[Impala-ASF-CR] IMPALA-4270: Gracefully fail unsupported queries with mt dop > 0.

2016-10-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4270: Gracefully fail unsupported queries with mt_dop > 0. .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4677/1/testdata/workloads/

[Impala-ASF-CR] IMPALA-889: Add support for an ISO-SQL compliant trim() function.

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-889: Add support for an ISO-SQL compliant trim() function. .. Patch Set 8: (24 comments) http://gerrit.cloudera.org:8080/#/c/4474/8//COMMIT_MSG Commit Messa

[Impala-ASF-CR] IMPALA-4123: Fast bit unpacking

2016-10-13 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4123: Fast bit unpacking .. Patch Set 9: > (11 comments) It looks like you might have missed my comments on Base and PS7 in this group of comments. -- To

[Impala-ASF-CR] IMPALA-2905: Handle coordinator fragment lifecycle like all others

2016-10-13 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2905: Handle coordinator fragment lifecycle like all others .. Patch Set 13: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/4402/12/b