[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-24 Thread Michael Ho (Code Review)
Michael Ho has submitted this change and it was merged. Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue() .. IMPALA-3884: Support TYPE_TIMESTAMP for

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build,

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4785 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. IMPALA-4339: ensure coredumps end up in IMPALA_HOME Change-Id:

[Impala-ASF-CR] IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache .. Patch Set 1: > (1 comment) > > The change makes sense and we should get it in regardless, but >

[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue() .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4794

[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue() .. Patch Set 3:

[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-24 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#3). Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue() .. IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 6: (4 comments)

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. IMPALA-4134,IMPALA-3704: Kudu INSERT improvements 1.) IMPALA-4134: Use Kudu AUTO FLUSH Improves

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-24 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 10: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe,

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Add distcc infrastructure. .. Add distcc infrastructure. This has been working for several months, and it it was written mainly by Casey Ching while

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4820 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4223: Handle truncated file read from HDFS cache .. Patch Set 1: (1 comment) The change makes sense and we should get it in regardless, but could this

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/4771 To

[Impala-ASF-CR] IMPALA-4350: Crash with vlog level 2 in hash join node

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4830 Change subject: IMPALA-4350: Crash with vlog level 2 in hash join node .. IMPALA-4350: Crash with vlog level 2 in hash join node

[Impala-ASF-CR] IMPALA-4362: Misc. fixes for PFE counters

2016-10-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4829 Change subject: IMPALA-4362: Misc. fixes for PFE counters .. IMPALA-4362: Misc. fixes for PFE counters * ExecTime was always 0,

[Impala-ASF-CR] Minor compute stats script fixes

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Minor compute stats script fixes .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4825 To unsubscribe, visit

[Impala-ASF-CR] Minor compute stats script fixes

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: Minor compute stats script fixes .. Minor compute stats script fixes * Change run-step to output full log path * Change text to say "Computing table

[Impala-ASF-CR] IMPALA-4223: Handle truncated file read from HDFS cache

2016-10-24 Thread Lars Volker (Code Review)
Lars Volker has uploaded a new change for review. http://gerrit.cloudera.org:8080/4828 Change subject: IMPALA-4223: Handle truncated file read from HDFS cache .. IMPALA-4223: Handle truncated file read from HDFS cache While

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 4: Also I had a previous question about how COMPUTE STATS behaves. -- To view,

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 10: Code-Review+1 Thanks! -- To view, visit http://gerrit.cloudera.org:8080/4745 To unsubscribe,

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. Patch Set 2: Build failed:

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 10: (1 comment) I added a test. I also had to rebase onto Dimitris' change, so now the diff

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-24 Thread Lars Volker (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4745 to look at the new patch set (#10). Change subject: IMPALA-2521: Add clustered hint to insert statements ..

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Sure I can take over. Most of these can be fixed using "Quick Fix" by the IDE. I'll take

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 2: Code-Review-1 Do you want to take over the patch Bharath? Please keep in mind that some code (even

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: The above ones I pasted are apart from invertOuterJoinState() you removed here. -- To

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: I ran the code analysis tool from my IDE and found huge amount of un-used code in the

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. Patch Set 2: Build failed:

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 8: Code-Review+2 (1 comment) rebased and addressed dan's comment. carrying his +2.

[Impala-ASF-CR] IMPALA-3788: Support for Kudu 'read-your-writes' consistency

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#3). Change subject: IMPALA-3788: Support for Kudu 'read-your-writes' consistency .. IMPALA-3788: Support for Kudu 'read-your-writes' consistency Kudu provides an API to get/set a

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4728 to look at the new patch set (#8). Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements ..

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Removed dead join inversion code from Analyzer. .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4827 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. Patch Set 2: This patch requires the fix for IMPALA-4336. See:

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-10-24 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4817 To unsubscribe,

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. Patch Set 4: (7 comments)

[Impala-ASF-CR] IMPALA-1169: Admission control info on the queries debug webpage

2016-10-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-1169: Admission control info on the queries debug webpage .. IMPALA-1169: Admission control info on the queries debug webpage This patch adds a

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4771 To unsubscribe,

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 7: Code-Review+2 (1 comment)

[Impala-ASF-CR] Removed dead join inversion code from Analyzer.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new change for review. http://gerrit.cloudera.org:8080/4827 Change subject: Removed dead join inversion code from Analyzer. .. Removed dead join inversion code from Analyzer. Change-Id:

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements. .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4817/1/be/src/exec/union-node.cc

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 2: Code-Review+1 Not +2 because I think it could use a review from someone who knows Cmake much

[Impala-ASF-CR] IMPALA-3586: Clean up union-node.h/cc to enable improvements.

2016-10-24 Thread Alex Behm (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4817 to look at the new patch set (#2). Change subject: IMPALA-3586: Clean up union-node.h/cc to enable improvements.

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 7: (8 comments) > (8 comments) > > The commit message doesn't really tell the full story here. In

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 7: (2 comments) Code looks fine, but want to close on the question at line 330 before +2ing.

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-24 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4758 to look at the new patch set (#7). Change subject: IMPALA-3676: Use clang as a static analysis tool ..

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 3: Code-Review+2 Carry Tim's +2 -- To view, visit http://gerrit.cloudera.org:8080/4820 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#17). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. IMPALA-1702: Enforce single-table consistency in query analysis. Catalogd managed table id

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#17). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 16: (10 comments) Thanks Marcel.

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 6: (1 comment)

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#6). Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. IMPALA-4309: Introduce Expr rewrite phase and supporting classes. Introduces a new phase for

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: Add all build targets to CMake and speed up builds .. Add all build targets to CMake and speed up builds Use CMake's dependency resolution always instead of

[Impala-ASF-CR] IMPALA-4309: Introduce Expr rewrite phase and supporting classes.

2016-10-24 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4309: Introduce Expr rewrite phase and supporting classes. .. Patch Set 5: (11 comments)

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. Patch Set 2: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4785 To

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. IMPALA-3211: provide toolchain build id for bootstrapping Testing: Ran a private build, which

[Impala-ASF-CR] IMPALA-4339: ensure coredumps end up in IMPALA HOME

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4339: ensure coredumps end up in IMPALA_HOME .. Patch Set 1: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4771/2/bin/impala-config.sh File

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has posted comments on this change. Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. Patch Set 16: solved conflict first. addressing comment next -- To view, visit

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Huaisi Xu has uploaded a new patch set (#16). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis. .. IMPALA-1702: Enforce single-table consistency in query analysis. Catalogd managed table id

[Impala-ASF-CR] IMPALA-1702: Enforce single-table consistency in query analysis.

2016-10-24 Thread Huaisi Xu (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4349 to look at the new patch set (#16). Change subject: IMPALA-1702: Enforce single-table consistency in query analysis.

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/4790/1/bin/make_impala.sh File

[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Build failed:

[Impala-ASF-CR] IMPALA-4134,IMPALA-3704: Kudu INSERT improvements

2016-10-24 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4134,IMPALA-3704: Kudu INSERT improvements .. Patch Set 6: (8 comments) http://gerrit.cloudera.org:8080/#/c/4728/6/be/src/exec/kudu-table-sink.cc File

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#7). Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions This change enables codegen

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 6: (7 comments)

[Impala-ASF-CR] IMPALA-3884: Support TYPE TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

2016-10-24 Thread Michael Ho (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4794 to look at the new patch set (#3). Change subject: IMPALA-3884: Support TYPE_TIMESTAMP for HashTableCtx::CodegenAssignNullValue()

[Impala-ASF-CR] Minor compute stats script fixes

2016-10-24 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/4825 Change subject: Minor compute stats script fixes .. Minor compute stats script fixes * Change run-step to output full log path *

[Impala-ASF-CR] IMPALA-2521: Add clustered hint to insert statements

2016-10-24 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-2521: Add clustered hint to insert statements .. Patch Set 9: (6 comments) Thanks for the comments, please see PS9.

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 2: Would be good to send out an email to dev@ once this goes in -- To view, visit http://gerrit.cloudera.org:8080/4820

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4820 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions

2016-10-24 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-1430,IMPALA-4108: codegen all builtin aggregate functions .. Patch Set 6: (7 comments) Looking good. Some more comments for now. Still doing another pass.

[Impala-ASF-CR] IMPALA-3676: Use clang as a static analysis tool

2016-10-24 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-3676: Use clang as a static analysis tool .. Patch Set 6: (8 comments) The commit message doesn't really tell the full story here. In particular, you

[Impala-ASF-CR] IMPALA-3211: provide toolchain build id for bootstrapping

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3211: provide toolchain build id for bootstrapping .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4771/2//COMMIT_MSG Commit Message: PS2,

[Impala-ASF-CR] Remove unused Bitmap code.

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: Remove unused Bitmap code. .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4801 To unsubscribe, visit

[Impala-ASF-CR] Add all build targets to CMake and speed up builds

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add all build targets to CMake and speed up builds .. Patch Set 1: (5 comments) Have you tested this in a clean environment, maybe with Docker or Jenkins?

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: Add distcc infrastructure. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/4820/1/bin/distcc/distcc.sh File bin/distcc/distcc.sh: Line 1:

[Impala-ASF-CR] Add distcc infrastructure.

2016-10-24 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new patch set (#2). Change subject: Add distcc infrastructure. .. Add distcc infrastructure. This has been working for several months, and it it was written mainly by Casey Ching while he was at

[Impala-ASF-CR] IMPALA-3725 Support Kudu UPSERT in Impala

2016-10-24 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3725 Support Kudu UPSERT in Impala .. Patch Set 12: Code-Review+1 (1 comment) Carrying forward Alex's +2

[Impala-ASF-CR] IMPALA-3552: make incremental stats max serialized size configurable

2016-10-24 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3552: make incremental stats max serialized size configurable .. Patch Set 1: @Yonghyun I had a chat with Alex on the best way to move forward.

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#4). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a

[Impala-ASF-CR] Enabling end-to-end tests on a remote cluster

2016-10-24 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#4). Change subject: Enabling end-to-end tests on a remote cluster .. Enabling end-to-end tests on a remote cluster This patch enables data loading and running end-to-end tests on a

[Impala-ASF-CR] IMPALA-4300: Speed up BloomFilter::Or with SIMD

2016-10-24 Thread Jim Apple (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4813 to look at the new patch set (#4). Change subject: IMPALA-4300: Speed up BloomFilter::Or with SIMD ..

[Impala-ASF-CR] IMPALA-4153: Fix count(*) on all blank('') columns - test

2016-10-24 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4153: Fix count(*) on all blank('') columns - test .. Patch Set 1: Verified-1 Build failed: