[Impala-ASF-CR] IMPALA-4431: Add audit event log control mechanism to prevent disk overflow

2016-12-21 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow .. Patch Set 11: Is there any expert review my code? Thanks. -- To view, visit

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 5: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2016-12-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 4: (10 comments)

[Impala-ASF-CR] IMPALA-4649: addendum - avoid overwriting MAKE ARGS

2016-12-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5558 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2016-12-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#4). Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. IMPALA-3524: Don't process spilled partitions with 0 probe rows In the partitioned

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5554 To unsubscribe,

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions This is the second patch to

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.

2016-12-21 Thread Alex Behm (Code Review)
Alex Behm has uploaded a new patch set (#2). Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE. .. IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE. The main problem was that the

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.

2016-12-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5556/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5554 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5554/2/testdata/bin/check-hbase-nodes.py

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. Patch Set 3: Code-Review+1 (1 comment)

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. Patch Set 2: Oh, I guess there's one other possible outcome -- NoNodeError: Connecting to Zookeeper

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. Patch Set 2: (4 comments) Success output: Connecting to Zookeeper host(s). Success: Waiting

[Impala-ASF-CR] IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions

2016-12-21 Thread David Knupp (Code Review)
David Knupp has uploaded a new patch set (#3). Change subject: IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions .. IMPALA-4684: Handle Zookeeper ConnentionLoss exceptions This is the second patch to address IMPALA-4684.

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2016-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#21). Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. IMPALA-3202,IMPALA-2079: rework scratch file I/O Refactor BufferedBlockMgr/TmpFileMgr to push more I/O logic

[Impala-ASF-CR] IMPALA-3202,IMPALA-2079: rework scratch file I/O

2016-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3202,IMPALA-2079: rework scratch file I/O .. Patch Set 20: (25 comments) Added an end-to-end test. This required adding a flag to allow multiple scratch

[Impala-ASF-CR] IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE.

2016-12-21 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3641: Fix catalogd RPC responses to DROP TABLE/DATABASE. .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5556/1//COMMIT_MSG

[Impala-ASF-CR] IMPALA-4014: Introduce query-wide execution state.

2016-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/4418/14/be/src/runtime/query-exec-mgr.cc

[Impala-ASF-CR] IMPALA-4649: addendum - avoid overwriting MAKE ARGS

2016-12-21 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/5558 Change subject: IMPALA-4649: addendum - avoid overwriting MAKE_ARGS .. IMPALA-4649: addendum - avoid overwriting MAKE_ARGS Re-tested to