[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-27 Thread David Knupp (Code Review)
Hello Lars Volker, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5640 to look at the new patch set (#6). Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. IM

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 6: Started http://jenkins.impala.io:8080/view/Utility/job/pre-review-test/10/ -- To view

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 9: > > (1 comment) > > > > > (2 comments) > > > > > > If you want to add th

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5400 to look at the new patch set (#10). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5400 to look at the new patch set (#10). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#10). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Parquet files are sca

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 10: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/5400/10/tests/q

[Impala-ASF-CR] IMPALA-4735: Upgrade pytest in python env to version 2.9.2.

2017-01-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4735: Upgrade pytest in python env to version 2.9.2. .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5640/6/tests/run-tests.py File test

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5743/3/fe/src/main/java/org/apac

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5809 Change subject: [DOCS] Add several items to "known issues" page .. [DOCS] Add several items to "known issues" page Change-Id: Ibeed92e8f6

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Hello Michael Ho, Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5400 to look at the new patch set (#11). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5400 To unsub

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new patch set (#11). Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. IMPALA-3989: Display skew warning for poorly formatted Parquet files Parquet files are sca

[Impala-ASF-CR] IMPALA-3989: Display skew warning for poorly formatted Parquet files

2017-01-27 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3989: Display skew warning for poorly formatted Parquet files .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/5400/10/tests/query_test/t

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#4). Change subject: [DOCS] Add doc for MT_DOP query option. .. [DOCS] Add doc for MT_DOP query option. Add info about MT_DOP default to COMPUTE STATS. Change-Id: Ife2786532b425af6d230

[Impala-ASF-CR] New feature bullet for IMPALA-4172

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5810 Change subject: New feature bullet for IMPALA-4172 .. New feature bullet for IMPALA-4172 Change-Id: Ie4c536859b5568a0ec1229bada23374093e1

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 4: (6 comments) Addressed comments. http://gerrit.cloudera.org:8080/#/c/5652/1/docs/topics/impala_mt_dop.xm

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5809 To unsubscribe, visit http:

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: @John: Could we add this JIRA in too? https://issues.cloudera.org/browse/IMPALA-3558 I've tagged

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread David Knupp (Code Review)
Hello Internal Jenkins, Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5177 to look at the new patch set (#7). Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: The last patch was just a rebase + adding a link to the commit ms

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/5177/7

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5809/1/docs/topics/impala_known_issues.xml File doc

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add "Known Issues" item for IMPALA-4828. .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/25/ -- To view, visit http

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread John Russell (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5807 to look at the new patch set (#2). Change subject: Add "Known Issues" item for IMPALA-4828. .. Add "Known Issues"

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add "Known Issues" item for IMPALA-4828. .. Patch Set 2: (1 comment) Fixed MJ's comment. http://gerrit.cloudera.org:8080/#/c/5807/1/docs/topics/impala_known_iss

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add "Known Issues" item for IMPALA-4828. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/26/ -- To view, visit http

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Add "Known Issues" item for IMPALA-4828. .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5807 To unsubscribe, visit http://

[Impala-ASF-CR] Add "Known Issues" item for IMPALA-4828.

2017-01-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Add "Known Issues" item for IMPALA-4828. .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5807 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#4). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. ..

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/5743/3/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of BufferedTupleStream that a

[Impala-ASF-CR] IMPALA-3524: Don't process spilled partitions with 0 probe rows

2017-01-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3524: Don't process spilled partitions with 0 probe rows .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/5389/6/be/src/exec/part

[Impala-ASF-CR] IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool .. IMPALA-4674: Part 1: port BufferedTupleStream to BufferPool Add a copy of BufferedTupleStream that a

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. IMPALA-4820: avoid writing unencrypted data during write cancellation The bug was that un

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5788/1//COMMIT_MSG Commi

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#5). Change subject: Updates to DML statements for Impala + Kudu .. Updates to DML statements for Impala + Kudu Fill in syntax, usage notes, examples for UPDATE, DELETE, UPSERT. Take ou

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 5: (11 comments) Addressed all MJ's comments. http://gerrit.cloudera.org:8080/#/c/5646/4/docs/topics/im

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 5: Code-Review+2 (2 comments) Please just address my comment about arbitrary, otherwise looks good- th

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/27/ -- To view, visit h

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5646 To unsubscribe, visit http

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Updates to DML statements for Impala + Kudu .. Updates to DML statements for Impala + Kudu Fill in syntax, usage notes, examples for UPDATE, DEL

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 4: (6 comments) I made comments for changes based on discussion with Mostafa. http://gerrit.cloudera.org:80

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#5). Change subject: [DOCS] Add doc for MT_DOP query option. .. [DOCS] Add doc for MT_DOP query option. Add info about MT_DOP default to COMPUTE STATS. Change-Id: Ife2786532b425af6d230

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 5: (6 comments) Addressed all comments. http://gerrit.cloudera.org:8080/#/c/5652/4/docs/topics/impala_mt_do

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: I'm not disputing you from a generic, syntactical standpoint -- b

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5729 To unsubscribe,

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 7: Code-Review+1 (9 comments) http://gerrit.cloudera.org:8080/#/c/5611/6/be/src/exec/hdf

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: I'm 100% willing to admit that I could be wrong in my understandi

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: Thank you for looking into this. It would be nice to fi

[Impala-ASF-CR] [DOCS] Add several items to "known issues" page

2017-01-27 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: [DOCS] Add several items to "known issues" page .. Patch Set 1: Code-Review+1 ..for IMPALA-4513 -- To view, visit http://gerrit.cloudera.org:8080/5809 To unsub

[Impala-ASF-CR] IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store sales

2017-01-27 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4482: Use ALTER TABLE / RECOVER PARTITIONS when loading tpcds.store_sales .. Patch Set 7: This is the code in question from generate-schema-statements.py.

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-01-27 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#4). Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC This patch a

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-01-27 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 3: (28 comments) Although it might look like a lot has changed in this n

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] [DOCS] Construct "fixed issues" topic for 2.8 release notes

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5814 Change subject: [DOCS] Construct "fixed issues" topic for 2.8 release notes .. [DOCS] Construct "fixed issues" topic for 2.8 release notes

[Impala-ASF-CR] IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-{4670,4672,4784}: Add RpcMgr and port Statestore services to KRPC .. Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/5720/3/be/src/rpc/rpc-mgr

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 7: (5 comments) Thanks for the review. I addressed the open points in PS8. http://gerrit.

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Lars Volker (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5611 to look at the new patch set (#8). Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. I

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-27 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#4). Change subject: IMPALA-4729: Implement REPLACE() .. IMPALA-4729: Implement REPLACE() This turned out to be slightly non-trivial as REPLACE is already a keyword, and thus the parser

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 4: This is good to go and fully tested now. I had to replumb a few things to get a StringVal.Resize() implementatio

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 5: (9 comments) Annotated with suggestions from Mostafa. http://gerrit.cloudera.org:8080/#/c/5668/5/docs/topics

[Impala-ASF-CR] IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new change for review. http://gerrit.cloudera.org:8080/5815 Change subject: IMPALA-2518: DROP DATABASE CASCADE doesn't remove cache directives of tables .. IMPALA-2518: DROP DATABASE CASCA

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5611 To unsubscribe,

[Impala-ASF-CR] IMPALA-3909: Populate min/max statistics in Parquet writer

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3909: Populate min/max statistics in Parquet writer .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5611/7/tests/query_test/test_insert_

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-27 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/5768/2/fe/src/mai

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5743/4/fe/src/main/ja

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-27 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 4: [localhost:21000] > select count(regexp_replace(l_comment, ' ', '')) from lineitem; Query: select count(regexp_re

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5652 To unsubscribe, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/5816 Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union n

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: L

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-27 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. IMPALA-3586 (Part 1): Implement Union Pass Through The union node acts as pass through operator and forwa

[Impala-ASF-CR] Updates to DML statements for Impala + Kudu

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Updates to DML statements for Impala + Kudu .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/5646/4/docs/topics/impala_upsert.xml File docs/topic

[Impala-ASF-CR] IMPALA-4820: avoid writing unencrypted data during write cancellation

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4820: avoid writing unencrypted data during write cancellation .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5788 To unsub

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/28/ -- To view, visit http:

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 2: Code-Review+2 Carrying over Jim's +2 based on minor change to address his comment. -- To view, visit ht

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/29/ -- To view, visit http

[Impala-ASF-CR] clang-tidy should tidy tests; fix alignas error in clang builds.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: clang-tidy should tidy tests; fix alignas error in clang builds. .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/30/

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/31/ -- To view,

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: [DOCS] Add doc for MT_DOP query option. .. [DOCS] Add doc for MT_DOP query option. Add info about MT_DOP default to COMPUTE STATS. Change-Id: I

[Impala-ASF-CR] [DOCS] Add doc for MT DOP query option.

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: [DOCS] Add doc for MT_DOP query option. .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5652 To unsubscribe, visit http://g

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5743/4/fe/src/main/java/org/apach

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5743 to look at the new patch set (#5). Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. ..

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. IMPALA-4390: Separate ADD and DROP PARTITION syntax Keep the location and cache options w

[Impala-ASF-CR] IMPALA-4390: Separate ADD and DROP PARTITION syntax

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4390: Separate ADD and DROP PARTITION syntax .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5729 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-4778 IMPALA-1972: Add known issue

2017-01-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4778 IMPALA-1972: Add known issue .. IMPALA-4778 IMPALA-1972: Add known issue Change-Id: I46ee3489cb161d9f8dd2852f2c293f93edf0e6aa Review

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5743

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: Dan, Bharath, any more comments? -- To view, visit http://gerrit.cloudera.org:80

[Impala-ASF-CR] IMPALA-4729: Implement REPLACE()

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4729: Implement REPLACE() .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5776/4/fe/src/main/cup/sql-parser.cup File fe/src/main/cup/sql-pars

[Impala-ASF-CR] [DOCS] Construct "fixed issues" topic for 2.8 release notes

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: [DOCS] Construct "fixed issues" topic for 2.8 release notes .. [DOCS] Construct "fixed issues" topic for 2.8 release notes Primarily a link to the relevant JIRA rep

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: No -- To view, visit http://gerrit.cloudera.org:8080/5743 To unsubscribe, visit

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-27 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Release note updates for Impala 2.8 .. Patch Set 5: (9 comments) Finished Mostafa comments. Patch set might be delayed because of a merge conflict. (Accidentall

[Impala-ASF-CR] New feature bullet for IMPALA-4172

2017-01-27 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: New feature bullet for IMPALA-4172 .. Abandoned We backed out this fix. -- To view, visit http://gerrit.cloudera.org:8080/5810 To unsubscribe, visit http://gerrit.cloude

[Impala-ASF-CR] Release note updates for Impala 2.8

2017-01-27 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#6). Change subject: Release note updates for Impala 2.8 .. Release note updates for Impala 2.8 First cut at 'new features' topic. Includes the Incompatible Changes subtopic for Impala

[Impala-ASF-CR] IMPALA-4792: Fix number of distinct values for a CASE with constant outputs

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4792: Fix number of distinct values for a CASE with constant outputs .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5768/2/fe/src/main/jav

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 5: No comments. LGTM. -- To view, visit http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-4789: Fix slow metadata loading due to inconsistent paths.

2017-01-27 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4789: Fix slow metadata loading due to inconsistent paths. .. Patch Set 6: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/5743 To u

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4617: remove IsConstant() analysis from be .. Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/5415/5/fe/src/main/java/org/apache/impala/ana

[Impala-ASF-CR] IMPALA-4617: remove IsConstant() analysis from be

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#9). Change subject: IMPALA-4617: remove IsConstant() analysis from be .. IMPALA-4617: remove IsConstant() analysis from be This change avoids the need to duplicate the logic in Expr.g

[Impala-ASF-CR] IMPALA-3586 (Part 1): Implement Union Pass Through

2017-01-27 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3586 (Part 1): Implement Union Pass Through .. Patch Set 2: (6 comments) Need to look at fe and tests, but had some comments on the backend. http://gerr

  1   2   >