[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. Patch Set 2: (2 comments) FE code lgtm. Let's please also add a PlannerTest for this

[Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

2017-04-25 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries .. IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries When dictionaries

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. Patch Set 2: (1 comment)

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 5: Code-Review+2 Rebase. Carry +2. -- To view, visit http://gerrit.cloudera.org:8080/6657 To unsubscribe,

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 8: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6628

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. IMPALA-5147: Add the ability to exclude hosts from query execution This

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new patch set (#2). Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation Since commit

[Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file .. Patch Set 7: Verified+1 -- To view, visit

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6657/4/be/src/runtime/tuple.cc File

[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints

2017-04-25 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#6). Change subject: IMPALA-2522: Add doc for sortby() and clustered hints .. IMPALA-2522: Add doc for sortby() and clustered hints Also IMPALA-4163: Add SORTBY() to list of hints in

[Impala-ASF-CR] IMPALA-5192: Don't bake MemPool* into IR

2017-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5192: Don't bake MemPool* into IR .. Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6657/4/be/src/runtime/tuple.cc File

[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints

2017-04-25 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-2522: Add doc for sortby() and clustered hints .. Patch Set 4: (10 comments) http://gerrit.cloudera.org:8080/#/c/5655/4/docs/shared/impala_common.xml

[Impala-ASF-CR] IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet

2017-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-2716: Hive/Impala incompatibility for timestamp data in Parquet .. Patch Set 7: (1 comment)

[Impala-ASF-CR] IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals()

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5188: Add slot sorting in TupleDescriptor::LayoutEquals() .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 8: Build started:

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. Patch Set 1: How about adding some explicit verifications of the types using that test

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 8: Code-Review+2 -- To view, visit

[Impala-ASF-CR] IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries

2017-04-25 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/6726 Change subject: IMPALA-4864 [DRAFT] Speed up single slot predicates with dictionaries .. IMPALA-4864 [DRAFT] Speed up single slot

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 7: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-2522: Add doc for sortby() and clustered hints

2017-04-25 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#5). Change subject: IMPALA-2522: Add doc for sortby() and clustered hints .. IMPALA-2522: Add doc for sortby() and clustered hints Also IMPALA-4163: Add SORTBY() to list of hints in

[Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-4893: Efficiently update the rows read counter for sequence file

2017-04-25 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-4893: Efficiently update the rows read counter for sequence file .. Patch Set 7: Code-Review+2 Carrying Tim's +2 for Anuj -- To view, visit

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-25 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). .. Patch Set 5: (2 comments) Patch set 5 specifically for Jim's last 2 'PS4' comments. The line 335 and

[Impala-ASF-CR] IMPALA-3973: optional 3rd and 4th arguments for instr().

2017-04-25 Thread John Russell (Code Review)
Hello Zoltan Ivanfi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5589 to look at the new patch set (#5). Change subject: IMPALA-3973: optional 3rd and 4th arguments for instr(). ..

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-3079: Fix sequence file writer .. IMPALA-3079: Fix sequence file writer This change fixes the following issues in the Sequence File

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. IMPALA-3742: Partitions and sort INSERTs for Kudu tables Bulk DMLs (INSERT, UPSERT, UPDATE,

[Impala-ASF-CR] IMPALA-3742: Partitions and sort INSERTs for Kudu tables

2017-04-25 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3742: Partitions and sort INSERTs for Kudu tables .. Patch Set 5: (24 comments)

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. Patch Set 1: (1 comment)

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-25 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. Patch Set 2: (1 comment) OK, I enabled the link to the latest Kudu Security topic.

[Impala-ASF-CR] [DOCS] Mention Kerberos and TLS for Kudu security

2017-04-25 Thread John Russell (Code Review)
Hello Ambreen Kazi, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6634 to look at the new patch set (#2). Change subject: [DOCS] Mention Kerberos and TLS for Kudu security .. [DOCS]

[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings

2017-04-25 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings

2017-04-25 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings .. IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings Add a note that idle_session_timeout and

[Impala-ASF-CR] IMPALA-5108: [DOCS] Explain 50% margin for idle * settings

2017-04-25 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5108: [DOCS] Explain 50% margin for idle_* settings .. Patch Set 1: (3 comments)

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 7: Build started:

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution .. Patch Set 7: Code-Review+2 Rebase and minor test fix. Keep Dan's +2 -- To view,

[Impala-ASF-CR] IMPALA-5147: Add the ability to exclude hosts from query execution

2017-04-25 Thread Dimitris Tsirogiannis (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6628 to look at the new patch set (#7). Change subject: IMPALA-5147: Add the ability to exclude hosts from query execution

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/502/ -- To view, visit

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-04-25 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6107 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. Patch Set 1: This is a minimal fix for the problem. Alex has some ideas on cleaning

[Impala-ASF-CR] IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/6724 Change subject: IMPALA-5251: Fix propagation of input exprs' types in 2-phase aggregation .. IMPALA-5251: Fix propagation of input exprs'

[Impala-ASF-CR] IMPALA-3079: Fix sequence file writer

2017-04-25 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3079: Fix sequence file writer .. Patch Set 9: Code-Review+1 > Carry +2 forward. Core tests succeeded:

[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6723

[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build .. IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build

[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build

2017-04-25 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build .. Patch Set 1: Build started:

[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build

2017-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build .. Patch Set 1: Code-Review+2 > Were you able to validate the fix somehow ? Thanks. Yes,

[Impala-ASF-CR] IMPALA-5244 test hdfs file open fail fails on local filesystem build

2017-04-25 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5244 test_hdfs_file_open_fail fails on local filesystem build .. Patch Set 1: Code-Review+2 Were you able to validate the fix somehow ? -- To view, visit

[Impala-ASF-CR] IMPALA-5253: Use appropriate transport for StatestoreSubscriber

2017-04-25 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5253: Use appropriate transport for StatestoreSubscriber .. Patch Set 4: Code-Review+2 Looks like a flaky failure. Trying agin. -- To view, visit