[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7063 To unsubs

[Impala-ASF-CR] IMPALA-5388: Only retry RPC on lost connection in send call

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5388: Only retry RPC on lost connection in send call .. IMPALA-5388: Only retry RPC on lost connection in send call Previously, DoRpc() b

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread yu feng (Code Review)
yu feng has uploaded a new patch set (#3). Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. try to rewr

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-08 Thread Michael Brown (Code Review)
Michael Brown has uploaded a new change for review. http://gerrit.cloudera.org:8080/7115 Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. IMPALA-3040 addendum: use specific_build_type_t

[Impala-ASF-CR] IMPALA-5435: Increase runtime filter test timeouts (again)

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5435: Increase runtime filter test timeouts (again) .. Patch Set 1: Passed an ASAN build. -- To view, visit http://gerrit.cloudera.org:8080/7097 To uns

[Impala-ASF-CR] IMPALA-5435: Increase runtime filter test timeouts (again)

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5435: Increase runtime filter test timeouts (again) .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/703/ --

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/7116 Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. IMPALA-5221: Fix TSaslTransport negotiation order The TSaslTranspor

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. Patch Set 1: There's a lot more cleanup that can be done around the TSasl* layer, however, I think that can

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Anyone want to give a +2 here? I don't think it needs deep expertise, so any committer

[Impala-ASF-CR] IMPALA-5413: Skip test seq writer hive compatibility on remote clusters.

2017-06-08 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-5413: Skip test_seq_writer_hive_compatibility on remote clusters. .. Patch Set 1: It might be a bug in Hive or beeline? Beeline is throwing a WRITE access

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-08 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Code-Review+2 Actually, the patch looks pretty simple, I can +2 it myself. -- T

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/7064/8/be/src/servic

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#9). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/704/ --

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 8: Code-Review+2 Rebase and keep Dan's +2 -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 9: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7064

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 9: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/

[Impala-ASF-CR] IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS .. Patch Set 4: Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/129/ -- To view, visit ht

[Impala-ASF-CR] IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7044 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS .. IMPALA-5259: [DOCS] Doc REFRESH FUNCTIONS The text from impala_common.xml is reused verbatim under

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 3: Code-Review+2 (1 comment) Looks good - please fix the long line, then I'll commit. Thanks! h

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-08 Thread Joe McDonnell (Code Review)
Hello Michael Ho, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7020 to look at the new patch set (#5). Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. IMPALA

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-08 Thread Joe McDonnell (Code Review)
Joe McDonnell has posted comments on this change. Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. Patch Set 5: Code-Review+1 Ran test_hdfs_file_mods.py on S3 successfully. Rebased to the latest. Carr

[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values

2017-06-08 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/7098/2//COMMIT_MSG Commit Message: PS2, Line

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-08 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/71

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-08 Thread Michael Brown (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7115 to look at the new patch set (#2). Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-08 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 2: (1 comment) Thanks for the review, Thomas. See PS2. http://gerrit.cloude

[Impala-ASF-CR] IMPALA-3603 [DOCS] Document handling of NaN values

2017-06-08 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new patch set (#3). Change subject: IMPALA-3603 [DOCS] Document handling of NaN values .. IMPALA-3603 [DOCS] Document handling of NaN values Added information in the "DOUBLE Data Type" (impala_double.h

[Impala-ASF-CR] IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout

2017-06-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7118 Change subject: IMPALA-4868: Increase TestRequestPoolService.testUpdatingConfigs timeout .. IMPALA-4868: Increase TestRequestPoolServic

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-06-08 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/6726/16/be/src/exec/parquet-column-

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 3: (4 comments) Last round of minor comments. This patch looks good. Nice

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc File be/src

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Steve Carlin (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7054 to look at the new patch set (#4). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-48

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#4). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid session ID message. C

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7054/4/be/src/service/impala-hs2-server.cc Fi

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7020 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc File be/src

[Impala-ASF-CR] IMPALA-5435: Increase runtime filter test timeouts (again)

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5435: Increase runtime filter test timeouts (again) .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7097 To unsubscr

[Impala-ASF-CR] IMPALA-5435: Increase runtime filter test timeouts (again)

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5435: Increase runtime filter test timeouts (again) .. IMPALA-5435: Increase runtime filter test timeouts (again) Codegen time under ASAN

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/706/ --

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 9: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-veri

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7106 To unsubscrib

[Impala-ASF-CR] IMPALA-5454: Work around template rendering bug in /memz

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5454: Work around template rendering bug in /memz .. IMPALA-5454: Work around template rendering bug in /memz A template parser issue mea

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7121 Change subject: IMPALA-5469: Fix exception when processing catalog update .. IMPALA-5469: Fix exception when processing catalog updat

[Impala-ASF-CR] IMPALA-4864 Speed up single slot predicates with dictionaries

2017-06-08 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#17). Change subject: IMPALA-4864 Speed up single slot predicates with dictionaries .. IMPALA-4864 Speed up single slot predicates with dictionaries When dictionaries are present we can

[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-08 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7094/2/docs/topics/impala_appx_median.xml F

[Impala-ASF-CR] IMPALA-4107 [DOCS] APPX MEDIAN cuts string to 10 chars

2017-06-08 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new patch set (#4). Change subject: IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars .. IMPALA-4107 [DOCS] APPX_MEDIAN cuts string to 10 chars In the "Restrictions" section of the "APPX_MEDIAN Fu

[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page

2017-06-08 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/7124 Change subject: IMPALA-5470: Modernize links and instructions on download page .. IMPALA-5470: Modernize links and instructions on download p

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. Patch Set 1: (11 comments) Looks pretty good. Have you confirmed this works with LDAP as well as GSSAPI?

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#10). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 10: Code-Review+2 Fixed minor test issue, keep Dan's +2 -- To view, vis

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 10: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Steve Carlin (Code Review)
Hello Henry Robinson, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7054 to look at the new patch set (#5). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-48

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Steve Carlin (Code Review)
Steve Carlin has uploaded a new patch set (#5). Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid session ID message. C

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 5: Code-Review+2 Great, thanks for your patience! -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/708/ -- To view

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-08 Thread Marcel Kornacker (Code Review)
Marcel Kornacker has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 19: Code-Review+2 (9 comments) http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-ev

[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"

2017-06-08 Thread Laurel Hale (Code Review)
Laurel Hale has uploaded a new patch set (#2). Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" Corrected code example li

[Impala-ASF-CR] IMPALA-4850 [DOCS] Create table "comment comes after "partioned by"

2017-06-08 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: IMPALA-4850 [DOCS] Create table "comment comes after "partioned by" .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7080/1/docs/topics/impala_cre

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7121/1/fe/src/main/java/org/

[Impala-ASF-CR] IMPALA-5221: Fix TSaslTransport negotiation order

2017-06-08 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5221: Fix TSaslTransport negotiation order .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7116/1/be/src/transport/TSasl.h File be/src/trans

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7121 To unsubs

[Impala-ASF-CR](asf-site) IMPALA-5470: Modernize links and instructions on download page

2017-06-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5470: Modernize links and instructions on download page .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7124/1/downloads.html File downloa

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5715 To unsubscribe, v

Re: [Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-06-08 Thread Henry Robinson
Thanks! This got updated when I refreshed the data-stream-sender patch; unfortunately Gerrit makes that hard to avoid when there are rebases involved. There is an issue with this patch on SLES11 (the default openssl is too old) and RHEL5 (some compilation errors). I'll post a new patch fixing thos

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7121/1/fe/src/main/java/org/apache

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Taras Bobrovytsky (Code Review)
Hello Dimitris Tsirogiannis, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7121 to look at the new patch set (#2). Change subject: IMPALA-5469: Fix exception when processing catalog update ...

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new patch set (#2). Change subject: IMPALA-5469: Fix exception when processing catalog update .. IMPALA-5469: Fix exception when processing catalog update In IMPALA-5355 patch, a regression was i

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 2: Code-Review+2 Forwarding the +2 -- To view, visit http://gerrit.cloudera.org:8080

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/709/ --

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 2: (2 comments) I noticed that the clang-tidy job in the previous GVO run had fail

[Impala-ASF-CR] IMPALA-5221: Avoid re-use of stale SASL contexts.

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#2). Change subject: IMPALA-5221: Avoid re-use of stale SASL contexts. .. IMPALA-5221: Avoid re-use of stale SASL contexts. The TSaslTransport is written as a thrift extension that is

[Impala-ASF-CR] IMPALA-5221: Avoid re-use of stale SASL contexts.

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5221: Avoid re-use of stale SASL contexts. .. Patch Set 2: (14 comments) http://gerrit.cloudera.org:8080/#/c/7116/1//COMMIT_MSG Commit Message: PS1, Lin

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: (6 comments) I had a few high-level comments: * A lot of this depends on order being preserved a

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 5: I'm reluctant to hold up the fix because it's important, but I think if this goes in as-is it co

[Impala-ASF-CR] IMPALA-5315 Cast to timestamp fails for YYYY-M-D format

2017-06-08 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5315 Cast to timestamp fails for -M-D format .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/3/be/src/exprs/expr-test.cc File be/

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case This fixes three issues wit

[Impala-ASF-CR] IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5386: Fix ReopenCachedHdfsFileHandle failure case .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7020 To unsubscrib

[Impala-ASF-CR] IMPALA-5316: Adds last day() function

2017-06-08 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5316: Adds last_day() function .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6991 To unsubscribe, visit http://gerrit.

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 10: (2 comments) Thanks for pointing these out. http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Hello Impala Public Jenkins, Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7064 to look at the new patch set (#11). Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ..

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun

[Impala-ASF-CR] IMPALA-4965: Authorize access to runtime profile and exec summary

2017-06-08 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary .. Patch Set 11: Code-Review+2 Fix minor issue that caused clang-tidy to complain. Kee

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4892: Session ID included in error message .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7054 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-4892: Session ID included in error message

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4892: Session ID included in error message .. IMPALA-4892: Session ID included in error message Included the Session ID in the invalid se

[Impala-ASF-CR] IMPALA-5221: Avoid re-use of stale SASL contexts.

2017-06-08 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5221: Avoid re-use of stale SASL contexts. .. Patch Set 2: > (11 comments) > > Looks pretty good. Have you confirmed this works with LDAP as well > as

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5469: Fix exception when processing catalog update .. IMPALA-5469: Fix exception when processing catalog update In IMPALA-5355 patch, a r

[Impala-ASF-CR] IMPALA-5469: Fix exception when processing catalog update

2017-06-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5469: Fix exception when processing catalog update .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7121 To unsubscri

[Impala-ASF-CR] IMPALA-5280: Coalesce chains of OR conditions to an IN predicate

2017-06-08 Thread Anonymous Coward (Code Review)
sakinape...@cloudera.com has uploaded a new patch set (#2). Change subject: IMPALA-5280: Coalesce chains of OR conditions to an IN predicate .. IMPALA-5280: Coalesce chains of OR conditions to an IN predicate This change introdu

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread yu feng (Code Review)
yu feng has uploaded a new patch set (#4). Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. try to rewr

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-08 Thread Michael Ho (Code Review)
Hello Marcel Kornacker, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5483 to look at the new patch set (#20). Change subject: IMPALA-4192: Disentangle Expr and ExprContext ...

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 20: Code-Review+2 Carry +2 forward. -- To view, visit http://gerrit.cloudera.org:8080/5483 To unsubscri

[Impala-ASF-CR] IMPALA-4192: Disentangle Expr and ExprContext

2017-06-08 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4192: Disentangle Expr and ExprContext .. Patch Set 19: (8 comments) http://gerrit.cloudera.org:8080/#/c/5483/19/be/src/exec/analytic-eval-node.h File be/sr

[Impala-ASF-CR] IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule.

2017-06-08 Thread yu feng (Code Review)
yu feng has posted comments on this change. Change subject: IMPALA-5016: Try to rewrite coalesce() function in SimplifyConditionalsRule. .. Patch Set 4: (35 comments) responded to comments by alex. http://gerrit.cloudera.org