[Impala-ASF-CR] IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has uploaded a new change for review. http://gerrit.cloudera.org:8080/7229 Change subject: IMPALA-5537: Retry RpcRecv on recv timeout exception for SSL connection .. IMPALA-5537: Retry RpcRecv on recv timeout excep

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 2: (10 comments) Thanks for the patch. I have a lot of minor comments for clea

[Impala-ASF-CR] IMPALA-1474: Add a metric for running queries

2017-06-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1474: Add a metric for running queries .. Patch Set 1: (4 comments) Just a few nits in addition to Bharath's comments. http://gerrit.cloudera.org:8080/

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-5530: fix compilation against Sentry .. IMPALA-5530: fix compilation against Sentry * SentryUserException moved packages as a result of the SENTR

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 5: Code-Review+2 Verified+1 The build passed except for starting sentry. This is an improvement so will

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/757/ -- To

[Impala-ASF-CR] IMPALA-1474: Add a metric for running queries

2017-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-1474: Add a metric for running queries .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7228/1//COMMIT_MSG Commit Message: PS1, L

[Impala-ASF-CR] IMPALA-1474: Add a metric for running queries

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7228 Change subject: IMPALA-1474: Add a metric for running queries .. IMPALA-1474: Add a metric for running queries impala-server.num-querie

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 3: Still need to update the commit message, I'll do once the patch is appr

[Impala-ASF-CR] PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#20). Change subject: PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool .. PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4703: reservation denial debug action .. IMPALA-4703: reservation denial debug action Add debug action to deny reservation increases with some probability.

[Impala-ASF-CR] PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#19). Change subject: PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool .. PREVIEW: IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. IMPALA-4674: Part 1: remove old aggs and joins This is intended to be merged at the same time as Part 2 but is se

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour This moves away from

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-19 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7095 to look at the new patch set (#3). Change subject: IMPALA-5431: Remove redundant path exists check during table load .

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/r

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-19 Thread Henry Robinson (Code Review)
Hello Sailesh Mukil, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7226 to look at the new patch set (#2). Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization ..

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7095/2/fe/src/main/ja

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 5: I'm going to rerun the build and check that it all compiles ok. Then I'll verify and merge it. I exp

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/757/ -- To view, visi

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7222 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7222 to look at the new patch set (#5). Change subject: IMPALA-5530: fix compilation against Sentry .. IMPALA-5

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/756/ -- To

[Impala-ASF-CR] IMPALA-4856: Port data stream service to KRPC

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4856: Port data stream service to KRPC .. Patch Set 3: (6 comments) Some more comments. Still going through the patch. http://gerrit.cloudera.org:8080/#/c/

[Impala-ASF-CR] IMPALA-4674: Part 1: remove old aggs and joins

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4674: Part 1: remove old aggs and joins .. IMPALA-4674: Part 1: remove old aggs and joins This is intended to be merged at the same time as Part 2 but is se

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7095/2/fe/src/main/java/org/apac

[Impala-ASF-CR] IMPALA-4874: Increase the maximum KRPC message size to 4GB

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB .. Patch Set 1: Does the 4GB payload limit include sidecar already or is it set separately ? -- To view

[Impala-ASF-CR] IMPALA-4874: Increase the maximum KRPC message size to 4GB

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-4874: Increase the maximum KRPC message size to 4GB .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5887/1/be/src/kudu/rpc/serialization.cc

[Impala-ASF-CR] IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3643/IMPALA-5344: Fix FE tests on Java 8 .. Patch Set 6: (12 comments) Looks good. Just have minor comments then I'm ready to +1. I think Alex or Dimitr

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-19 Thread Bharath Vissapragada (Code Review)
Hello Dimitris Tsirogiannis, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7095 to look at the new patch set (#2). Change subject: IMPALA-5431: Remove redundant path exists check during table load .

[Impala-ASF-CR] IMPALA-5431: Remove redundant path exists check during table load

2017-06-19 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5431: Remove redundant path exists check during table load .. Patch Set 1: (1 comment) Alex, I did a quick audit of the exists() checks in HdfsTa

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7226/1/be/src/runtime/row-b

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7226 To u

[Impala-ASF-CR] IMPALA-5031: Remove undefined behavior "reference binding to null"

2017-06-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5031: Remove undefined behavior "reference binding to null" .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7008 To unsubscr

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-06-19 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/5/be/src/runtime/timestamp-parse-util.

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7226/1/be/s

[Impala-ASF-CR] IMPALA-5517: Allow default IMPALA LOGS DIR to be explicity overridden

2017-06-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5517: Allow default IMPALA_LOGS_DIR to be explicity overridden .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7197/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5530: fix compilation against Sentry .. IMPALA-5530: fix compilation against Sentry * SentryUserException moved packages. * SentryPolicyServiceClient.close(

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/756/ -- To view, visi

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7222/2/fe/src/main/java/org/apache/impala/util/Sentr

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#5). Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. IMPALA-5497: spilling hash joins that output build rows hit OOM The bug is that the join tried t

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7180/4/be/src/exec/partitioned-h

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5530: fix compilation against Sentry .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7222/2/fe/src/main/java/org/apache/impala/u

[Impala-ASF-CR] IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7226 Change subject: IMPALA-5532: Stack-allocate compressors in RowBatch (de)serialization .. IMPALA-5532: Stack-allocate compressors in Row

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/6955/8/common/thrift/JniCatalog.thrift File c

[Impala-ASF-CR] IMPALA-4622: Add ALTER COLUMN statement.

2017-06-19 Thread Thomas Tauber-Marshall (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6955 to look at the new patch set (#9). Change subject: IMPALA-4622: Add ALTER COLUMN statement. .. IMPALA-4622: Add ALTER

[Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7206 To unsubscribe, visit http://gerr

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7180/4/be/src/exec/partitioned-hash

[native-toolchain-CR] Bump Kudu vesion to c0798a9

2017-06-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7225 Change subject: Bump Kudu vesion to c0798a9 .. Bump Kudu vesion to c0798a9 Change-Id: I525a30cb6bd4cfaab2fdc49f3dbfa65793c3f2c4 --- M b

[Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership

2017-06-19 Thread Henry Robinson (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7206 to look at the new patch set (#7). Change subject: IMPALA-5481: Clarify RowDescriptor ownership .. IMPALA-5481: Cl

[Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership .. Patch Set 7: Code-Review+1 Rebase, carry +1. -- To view, visit http://gerrit.cloudera.org:8080/7206 To unsubsc

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 3: > Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/755

[Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership .. Patch Set 6: Thanks - I'm in the middle of that :) -- To view, visit http://gerrit.cloudera.org:8080/7206 To u

[native-toolchain-CR] More GCC 7 fixes

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: More GCC 7 fixes .. More GCC 7 fixes My previous patch didn't fix all the build issues - I was building in a pre-existing workspace with some packages already buil

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour This moves away from

[Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership

2017-06-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership .. Patch Set 6: May want to rebase again as ExprContext::Prepare() is now gone. -- To view, visit http://gerrit.cloud

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. IMPALA-5526: Add krb5 1.15.1 to toolchain Change-Id: I5237f8cba41f91e70f0a915f841db51b5cb93655 --- M build

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7224 To unsubscribe, visit http://gerrit

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7224 To unsubscribe, visit http://ger

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Hello Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7224 to look at the new patch set (#2). Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. IMPALA-5526: Add

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. Patch Set 2: Carry +2. This already passed a full toolchain build. -- To view, visit http://gerrit.cloudera.org:8

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7224/1/source/krb5/build.sh File source

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7224/1/source/krb5/build.sh File source/krb5/build.sh

[native-toolchain-CR] IMPALA-5526: Add krb5 1.15.1 to toolchain

2017-06-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7224 Change subject: IMPALA-5526: Add krb5 1.15.1 to toolchain .. IMPALA-5526: Add krb5 1.15.1 to toolchain Change-Id: I5237f8cba41f91e70f0a

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 3: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-

[Impala-ASF-CR] IMPALA-5315: Cast to timestamp fails for YYYY-M-D format

2017-06-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5315: Cast to timestamp fails for -M-D format .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7009/5/be/src/runtime/timestamp-parse-uti

[Impala-ASF-CR] IMPALA-4862: make resource estimates match backend behaviour

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has abandoned this change. Change subject: IMPALA-4862: make resource estimates match backend behaviour .. Abandoned Not quite ready -- To view, visit http://gerrit.cloudera.org:8080/7127 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4862: make resource estimates match backend behaviour

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-4862: make resource estimates match backend behaviour .. IMPALA-4862: make resource estimates match backend behaviour This moves away from the PipelinedPlan

[Impala-ASF-CR] IMPALA-5530: fix compilation against Sentry

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7222 Change subject: IMPALA-5530: fix compilation against Sentry .. IMPALA-5530: fix compilation against Sentry * SentryUserException moved p

[Impala-ASF-CR] IMPALA-5481: Clarify RowDescriptor ownership

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5481: Clarify RowDescriptor ownership .. Patch Set 6: Code-Review+1 I don't feel strongly personally about the ref vs pointer thing. The const refs seeme

[Impala-ASF-CR] IMPALA-5497: spilling hash joins that output build rows hit OOM

2017-06-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5497: spilling hash joins that output build rows hit OOM .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7180/4/testdata/workloads/functi

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 3: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-3040 addendum: use specific build type timeout for slow builds

2017-06-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-3040 addendum: use specific_build_type_timeout for slow builds .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7115 To u