[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 26: (18 comments) Addressed most of the comments but had a couple of questions about query and

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#28). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR] IMPALA-5585: Fix expr-test to call last day() tests

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5585: Fix expr-test to call last_day() tests .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7403 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5585: Fix expr-test to call last day() tests

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5585: Fix expr-test to call last_day() tests .. IMPALA-5585: Fix expr-test to call last_day() tests The tests for last_day() were not bei

[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7401 To unsubsc

[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit .. IMPALA-5104: Admit queries with mem equal to proc mem_limit This allows queries t

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/723

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 This

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. IMPALA-5240: Allow config of number of disk I/O threads per disk type

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7219 T

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-11 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7404 Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. IMPALA-5650: Make sum_init_zero a SUM function The recent Parquet

[Impala-ASF-CR] IMPALA-5650: Make sum init zero a SUM function

2017-07-11 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5650: Make sum_init_zero a SUM function .. Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/7404/1//COMMIT_MSG Commit Message: P

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. IMPALA-4862: make resource profile consistent with backend behaviour Th

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 27: (18 comments) http://gerrit.cloudera.org:8080/#/c/5801/27/be/src/exec/exec-node.h File be/src/

[Impala-ASF-CR] IMPALA-5585: Fix expr-test to call last day() tests

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5585: Fix expr-test to call last_day() tests .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7403 To unsubscribe, visit h

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 21: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7223

[Impala-ASF-CR] IMPALA-5585: Fix expr-test to call last day() tests

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5585: Fix expr-test to call last_day() tests .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/854/ -- To vi

[Impala-ASF-CR] IMPALA-5539: Kudu timestamp scans wrong with -use local tz for unix ts

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts .. Patch Set 2: @Dan, I still need to add some expr-tests for the exposed fn "unix_micr

[Impala-ASF-CR] IMPALA-5585: Fix expr-test to call last day() tests

2017-07-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5585: Fix expr-test to call last_day() tests .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7403 To unsubscribe

[Impala-ASF-CR] IMPALA-5539: Kudu timestamp scans wrong with -use local tz for unix ts

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#2). Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts .. IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts The -use_local_t

[Impala-ASF-CR] IMPALA-5585: Fix expr-test to call last day() tests

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7403 Change subject: IMPALA-5585: Fix expr-test to call last_day() tests .. IMPALA-5585: Fix expr-test to call last_day() tests The tests fo

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7294 To un

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 1: (4 comments) I didn't do a full pass, but I had some comments about the codegen and

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Bikramjeet Vig (Code Review)
Hello Matthew Jacobs, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7232 to look at the new patch set (#11). Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read Reading a u

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7267/4/fe/src/main/java/org/apache/impala/planner/Planne

[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/853/ -

[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7401 To unsubscribe

[Impala-ASF-CR] IMPALA-5640: re-enable gzip for parquet insert tests

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5640: re-enable gzip for parquet insert tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7398 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5640: re-enable gzip for parquet insert tests

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5640: re-enable gzip for parquet insert tests .. IMPALA-5640: re-enable gzip for parquet insert tests This addresses a gap in test covera

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. Patch Set 1: (15 comments) nice! http://gerrit.cloudera.org:8080/#/c/7400/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-5104: Admit queries with mem equal to proc mem limit

2017-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5104: Admit queries with mem equal to proc mem_limit .. IMPALA-5104: Admit queries with mem equal to proc mem_limit This allows queries to be admitted with

[Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule

2017-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5104: Fix Query Admission Rule .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7401/1//COMMIT_MSG Commit Message: PS1, Line 7: Fix Que

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5498: Support for partial sorts .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/7267/4/be/src/exec/partial-sort-node.cc File be

[Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5104: Fix Query Admission Rule .. Patch Set 1: (5 comments) Looks pretty good, just some nits. http://gerrit.cloudera.org:8080/#/c/7401/1//COMMIT_MSG C

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryru

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 11: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dr

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7232 To

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 5: Code-Review+2 Looks good, thanks Vincent! -- To view, visit http://gerrit.

[Impala-ASF-CR] IMPALA-5498: Support for partial sorts

2017-07-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has uploaded a new patch set (#5). Change subject: IMPALA-5498: Support for partial sorts .. IMPALA-5498: Support for partial sorts Impala currently supports total sorts (the entire set of data is sorted)

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/7232/10/be/src/runtime

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#3). Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Add Impala 2.9 docs from master branch, with commit hash f1a3d

[Impala-ASF-CR] IMPALA-5104: Fix Query Admission Rule

2017-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7401 Change subject: IMPALA-5104: Fix Query Admission Rule .. IMPALA-5104: Fix Query Admission Rule This allows queries to be admitted with

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new patch set (#2). Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Add Impala 2.9 docs from master branch, with commit hash f1a3d

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Vincent Tran (Code Review)
Vincent Tran has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. Patch Set 5: Done. -- To view, visit http://gerrit.cloudera.org:8080/7219 To unsubscribe

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNSAFE SPILLS=1

2017-07-11 Thread Vincent Tran (Code Review)
Vincent Tran has uploaded a new patch set (#4). Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 .. IMPALA-5524: Fixes NPE during planning with DISABLE_UNSAFE_SPILLS=1 This change will avoid a

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 1: Is this still active? -- To view, visit http://gerrit.cloudera.org:8080/5987 To unsubscribe

[Impala-ASF-CR] IMPALA-5524: Fixes NPE during planning with DISABLE UNFASE SPILLS=1

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5524: Fixes NPE during planning with DISABLE_UNFASE_SPILLS=1 .. Patch Set 3: Did you have a chance to have another look at this? Would be good to get the

[Impala-ASF-CR] IMPALA-5240: Allow config of number of disk I/O threads per disk type

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5240: Allow config of number of disk I/O threads per disk type .. Patch Set 10: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/7232/10/b

[Impala-ASF-CR] IMPALA-5520: TopN node periodically reclaims old allocations

2017-07-11 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7400 Change subject: IMPALA-5520: TopN node periodically reclaims old allocations .. IMPALA-5520: TopN node periodically reclaims old allocat

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread Laurel Hale (Code Review)
Laurel Hale has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 1: (1 comment) > (1 comment) http://gerrit.cloude

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/

[Impala-ASF-CR] IMPALA-5612: join inversion should factor in parallelism

2017-07-11 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7351 to look at the new patch set (#4). Change subject: IMPALA-5612: join inversion should factor in parallelism

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-11 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7394/1//COMMIT_MSG Commit Message: PS1, Line 16:

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 21: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-5612: join inversion should factor in parallelism

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5612: join inversion should factor in parallelism .. Patch Set 4: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7351 To unsub

[Impala-ASF-CR] IMPALA-5612: join inversion should factor in parallelism

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5612: join inversion should factor in parallelism .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7351/3//COMMIT_MSG Commit Message: Li

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 21: Code-Review+2 Hit IMPALA-5648. updated planner test and rebase. -- To vi

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7223 to look at the new patch set (#21). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour ..

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/84

[Impala-ASF-CR] IMPALA-5536: Fix TCLIService thrift compilation on Hive 2

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5536: Fix TCLIService thrift compilation on Hive 2 .. Patch Set 4: what version of Hive 2 will this target? I'm asking because https://issues.apache.org

[Impala-ASF-CR] IMPALA-5640: re-enable gzip for parquet insert tests

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5640: re-enable gzip for parquet insert tests .. IMPALA-5640: re-enable gzip for parquet insert tests This addresses a gap in test coverage. There are no kn

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. Patch Set 5: Code-Review+2 jenkins failed because: F0711 18:05:06.155953 23749 tablet_server_

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Patch Set 1: (2 comments) I verified the contents of docs/

[Impala-ASF-CR] IMPALA-5640: re-enable gzip for parquet insert tests

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5640: re-enable gzip for parquet insert tests .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/848/ -- To v

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 20: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-

[Impala-ASF-CR] IMPALA-5640: re-enable gzip for parquet insert tests

2017-07-11 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5640: re-enable gzip for parquet insert tests .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7398 To unsubscribe, visit

[Impala-ASF-CR] Bump Kudu version to 1070e76

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to 1070e76 .. Bump Kudu version to 1070e76 Change-Id: Ic2046b332d4e9a2b9d6a36d8c51ac928a9d2ab4d Reviewed-on: http://gerrit.clo

[Impala-ASF-CR] Bump Kudu version to 1070e76

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 1070e76 .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7395 To unsubscribe, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5640: re-enable disabled gzip test

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7398 Change subject: IMPALA-5640: re-enable disabled gzip test .. IMPALA-5640: re-enable disabled gzip test This addresses a gap in test cove

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/5801/23/be/src/runtime/runtime-state.h Fi

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#27). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at startup using 80%

[Impala-ASF-CR](asf-site) Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246

2017-07-11 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has uploaded a new change for review. http://gerrit.cloudera.org:8080/7397 Change subject: Add Impala 2.9 docs from master branch, with commit hash f1a3d8e14dae4948ce77e2f85e036d83f2d8b246 .. Add Impala 2.9 docs

[Impala-ASF-CR] IMPALA-5586: Null-aware anti-join can take a long time to cancel

2017-07-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7393/2//COMMIT_MSG Co

[Impala-ASF-CR] IMPALA-5539: Kudu timestamp scans wrong with -use local tz for unix ts

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5539: Kudu timestamp scans wrong with -use_local_tz_for_unix_ts .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7311/1//COMMIT_MSG Com

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. Patch Set 5: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/84

[Impala-ASF-CR] IMPALA-5031: Set DiskIoMgr::ScanRange::is cancelled before read

2017-07-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5031: Set DiskIoMgr::ScanRange::is_cancelled_ before read .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7294 To unsubscribe

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-11 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 23: (2 comments) http://gerrit.cloudera.org:8080/#/c/5801/23/be/src/runtime/runtime-state.h File b

[Impala-ASF-CR] IMPALA-5586: Null-aware anti-join can take a long time to cancel

2017-07-11 Thread anujphadke (Code Review)
anujphadke has uploaded a new patch set (#2). Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel .. IMPALA-5586: Null-aware anti-join can take a long time to cancel Queries with a null-aware anti-jo

[Impala-ASF-CR] Print Kudu native client version on Impala web UI

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has abandoned this change. Change subject: Print Kudu native client version on Impala web UI .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/7023 To unsubscribe, visit http://gerrit.cloudera.org:8

[Impala-ASF-CR] IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4863/IMPALA-5311: Correctly account the file type and compression codec .. Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/7245/3/be/src/e

[Impala-ASF-CR] Bump Kudu version to 1070e76

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to 1070e76 .. Patch Set 1: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/845/ -- To view, visit http://gerrit

[Impala-ASF-CR] Bump Kudu version to 1070e76

2017-07-11 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to 1070e76 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7395 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 20: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dry

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Tim Armstrong (Code Review)
Hello Impala Public Jenkins, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7223 to look at the new patch set (#20). Change subject: IMPALA-4862: make resource profile consistent with backend behaviour ..

[Impala-ASF-CR] IMPALA-4862: make resource profile consistent with backend behaviour

2017-07-11 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4862: make resource profile consistent with backend behaviour .. Patch Set 19: Fix fe test -- To view, visit http://gerrit.cloudera.org:8080/7223 To un

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: > Sure, I'll create a similar start-time metric for this 2 processes > as well. Some ques

[Impala-ASF-CR] Bump Kudu version to 1070e76

2017-07-11 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7395 Change subject: Bump Kudu version to 1070e76 .. Bump Kudu version to 1070e76 Change-Id: Ic2046b332d4e9a2b9d6a36d8c51ac928a9d2ab4d --- M

[Impala-ASF-CR] IMPALA-3381: Support AM/PM marker in date and time format strings

2017-07-11 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-3381: Support AM/PM marker in date and time format strings .. Patch Set 2: > What did we decide here? Can we move this forward or should we > abandon the

[Impala-ASF-CR] IMPALA-3381: Support AM/PM marker in date and time format strings

2017-07-11 Thread Attila Jeges (Code Review)
Attila Jeges has abandoned this change. Change subject: IMPALA-3381: Support AM/PM marker in date and time format strings .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/6523 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] IMPALA-5511: Add process start time to debug web page

2017-07-11 Thread Gabor Kaszab (Code Review)
Gabor Kaszab has posted comments on this change. Change subject: IMPALA-5511: Add process start time to debug web page .. Patch Set 3: Sure, I'll create a similar start-time metric for this 2 processes as well. Some question t

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-11 Thread Attila Jeges (Code Review)
Attila Jeges has uploaded a new change for review. http://gerrit.cloudera.org:8080/7394 Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. IMPALA-5407: Fix crash in HdfsSequenceTableWriter The following use

[Impala-ASF-CR] IMPALA-5513: Fix display message exception when using invalid KEYVAL

2017-07-11 Thread Donghui Xu (Code Review)
Donghui Xu has posted comments on this change. Change subject: IMPALA-5513: Fix display message exception when using invalid KEYVAL .. Patch Set 6: Please review this code. Thanks a lot. -- To view, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. IMPALA-5507: Add clear description to help information of KEYVAL opti

[Impala-ASF-CR] IMPALA-5507: Add clear description to help information of KEYVAL option

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5507: Add clear description to help information of KEYVAL option .. Patch Set 12: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7

[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth .. IMPALA-5514: Throw an error when --ldap_password_cmd is used w

[Impala-ASF-CR] IMPALA-5514: Throw an error when --ldap password cmd is used without LDAP auth

2017-07-11 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5514: Throw an error when --ldap_password_cmd is used without LDAP auth .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:

  1   2   >