[Impala-ASF-CR] IMPALA-5676: avoid expensive consistency checks in BTSv2

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5676: avoid expensive consistency checks in BTSv2 .. IMPALA-5676: avoid expensive consistency checks in BTSv2 Doing an O(n) consistency check every time

[Impala-ASF-CR] IMPALA-5676: avoid expensive consistency checks in BTSv2

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5676: avoid expensive consistency checks in BTSv2 .. Patch Set 1: (1 comment)

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/893/ -- To

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. Patch Set 2: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7466 To

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/892/ --

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 4: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7454 To

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. IMPALA-5686: Update a mini cluster Sentry property The property

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7469 To unsubscribe,

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 24: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/890/ -- To

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 3: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/888/

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/887/ --

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/891/ -- To view,

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. Patch Set 2: Code-Review+2 Forwarding the +2. Thanks for the review, Henry and Lars. -- To view,

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. Patch Set 1: (1 comment) Yes, I tested this change on my machine and it fixed the issue for me.

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. Patch Set 1: Code-Review+2 I cherry picked the change and it fixed the issue for me. -- To view, visit

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 24: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/890/ -- To

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5686: Update a mini cluster Sentry property .. Patch Set 1: Code-Review+2 (1 comment) Did this fix the issue for you?

[Impala-ASF-CR] IMPALA-5686: Update a mini cluster Sentry property

2017-07-19 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has uploaded a new change for review. http://gerrit.cloudera.org:8080/7469 Change subject: IMPALA-5686: Update a mini cluster Sentry property .. IMPALA-5686: Update a mini cluster Sentry property The

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/889/ --

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 3: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7454 To

[Impala-ASF-CR] (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7467 Change subject: (PREVIEW) IMPALA-5684: Optionally run be tests in sharded mode .. (PREVIEW) IMPALA-5684: Optionally run be tests in

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/888/ -- To

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread David Knupp (Code Review)
David Knupp has posted comments on this change. Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7466 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4868: Disable flaky TestRequestPoolService test

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/7466 Change subject: IMPALA-4868: Disable flaky TestRequestPoolService test .. IMPALA-4868: Disable flaky TestRequestPoolService test

[Impala-ASF-CR] IMPALA-5625: write profile when query times out

2017-07-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5625: write profile when query times out .. Patch Set 2: (8 comments) Thanks for this patch, I think this will be a great improvement.

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. IMPALA-5670: Misc. tidying of ExecEnv * Remove duplicated c'tor code for ExecEnv() and delegate it onto

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 6: Code-Review+2 Fix typo, carry +2. -- To view, visit http://gerrit.cloudera.org:8080/7445 To

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7445 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5586: Null-aware anti-join can take a long time to cancel

2017-07-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel .. Patch Set 5: (1 comment)

[Impala-ASF-CR] IMPALA-5586: Null-aware anti-join can take a long time to cancel

2017-07-19 Thread anujphadke (Code Review)
Hello Thomas Tauber-Marshall, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7393 to look at the new patch set (#5). Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts The

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7311 To

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 6: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 2: Code-Review+1 (1 comment) Looks good, this should be a big improvement. There's an

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 2: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 2: Code-Review+1 Looks good to me. Lets give Tim and/or Sailesh another chance to

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. IMPALA-5275: Avoid printing status stack trace on hot paths Currently, creation of a Status object

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/887/ -- To view,

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-19 Thread Thomas Tauber-Marshall (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6898 to look at the new patch set (#4). Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 8: (2 comments)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#8). Change subject: IMPALA-5582: Store sentry privileges in lower case

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7419

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-19 Thread Bikramjeet Vig (Code Review)
Hello Impala Public Jenkins, Henry Robinson, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7419 to look at the new patch set (#6). Change subject: IMPALA-4276: Profile displays non-default query options set by planner

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 7: (2 comments) Thanks! 2 small things and otherwise I'm good to go. Let's make sure Michael

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 7: (4 comments)

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread anujphadke (Code Review)
Hello Bharath Vissapragada, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7332 to look at the new patch set (#7). Change subject: IMPALA-5582: Store sentry privileges in lower case

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 3: > So the GVO failed because there's a custom cluster test that runs > impala with

[Impala-ASF-CR] IMPALA-5167: Reduce the number of Kudu clients created (FE)

2017-07-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5167: Reduce the number of Kudu clients created (FE) .. Patch Set 3: So the GVO failed because there's a custom cluster test that runs impala

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7454 To

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: There's no rush, we can leave it open, just wanted to clarify what the state of it was. -- To

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-19 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: > Did this get lost in the shuffle? I'm trying to pare down my review > inbox a bit :) It's

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/885/ -- To view, visit

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Henry Robinson (Code Review)
Hello Impala Public Jenkins, Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7445 to look at the new patch set (#6). Change subject: IMPALA-5670: Misc. tidying of ExecEnv

[Impala-ASF-CR] IMPALA-5582: Store sentry privileges in lower case

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case .. Patch Set 6: > (4 comments) > > None of these comments are must-dos, just things I've noticed. Anuj,

[Impala-ASF-CR] IMPALA-4276: Profile displays non-default query options set by planner

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4276: Profile displays non-default query options set by planner .. Patch Set 5: Build started:

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 34: Code-Review+2 Updated test_explain with a minor change. -- To view, visit

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-07-19 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#34). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-5586: Null-aware anti-join can take a long time to cancel

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5586: Null-aware anti-join can take a long time to cancel .. Patch Set 4: (1 comment)

[Impala-ASF-CR] IMPALA-4086: Add benchmark for simple scheduler

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4086: Add benchmark for simple scheduler .. Patch Set 5: Did this get lost in the shuffle? I'm trying to pare down my review inbox a bit :) -- To

[Impala-ASF-CR] IMPALA-5317: add DATE TRUNC() function

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5317: add DATE_TRUNC() function .. Patch Set 1: Any updates here? Can I help move this along somehow? -- To view, visit

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: Yes I think never printing stacktraces for MemLimitExceeded() makes sense. We have

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/882/

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/881/ --

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7445/5/be/src/testutil/mini-impala-cluster.cc File

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/7445/5/be/src/testutil/mini-impala-cluster.cc File

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5987 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-19 Thread Henry Robinson (Code Review)
Henry Robinson has submitted this change and it was merged. Change subject: IMPALA-4925: Cancel finstance if query has finished .. IMPALA-4925: Cancel finstance if query has finished This patch is a partial fix for the issue

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7311 To

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. Patch Set 6: Build started:

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. Patch Set 4: (2 comments)

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#6). Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts The

[Impala-ASF-CR] IMPALA-5539: Fix Kudu timestamp with -use local tz for unix ts

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new patch set (#5). Change subject: IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts .. IMPALA-5539: Fix Kudu timestamp with -use_local_tz_for_unix_ts The

[Impala-ASF-CR] IMPALA-4674: add new message to stress test

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: IMPALA-4674: add new message to stress test .. IMPALA-4674: add new message to stress test The main IMPALA-4674 commit adds a new OOM failure mode

[Impala-ASF-CR] IMPALA-4674: add new message to stress test

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: add new message to stress test .. Patch Set 1: Verified+1 This isn't exercised by the pre-merge tests so will manually verify. -- To view, visit

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/879/

[Impala-ASF-CR] IMPALA-5625: write profile when query times out

2017-07-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5625: write profile when query times out .. Patch Set 2: > I replied to them with "Done", but they show up as Draft, so I > wonder if you don't see them.

[Impala-ASF-CR] IMPALA-5625: write profile when query times out

2017-07-19 Thread Matthew Mulder (Code Review)
Matthew Mulder has posted comments on this change. Change subject: IMPALA-5625: write profile when query times out .. Patch Set 1: (8 comments) > Matt, you uploaded a new patch set, but please reply to the inline > comments

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7454 To

[Impala-ASF-CR] IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

2017-07-19 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7454 to look at the new patch set (#2). Change subject: IMPALA-5638: Fix Kudu table set tblproperties inconsistencies

[Impala-ASF-CR] IMPALA-5625: write profile when query times out

2017-07-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5625: write profile when query times out .. Patch Set 2: Matt, you uploaded a new patch set, but please reply to the inline comments with either "done"

[Impala-ASF-CR] IMPALA-4674: add new message to stress test

2017-07-19 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4674: add new message to stress test .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7458 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-19 Thread Attila Jeges (Code Review)
Attila Jeges has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 4: > Patch Set 3: Code-Review+2 Thanks for reviewing it. -- To view, visit

[Impala-ASF-CR] IMPALA-3548: Prune runtime filters based on query options in the FE

2017-07-19 Thread Attila Jeges (Code Review)
Attila Jeges has abandoned this change. Change subject: IMPALA-3548: Prune runtime filters based on query options in the FE .. Abandoned It was decided that another approach should be taken to implement this feature. I'm

[Impala-ASF-CR] IMPALA-5116: Remove deprecated hash * types in gutil

2017-07-19 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5116: Remove deprecated hash_* types in gutil .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7414/1/be/src/gutil/hash/hash.h File

[Impala-ASF-CR] IMPALA-4925: Cancel finstance if query has finished

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4925: Cancel finstance if query has finished .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5987 To unsubscribe,

[Impala-ASF-CR] IMPALA-5670: Misc. tidying of ExecEnv

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5670: Misc. tidying of ExecEnv .. Patch Set 5: Verified-1 Build failed: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/878/ -- To view,

[Impala-ASF-CR] IMPALA-4669: [KUTIL] Add kudu util library to the build.

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4669: [KUTIL] Add kudu_util library to the build. .. Patch Set 24: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. IMPALA-5407: Fix crash in HdfsSequenceTableWriter The following use of sequence file

[Impala-ASF-CR] IMPALA-5407: Fix crash in HdfsSequenceTableWriter

2017-07-19 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5407: Fix crash in HdfsSequenceTableWriter .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7394 To unsubscribe,