anujphadke has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/7332/6/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: PS6, Line 104: db_name = "test_role_privilege_case_x_" + ge > Why use a random suffix here but not in test_grant_revoke? Done. I did not look much into that test since this patch only adds test_role_privilege_case. Thanks for pointing that out. PS6, Line 105: db_name_upper_case = "TEST_ROLE_PRIVILEGE_CASE_y_" + get_random_id(5) : db_name_mixed_case = "TesT_Role_PRIVIlege_case > Maybe use TEST_GRANT_REVOKE and Test_GraNt_revoke or similar for prefixes? Done Line 138: assert any(db_name_mixed_case.lower() in x for x in result.data) > Yeah, most of these fit within 90 chars on 1 line. For the ones that don't, Done PS6, Line 195: > Not your change, but could you remove this semi-colon? Done -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
