[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. IMPALA-5031: unsafe random number generation in buffer-pool-test The bug is

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7596 To un

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 12: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/993/ -- To view, visit

[Impala-ASF-CR] IMPALA-4703: reservation denial debug action

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4703: reservation denial debug action .. Patch Set 12: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7022 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5768: Better developer documentation .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7350/2/bin/impala-config.sh File bin/impala-config.sh:

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. IMPALA-4674: Part 2: port backend exec to BufferPool Always create global BufferPool at

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/5801 To unsubscribe,

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 1: > I'm testing this out. https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/13 -- To vi

[Impala-ASF-CR] IMPALA-5598: Fix excessive dumping in MemLimitExceeded

2017-08-04 Thread Joe McDonnell (Code Review)
Joe McDonnell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7597 Change subject: IMPALA-5598: Fix excessive dumping in MemLimitExceeded .. IMPALA-5598: Fix excessive dumping in MemLimitExceeded ExecQue

[Impala-ASF-CR] IMPALA-5768: Better developer documentation

2017-08-04 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7350 to look at the new patch set (#4). Change subject: IMPALA-5768: Better developer documentation .. IMPALA-5768: Bet

[Impala-ASF-CR] IMPALA-5768

2017-08-04 Thread Zach Amsden (Code Review)
Hello Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7350 to look at the new patch set (#3). Change subject: IMPALA-5768 .. IMPALA-5768 Guide to important environment vari

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/991/ -- To

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7591/1//COMMIT_MSG Commit Message: Lin

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#2). Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. IMPALA-5666: ASAN poisoning for MemPool and BufferPool "If you poison us, do we not die?" * Use ASAN_[U

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG Commit Message: Line 9: For

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7524 To unsubsc

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/992/

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7596 To unsubsc

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7596 to look at the new patch set (#3). Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test ..

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7596/1/be/src/testutil/rand-uti

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 1: Added a testing section to clarify Jim's question. -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Tim Armstrong (Code Review)
Hello Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7596 to look at the new patch set (#2). Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test ..

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7596/1/be/src/testutil/rand-uti

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. Patch Set 1: Code-Review+2 You tested with UBSan? -- To view, visit http://gerrit.cloudera.org:

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7350/2/

[Impala-ASF-CR] IMPALA-5031: unsafe random number generation in buffer-pool-test

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7596 Change subject: IMPALA-5031: unsafe random number generation in buffer-pool-test .. IMPALA-5031: unsafe random number generation in buffe

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7524/2/be/src/service/impala-s

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new patch set (#3). Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. IMPALA-5696: Enable cipher configuration when using TLS / Thrift The 'cipher suite' is a descr

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-04 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7350/2/bi

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. Patch Set 1: (4 comments) Had a few very minor comments. This should be very helpful in catching any

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new patch set (#8). Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface This patch introd

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 7: (10 comments) http://gerrit.cloudera.org:8080/#/c/7542/7/be/src/runtime/

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update .gitinore files .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7590 To unsubscribe, visit http://gerrit.cloud

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has submitted this change and it was merged. Change subject: Update .gitinore files .. Update .gitinore files I noticed a bunch of new things had crept in. Change-Id: Ie6ef085357a3bf026f2b42689ee642192a7791e7 Rev

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update .gitinore files .. Patch Set 2: Verified+1 Hit the flaky TPC-DS data loading. It built fine. This change as no influence on tests so will manually verify

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Update .gitinore files .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/989/ -- To view, visit http://gerrit

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-04 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/1/bin/bootstrap_development.sh File bin/

[Impala-ASF-CR] IMPALA-5744: Add dummy 'use krpc' flag and create DataStream interface

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5744: Add dummy 'use_krpc' flag and create DataStream interface .. Patch Set 7: (10 comments) Looks pretty close to me. http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. IMPALA-5725: coalesce() with outer join incorrectly rewritten A recent change,

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7567 To unsub

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-04 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 1: I'm testing this out. -- To view, visit http://gerrit.cloudera.org:8080/7587 To unsubscr

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7587/1/bin/bootstrap_development.sh File

[Impala-ASF-CR] IMPALA-5666: ASAN poisoning for MemPool and BufferPool

2017-08-04 Thread Henry Robinson (Code Review)
Henry Robinson has uploaded a new change for review. http://gerrit.cloudera.org:8080/7591 Change subject: IMPALA-5666: ASAN poisoning for MemPool and BufferPool .. IMPALA-5666: ASAN poisoning for MemPool and BufferPool * Use

[Impala-ASF-CR] IMPALA-5696: Enable cipher configuration when using TLS / Thrift

2017-08-04 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5696: Enable cipher configuration when using TLS / Thrift .. Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7524/1/be/src/rpc/thrift-serve

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/991/ -- To view, visi

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tianyi Wang (Code Review)
Tianyi Wang has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 4: > (1 comment) Done -- To view, visit http://gerrit.cloudera.org:8080/7556 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tianyi Wang (Code Review)
Hello Impala Public Jenkins, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7556 to look at the new patch set (#4). Change subject: IMPALA-5572: Timestamp codegen for text scanner .

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7556/3/be/src/exec/text-converter.cc File be/src

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update .gitinore files .. Patch Set 2: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/7590 To unsubscribe, visit http://gerrit.cloudera.

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/990/ -- To view

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/988/ -

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/986/ -- To

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Tim Armstrong (Code Review)
Hello Bharath Vissapragada, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7590 to look at the new patch set (#2). Change subject: Update .gitinore files .. Update .gitinore files I noti

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Update .gitinore files .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/989/ -- To view, visit http://gerrit.cloudera.

[Impala-ASF-CR] Update .gitinore files

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Update .gitinore files .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7590/1//COMMIT_MSG Commit Message: PS1, Line 7: a > remove Done -- To

[Impala-ASF-CR] IMPALA-5757: Make tbl property toSql deterministic

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5757: Make tbl property toSql deterministic .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7580 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5757: Make tbl property toSql deterministic

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5757: Make tbl property toSql deterministic .. IMPALA-5757: Make tbl property toSql deterministic On Ubuntu 16.04, it seems that table pr

[Impala-ASF-CR] Update .gitinore filesa

2017-08-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Update .gitinore filesa .. Patch Set 1: Code-Review+2 (1 comment) Could you also add *.orig and *.rej files? (Outcome of git rebase/merge) http://gerrit

[Impala-ASF-CR] Update .gitinore filesa

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/7590 Change subject: Update .gitinore filesa .. Update .gitinore filesa I noticed a bunch of new things had crept in. Change-Id: Ie6ef085357

[Impala-ASF-CR] Problem: Improve error message when subquery is used in the ON clause

2017-08-04 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: Problem: Improve error message when subquery is used in the ON clause .. Patch Set 1: (2 comments) The fix looks Ok. Couple of nits in the commit messag

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/988/ -- To view

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Michael Brown and Matt Mulder have been helping me out with testing. So far this has held

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool .. Patch Set 40: Code-Review+2 Rebased. -- To view, visit http://gerrit.cloudera.org:8080/5801 To unsubscr

[Impala-ASF-CR] IMPALA-1575: Yield admission control resources at query end

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-1575: Yield admission control resources at query end .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7079/3/be/src/runtime/coordinator.cc

[Impala-ASF-CR] IMPALA-4674: Part 2: port backend exec to BufferPool

2017-08-04 Thread Tim Armstrong (Code Review)
Hello Thomas Tauber-Marshall, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5801 to look at the new patch set (#40). Change subject: IMPALA-4674: Part 2: port backend exec to BufferPool ..

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' .. Patch Set 2: (1 comment) > > Does this trigger only when there are two conc

[Impala-ASF-CR] Problem: Improve error message when subquery is used in the ON clause

2017-08-04 Thread Anonymous Coward (Code Review)
psi...@cloudera.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/7588 Change subject: Problem: Improve error message when subquery is used in the ON clause .. Problem: Improve error message when subqu

[Impala-ASF-CR] IMPALA-5749: coordinator race hits DCHECK 'num remaining backends > 0'

2017-08-04 Thread Thomas Tauber-Marshall (Code Review)
Hello Michael Ho, Sailesh Mukil, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7577 to look at the new patch set (#2). Change subject: IMPALA-5749: coordinator race hits DCHECK 'num_remaining_backends_ > 0' ...

[Impala-ASF-CR] IMPALA-5715: (mitigation only) defer destruction of MemTrackers

2017-08-04 Thread Michael Ho (Code Review)
Michael Ho has posted comments on this change. Change subject: IMPALA-5715: (mitigation only) defer destruction of MemTrackers .. Patch Set 3: Thanks for updating it. Will do a pass today. -- To view, visit http://gerrit.clou

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/987/ --

[Impala-ASF-CR] IMPALA-5725: coalesce() with outer join incorrectly rewritten

2017-08-04 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5725: coalesce() with outer join incorrectly rewritten .. Patch Set 2: Code-Review+2 GVO failed due to IMPALA-5760 -- To view, visit http://ger

[Impala-ASF-CR] IMPALA-4407: Move Impala setup procedures to main repo

2017-08-04 Thread Jim Apple (Code Review)
Jim Apple has uploaded a new change for review. http://gerrit.cloudera.org:8080/7587 Change subject: IMPALA-4407: Move Impala setup procedures to main repo .. IMPALA-4407: Move Impala setup procedures to main repo Before this

[Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query

2017-08-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/7560/3/fe/src/main/j

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/1/bin/impala-config.sh File bin/impala-c

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG Commit Message: Line 9: F

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.o

[Impala-ASF-CR] Guide to important environment variables for build, test, and mini-cluster operations.

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: Guide to important environment variables for build, test, and mini-cluster operations. .. Patch Set 2: (7 comments) Looks good to me. I noticed a few more thin

[Impala-ASF-CR] IMPALA-5602: Fix kudu queries being incorrectly optimized as small query

2017-08-04 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5602: Fix kudu queries being incorrectly optimized as small query .. Patch Set 3: (3 comments) Looking pretty good. http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5572: Timestamp codegen for text scanner

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5572: Timestamp codegen for text scanner .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/986/ -- To view, visi

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG Commit Message: Line 14:

[Impala-ASF-CR] IMPALA-5764: Allow overriding packaged components

2017-08-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5764: Allow overriding packaged components .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7581/1//COMMIT_MSG Commit Message: Line 14:

[Impala-ASF-CR] IMPALA-5757: Make tbl property toSql deterministic

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5757: Make tbl property toSql deterministic .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/985/ -- To view, v

[Impala-ASF-CR] IMPALA-5757: Make tbl property toSql deterministic

2017-08-04 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5757: Make tbl property toSql deterministic .. Patch Set 2: Code-Review+2 I only ran backend tests locally so I missed ToSqlTest. Updated in ps2. -- To

[Impala-ASF-CR] IMPALA-5757: Make tbl property toSql deterministic

2017-08-04 Thread Matthew Jacobs (Code Review)
Hello Impala Public Jenkins, Jim Apple, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7580 to look at the new patch set (#2). Change subject: IMPALA-5757: Make tbl property toSql deterministic ..

[Impala-ASF-CR] IMPALA-5757: Make tbl property toSql deterministic

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5757: Make tbl property toSql deterministic .. Patch Set 1: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/984/ -- To view, vi

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. IMPALA-5742: De-allocate buffer in parquet-reader on exit Testing: ran with ASAN wi

[Impala-ASF-CR] IMPALA-5742: De-allocate buffer in parquet-reader on exit

2017-08-04 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5742: De-allocate buffer in parquet-reader on exit .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7572 To unsubscri