[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7783 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. IMPALA-5648: fix count(*) mem estimate regression The metadata-only scan doesn't allocate I

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. IMPALA-5780,IMPALA-5779: extra spilling tests * Test for disable_unsafe_spills * Test for buffe

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7787 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/

[Impala-ASF-CR] IMPALA-5531: Fix correctness issue in correlated aggregate subqueries

2017-08-23 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5531: Fix correctness issue in correlated aggregate subqueries .. Patch Set 5: Code-Review+2 Rebase, keep Alex's +2 -- To view, visit http://ge

[Impala-ASF-CR] IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7680 To unsu

[Impala-ASF-CR] IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement .. IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement Change-Id: Idd7

[Impala-ASF-CR] IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/151/ --

[Impala-ASF-CR] IMPALA-5108: Followup change to do the cleanup.

2017-08-23 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new change for review. http://gerrit.cloudera.org:8080/7801 Change subject: IMPALA-5108: Followup change to do the cleanup. .. IMPALA-5108: Followup change to do the cleanup. This change involves g

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Pranay Singh (Code Review)
Pranay Singh has abandoned this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Abandoned This change was merged so I need to abandon the change I'll address the review comments as a p

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Pranay Singh (Code Review)
Pranay Singh has abandoned this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Abandoned The previous commit was merged so I have to abandon this change -- To view, visit http://gerr

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7791/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 13: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7367 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5570: fix spilling null-aware anti join .. IMPALA-5570: fix spilling null-aware anti join IMPALA-4672: Part 2 regressed NAAJ by tightenin

[Impala-ASF-CR] IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5309: [DOCS] Add TABLESAMPLE clause to SELECT statement .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7680 To unsubscribe,

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 5: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7783 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1146/ -- To view, v

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7783/4/fe/src/main/java/org/apache/impala/plan

[Impala-ASF-CR] IMPALA-5784: Separate planner and user set query options in profile

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5784: Separate planner and user set query options in profile .. Patch Set 4: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7721 T

[Impala-ASF-CR] IMPALA-5784: Separate planner and user set query options in profile

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5784: Separate planner and user set query options in profile .. IMPALA-5784: Separate planner and user set query options in profile This

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe,

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. IMPALA-5811: Add 'backends' tab to query details pages Add a 'backends' tab to query d

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1145/ -- To view, visit

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 11: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7560 T

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. IMPALA-5602: Fix query optimization for kudu and datasource tables Fix a

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. IMPALA-5775: (Addendum) Make SSL cluster actually come up in

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org

[Impala-ASF-CR] IMPALA-5625: stress test: write profile when queries fail

2017-08-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5625: stress test: write profile when queries fail .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7376/2/tests/stress/concurrent_select.

[Impala-ASF-CR] Hide some deprecated flags

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Hide some deprecated flags .. Hide some deprecated flags Hidden flags do not show up in /varz or --help. Change-Id: I948b46cd6853f1d8ebaaadaba7

[Impala-ASF-CR] Hide some deprecated flags

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Hide some deprecated flags .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7786 To unsubscribe, visit http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5625: stress test: write profile when queries fail

2017-08-23 Thread Matthew Mulder (Code Review)
Matthew Mulder has posted comments on this change. Change subject: IMPALA-5625: stress test: write profile when queries fail .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7376/2/tests/stress/concurrent_select

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/7783/3/fe/src/main/java/org/apache/

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7783/3/fe/src/main/java/org/apache/impala/pla

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#4). Change subject: IMPALA-5648: fix count(*) mem estimate regression .. IMPALA-5648: fix count(*) mem estimate regression The metadata-only scan doesn't allocate I/O buffers, contrar

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 2: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1143/ -- To v

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 13: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1142/ -- To

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1144/ -- To view, vis

[Impala-ASF-CR] IMPALA-5625: stress test: write profile when queries fail

2017-08-23 Thread Michael Brown (Code Review)
Michael Brown has posted comments on this change. Change subject: IMPALA-5625: stress test: write profile when queries fail .. Patch Set 2: (2 comments) Almost there. http://gerrit.cloudera.org:8080/#/c/7376/2/tests/stress/co

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5648: fix count(*) mem estimate regression .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/7783/3/fe/src/main/java/org/apache/impala/planner

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/778

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/1

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7789 To unsu

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7789/2/docs/topics/impala

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#3). Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax Turned one instanc

[Impala-ASF-CR] IMPALA-5648: fix count(*) mem estimate regression

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#3). Change subject: IMPALA-5648: fix count(*) mem estimate regression .. IMPALA-5648: fix count(*) mem estimate regression The metadata-only scan doesn't allocate I/O buffers, contrar

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs .. Patch Set 5: Code-Review+1 carry +1 -- To view, visit http://gerrit.cloudera.org:8080/7739 To unsubscribe, vi

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7739/3/fe/src/main/java/org/apache/impala/planne

[Impala-ASF-CR] IMPALA-4987: Skip test rows availability when testing over a network.

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has abandoned this change. Change subject: IMPALA-4987: Skip test_rows_availability when testing over a network. .. Abandoned Not the right fix, see JIRA -- To view, visit http://gerrit.cloudera.org:8080/6144 To un

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Tim Armstrong (Code Review)
Hello Alex Behm, Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7739 to look at the new patch set (#5). Change subject: IMPALA-5713: always reserve memory for preaggs .. IMPALA

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-23 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/7061/6/be/src/rpc/thrift-ser

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-23 Thread John Sherman (Code Review)
John Sherman has posted comments on this change. Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. Patch Set 6: (1 comment) I haven't created the automated test yet, I will try to create o

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs .. Patch Set 4: Code-Review+1 (2 comments) FE changes lgtm. I only skimmed the BE code which also looked ok. Let's w

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs .. Patch Set 3: I'd be interested to get Mostafa's input on the change. -- To view, visit http://gerrit.cloudera

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs .. Patch Set 3: I augmented the commit message a bit to explain the context and details of the change. -- To vi

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Tim Armstrong (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7739 to look at the new patch set (#4). Change subject: IMPALA-5713: always reserve memory for preaggs .. IMPALA-5713: alwa

[Impala-ASF-CR] IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer

2017-08-23 Thread John Sherman (Code Review)
John Sherman has uploaded a new patch set (#6). Change subject: IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer .. IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer - Previously TThreadPool

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7791/1//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1143/ -- To view, visit

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 2: Code-Review+2 rebased onto the naaj patch to confirm no merge conflicts -- To view, visit http://

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/1141/ -- To v

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: > The previous commit was merged - it will need a new change ID. Oh weird, now I see

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 13: Code-Review+2 carry -- To view, visit http://gerrit.cloudera.org:8080/7367 To unsubscribe, visi

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 12: Code-Review+2 rebase -- To view, visit http://gerrit.cloudera.org:8080/7367 To unsubscribe, vis

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 13: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1142/ -- To view, vis

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/7367/12/tests/query_test/test_spilling.py File t

[Impala-ASF-CR] IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5512: [DOCS] Distinguish GROUP BY and ORDER BY in SELECT syntax .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7789/2/docs/topics/impala_se

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: The previous commit was merged - it will need a new change ID. -- To view, visi

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: Looks like the change-id was modified so this shows up as a separate review (see also

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries/Que

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1141/ -- To view, visit

[Impala-ASF-CR] IMPALA-5570: fix spilling null-aware anti join

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5570: fix spilling null-aware anti join .. Patch Set 12: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7367/12/tests/query_test/test_spilling

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queries

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-que

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Pranay Singh (Code Review)
Pranay Singh has uploaded a new change for review. http://gerrit.cloudera.org:8080/7791 Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. IMPALA-5108: idle_session_timeout kicks in later than ex

[Impala-ASF-CR] IMPALA-5108: idle session timeout kicks in later than expected

2017-08-23 Thread Pranay Singh (Code Review)
Pranay Singh has posted comments on this change. Change subject: IMPALA-5108: idle_session_timeout kicks in later than expected .. Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/7729/1//COMMIT_MSG Commit Message

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-08-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 2: (3 comments) Few more small typos http://gerrit.cloudera.org:8080/#/c

[Impala-ASF-CR] IMPALA-5784: Separate planner and user set query options in profile

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5784: Separate planner and user set query options in profile .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11

[Impala-ASF-CR] IMPALA-5784: Separate planner and user set query options in profile

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5784: Separate planner and user set query options in profile .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7721 To unsubsc

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1139/ -- To vi

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit ht

[Impala-ASF-CR] IMPALA-5210: Count rows and collection items in parquet scanner separately

2017-08-23 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-5210: Count rows and collection items in parquet scanner separately .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/7776/2/be/src/exec/hd

[Impala-ASF-CR] IMPALA-5713: always reserve memory for preaggs

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5713: always reserve memory for preaggs .. Patch Set 3: Code-Review+1 I'm good with this but I think it would be good to get a second opinion. -- To view, v

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backe

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Henry Robinson (Code Review)
Hello Bharath Vissapragada, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7711 to look at the new patch set (#6). Change subject: IMPALA-5811: Add 'backends' tab to query details pages ...

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7787 To unsubscribe, visit http:/

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 11: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 11: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7560 To un

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/querie

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal. .. Patch Set 4: (2 comments) > > Matt: Might be nice to have some tests like those

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Bikramjeet Vig (Code Review)
Hello Matthew Jacobs, Alex Behm, Tim Armstrong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7560 to look at the new patch set (#11). Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/7560/10/fe/src/test/java/or

[Impala-ASF-CR] IMPALA-5811: Add 'backends' tab to query details pages

2017-08-23 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages .. Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backend-st

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-23 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-veri

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-23 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:808

[Impala-ASF-CR] IMPALA-5602: Fix query optimization for kudu and datasource tables

2017-08-23 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5602: Fix query optimization for kudu and datasource tables .. Patch Set 10: Code-Review+2 (2 comments) Please address MJ's last comment. http://gerrit.clo

[Impala-ASF-CR] IMPALA-5775: (Addendum) Make SSL cluster actually come up in test client ssl.py

2017-08-23 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5775: (Addendum) Make SSL cluster actually come up in test_client_ssl.py .. Patch Set 1: Code-Review+2 I agree with the fix, however, we don't have bi-di

[Impala-ASF-CR] IMPALA-5780,IMPALA-5779: extra spilling tests

2017-08-23 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7787/1/testdata/workloads/functional-query/queri

[Impala-ASF-CR] IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

2017-08-23 Thread Philip Zeyliger (Code Review)
Hello Dan Hecht, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7781 to look at the new patch set (#4). Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is a literal.

  1   2   >