Dan Hecht has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages ......................................................................
Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: Line 571: value->AddMember("done", IsDone(), document->GetAllocator()); 'done' is more of an internal concept now (and I think that's better), so not sure we need to print it. It's derived from status and num_remaining_instances anyway. I'm not super opposed to having it though, if you feel it helps. PS5, Line 580: last_heard_from that name doesn't sound like a relative time. maybe time_since_last_report or time_since_last_report_ms? http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator-backend-state.h File be/src/runtime/coordinator-backend-state.h: Line 116: void ToJson(rapidjson::Value* value, rapidjson::Document* doc); let's add a quick comment for that. Line 219: int64_t last_report_time_ms_ = 0; specify what clock that is. is it unix millis or monotoic millis or something else? http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: Line 190: void BackendsToJson(rapidjson::Document* document); document http://gerrit.cloudera.org:8080/#/c/7711/5/be/src/service/impala-http-handler.h File be/src/service/impala-http-handler.h: Line 94: void QueryBackendsHandler( document -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
