[Impala-ASF-CR] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has uploaded a new patch set (#2). Change subject: IMPALA-5538: Use explicit catalog versions for deleted objects .. IMPALA-5538: Use explicit catalog versions for deleted objects This commit changes the wa

[Impala-ASF-CR] [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: [PREVIEW] IMPALA-5538: Use explicit catalog versions for deleted objects .. Patch Set 1: (28 comments) http://gerrit.cloudera.org:8080/#/c/7731/1/be/sr

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/7955/10/fe/src/main/java/org/apa

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/8004 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit http:

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. IMPALA-5867: Fix bugs parsing 2-digit year This patch fixes several bugs parsing 1 or 2-digit year

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#3). Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Promote integer types for ABS() The internal representation of the most negative number in two's complem

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/8004/2/be/src/exprs/expr-test.cc File be/src/exprs/e

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Lars Volker (Code Review)
Lars Volker has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 2: (3 comments) Looks good to me, but I'm no expert in this part of the codebase. http://gerrit.clouder

[Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange

2017-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5199: prevent hang on empty row batch exchange .. Patch Set 2: That seems pretty rare but possible. In the common case where the limit is at the top leve

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#10). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves th

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7955/9/fe/src/main/jav

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/7955/9/fe/src/main/ja

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 2: As per Greg's request, add overflow check for BIGINT. All other types just get promoted. -- To vie

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new patch set (#2). Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Promote integer types for ABS() The internal representation of the most negative number in 2's complemen

[Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange

2017-09-07 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5199: prevent hang on empty row batch exchange .. Patch Set 2: The fix looks good to me, and should work fine for most cases. One case I'm worried about

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (14 comments) Redo'ing the test a little, will update the new PS short

[Impala-ASF-CR] IMPALA-4939, IMPALA-4939: Decimal V2 multiplication

2017-09-07 Thread Taras Bobrovytsky (Code Review)
Taras Bobrovytsky has posted comments on this change. Change subject: IMPALA-4939, IMPALA-4939: Decimal V2 multiplication .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/7438/4//COMMIT_MSG Commit Message: Line

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. IMPALA-2107: [DOCS] Document base64*code() functions base64decode() base64encode() Chan

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7963 To unsubscribe, v

[Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange

2017-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5199: prevent hang on empty row batch exchange .. IMPALA-5199: prevent hang on empty row batch exchange The error path where delivery of "eos" fails now beh

[Impala-ASF-CR] IMPALA-5199: prevent hang on empty row batch exchange

2017-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/8005 Change subject: IMPALA-5199: prevent hang on empty row batch exchange .. IMPALA-5199: prevent hang on empty row batch exchange The error

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. Patch Set 2: Build started: https://jenkins.impala.io/job/gerrit-docs-submit/152/ -- To view, v

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-07 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7963 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 6: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1208/ -- To view, visit ht

[Impala-ASF-CR] Bump Kudu version to a71ecfd

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: Ie23d852f0d630f9484d8ae4f772af6bba13ea24f Reviewed-on: http://gerrit.clo

[Impala-ASF-CR] Bump Kudu version to a71ecfd

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to a71ecfd .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/8000 To unsubscribe, visit http://gerrit.cloud

[Impala-ASF-CR] IMPALA-5867: Fix bugs parsing 2-digit year

2017-09-07 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5867: Fix bugs parsing 2-digit year .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7910 To unsubscribe, visit http://ger

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has posted comments on this change. Change subject: IMPALA-4513: Promote integer types for ABS() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8004/1/be/src/exprs/expr-test.cc File be/src/exprs/ex

[Impala-ASF-CR] IMPALA-4513: Promote integer types for ABS()

2017-09-07 Thread Zach Amsden (Code Review)
Zach Amsden has uploaded a new change for review. http://gerrit.cloudera.org:8080/8004 Change subject: IMPALA-4513: Promote integer types for ABS() .. IMPALA-4513: Promote integer types for ABS() The internal representation o

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (3 comments) Code looks good to me, still need to flesh out tests. http://gerrit

[Impala-ASF-CR] IMPALA-5425: Add test for validating input when setting query options

2017-09-07 Thread Tianyi Wang (Code Review)
Tianyi Wang has uploaded a new patch set (#6). Change subject: IMPALA-5425: Add test for validating input when setting query options .. IMPALA-5425: Add test for validating input when setting query options This patch adds multi

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has posted comments on this change. Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. Patch Set 2: (11 comments) http://gerrit.cloudera.org:8080/#/c/7954/1//COMMIT_MSG Commit M

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 9: (9 comments) http://gerrit.cloudera.org:8080/#/c/7955/9/fe/src/main/j

[Impala-ASF-CR] Bump Kudu version to a71ecfd

2017-09-07 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: Bump Kudu version to a71ecfd .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/8000 To unsubscribe, visit http://gerrit.c

[Impala-ASF-CR] Bump Kudu version to a71ecfd

2017-09-07 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: Bump Kudu version to a71ecfd .. Patch Set 1: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/1207/ -- To view, visit http://gerrit.cl

[Impala-ASF-CR] Bump Kudu version to a71ecfd

2017-09-07 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has uploaded a new change for review. http://gerrit.cloudera.org:8080/8000 Change subject: Bump Kudu version to a71ecfd .. Bump Kudu version to a71ecfd Change-Id: Ie23d852f0d630f9484d8ae4f772af6bba13ea24f --- M

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7963/1/docs/shared/impala_common.xml File d

[Impala-ASF-CR] IMPALA-2107: [DOCS] Document base64*code() functions

2017-09-07 Thread John Russell (Code Review)
John Russell has uploaded a new patch set (#2). Change subject: IMPALA-2107: [DOCS] Document base64*code() functions .. IMPALA-2107: [DOCS] Document base64*code() functions base64decode() base64encode() Change-Id: I5251e368ad36

[Impala-ASF-CR] [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-09-07 Thread John Russell (Code Review)
John Russell has uploaded a new change for review. http://gerrit.cloudera.org:8080/7999 Change subject: [DOCS] Tighten up advice about first COMPUTE INCREMENTAL STATS .. [DOCS] Tighten up advice about first COMPUTE INCREMENTAL

[Impala-ASF-CR] Tighten up advice about first COMPUTE INCREMENTAL STATS

2017-09-07 Thread John Russell (Code Review)
John Russell has abandoned this change. Change subject: Tighten up advice about first COMPUTE INCREMENTAL STATS .. Abandoned Accidentally created this review based on master rather than a private branch. Will do some git fixup

[Impala-ASF-CR] [DOCS] Explain Boost setting needed for 96-bit timestamps

2017-09-07 Thread John Russell (Code Review)
John Russell has posted comments on this change. Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps .. Patch Set 2: Patch set 2 is a no-op from a review perspective. I got rid of a commit that got into m

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Dimitris Tsirogiannis (Code Review)
Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (2 comments) Flushing minor comments from patch #8 and switching to p

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#9). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves the

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/7955/8/be/src/catalog

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 8: (8 comments) http://gerrit.cloudera.org:8080/#/c/7955/8/be/src/catalog/catalog.cc

[Impala-ASF-CR] IMPALA-5664: Unix time to timestamp conversions may crash Impala

2017-09-07 Thread Csaba Ringhofer (Code Review)
Csaba Ringhofer has uploaded a new patch set (#2). Change subject: IMPALA-5664: Unix time to timestamp conversions may crash Impala .. IMPALA-5664: Unix time to timestamp conversions may crash Impala TimestampValue::FromSubsecon

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has uploaded a new patch set (#8). Change subject: IMPALA-5881: Use native allocation while building catalog updates .. IMPALA-5881: Use native allocation while building catalog updates This patch moves the

[Impala-ASF-CR] IMPALA-5881: Use native allocation while building catalog updates

2017-09-07 Thread Bharath Vissapragada (Code Review)
Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5881: Use native allocation while building catalog updates .. Patch Set 7: (13 comments) Addressed comments other than the test file. http://ger