[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-18 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: DDL for multiple partitions .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5726/3/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] IMPALA-1654: DDL for multiple partitions

2017-01-17 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: DDL for multiple partitions .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5726/3/docs/topics/impala_alter_table.xml File

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-20 Thread Amos Bird (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5535 to look at the new patch set (#4). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive.

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-19 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 3: (1 comment)

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-19 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new patch set (#3). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-19 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new patch set (#3). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-17 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5535/1//COMMIT_MSG Commit

[Impala-ASF-CR] IMPALA-4033: Treat string-partition key values as case sensitive.

2016-12-17 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new patch set (#2). Change subject: IMPALA-4033: Treat string-partition key values as case sensitive. .. IMPALA-4033: Treat string-partition key values as case sensitive. This commit makes ADD

[Impala-ASF-CR] IMPALA-4033: Improvements of partition DDL.

2016-12-15 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new change for review. http://gerrit.cloudera.org:8080/5535 Change subject: IMPALA-4033: Improvements of partition DDL. .. IMPALA-4033: Improvements of partition DDL. This commit makes ADD PARTITION

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-12-15 Thread Amos Bird (Code Review)
Amos Bird has abandoned this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. Abandoned https://gerrit.cloudera.org/#/c/5535/ -- To view, visit http://gerrit.cloudera.org:8080/5137 To

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-11-18 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. Patch Set 1: (8 comments) Ah, sorry. I saw there are other commits targeting more than one issues. What

[Impala-ASF-CR] IMPALA-4033,IMPALA-4105: Improvements of partition DDL.

2016-11-17 Thread Amos Bird (Code Review)
Amos Bird has uploaded a new change for review. http://gerrit.cloudera.org:8080/5137 Change subject: IMPALA-4033,IMPALA-4105: Improvements of partition DDL. .. IMPALA-4033,IMPALA-4105: Improvements of partition DDL. This

[Impala-ASF-CR] IMPALA-4433: Fix undefined NDV calculations

2016-11-09 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-4433: Fix undefined NDV calculations .. Patch Set 2: Tested this patch on my Ubuntu server. The stats mismatching cases are gone. Thanks Jim ;) -- To

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-10-25 Thread Amos Bird (Code Review)
Hello Marcel Kornacker, Bharath Vissapragada, Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#19). Change subject: IMPALA-1654: General partition exprs in DDL operations.

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-10-23 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 18: Cool! I'll do the rebase this week. -- To view, visit

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 16: (9 comments)

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 14: (1 comment) Sorry I got quite busy recently. I still have no luck running local tests.

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-20 Thread Amos Bird (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#16). Change subject: IMPALA-1654: General partition exprs in DDL operations. ..

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Amos Bird (Code Review)
Hello Alex Behm, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3942 to look at the new patch set (#12). Change subject: IMPALA-1654: General partition exprs in DDL operations. ..

[Impala-ASF-CR] IMPALA-1654: General partition exprs in DDL operations.

2016-09-14 Thread Amos Bird (Code Review)
Amos Bird has posted comments on this change. Change subject: IMPALA-1654: General partition exprs in DDL operations. .. Patch Set 11: (1 comment) Thanks for helping me fix the auditing bugs. I wish this wiki may help me get