John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/8404 )
Change subject: IMPALA-5017: Error on decimal overflow
..
Patch Set 1:
(1 comment)
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 13:
Thanks! Also thanks to you and
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 12:
It looks like it passed
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 12:
My local build issue related to
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 11:
Thanks, I added my comments to
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 11:
Ok, kicked off another run.
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 10:
Thanks for the analysis, I'll fix
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 10:
Ok kicked off the job and used
Hello Henry Robinson, Matthew Jacobs, Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7061
to look at the new patch set (#10).
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 9:
I've done local testing which
Hello Henry Robinson, Matthew Jacobs, Sailesh Mukil, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7061
to look at the new patch set (#9).
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
John Sherman has posted comments on this change. (
http://gerrit.cloudera.org:8080/7061 )
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 8:
No problem, I just got back from a
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 8:
(1 comment)
Thanks for the feedback Henry. I've attempted to create an
John Sherman has uploaded a new patch set (#8).
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
- Previously
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 7:
A couple of test questions:
Would the custom cluster test framework be the
John Sherman has uploaded a new patch set (#7).
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
- Previously
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 6:
(1 comment)
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 6:
(1 comment)
I haven't created the automated test yet, I will try to create
John Sherman has uploaded a new patch set (#6).
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
- Previously
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
Currently running my merged changes through the run-all test suite. Hit some
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
> Hi John - anything I can do to help with this one? Let me know if
> you
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
I don't quite know the correct etiquette, should I fix the merge conflict
John Sherman has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 2:
No, I do not feel strongly about this.
> > Should any startup
John Sherman has posted comments on this change.
Change subject: IMPALA-4737: Prevent SIGUSR1 from killing daemons when
minidumps are disabled
..
Patch Set 2:
Should any startup scripts be modified to trap '' SIGUSR1 before
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
Patch Set 5:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7061/5//COMMIT_MSG
Commit
John Sherman has uploaded a new patch set (#5).
Change subject: IMPALA-5394: Change ThriftServer() to always use
TAcceptQueueServer
..
IMPALA-5394: Change ThriftServer() to always use TAcceptQueueServer
- Previously
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 4:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7061/4/be/src/service/impala-server.cc
File
John Sherman has uploaded a new patch set (#4).
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
IMPALA-5394: Handle blocked HS2 connections
- TThreadPoolServer calls getTransport() on a client from the Server
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
Thanks, yeah I overthought it. I'll run this through run-all-tests and post the
patch.
> My
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
I'd like some advice/feedback on the approach for enforcing fe_service_threads.
In my local diff,
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
It looks like it'll be next week (or this weekend) before I'm able to make some
time to write/test
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
Yeah, I'll give it a go.
> Do you think that's something you could add to this patch?
--
To view,
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
Giving this a bump, since my updated patch might have slipped under the radar
during the holiday.
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7061/3/be/src/rpc/TAcceptQueueServer.cpp
File
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Handle blocked HS2 connections
..
Patch Set 3:
Ran the latest patch through be/fe/e2e testing.
be/fe ran clean.
end to end mostly ran clean. I had
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
Ok, my manual testing went well. Took a bit of effort to get it so I could get
my
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
I'm going to test the requested changes on a local kerberos cluster tomorrow
and
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
Is the the -kerb option deprecated in the buildall.sh script? If not is there a
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
> Thanks for the write-up, very helpful!
I'll give that a try. I think the hard
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
(1 comment)
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
> (1 comment)
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
(2 comments)
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 2:
I was able to get my test environment properly setup for running the run-all.sh
John Sherman has uploaded a new patch set (#2).
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
IMPALA-5394: Set socket timeouts while opening TSaslTransport
- TThreadPoolServer calls
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 1:
> (1 comment)
>
> Thanks John. The internal connection timeout is actually 5
John Sherman has posted comments on this change.
Change subject: IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded
..
Patch Set 1:
(1 comment)
John Sherman has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7075
Change subject: IMPALA-5432: Remove invalid DCHECK from SetMemLimitExceeded
..
IMPALA-5432: Remove invalid DCHECK from
John Sherman has posted comments on this change.
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
Patch Set 1:
> Thanks for submitting this John. Was there any testing you did to
> validate
John Sherman has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7061
Change subject: IMPALA-5394: Set socket timeouts while opening TSaslTransport
..
IMPALA-5394: Set socket timeouts while opening
50 matches
Mail list logo
