Matthew Jacobs has posted comments on this change. (
http://gerrit.cloudera.org:8080/8038 )
Change subject: IMPALA-5736: Add impala-shell argument to set default query
options
..
Patch Set 1:
> MJ, do you prefer one option
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG
Commit Message:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5908: Allow SET to unset modified query options.
..
Patch Set 9:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8070/9//COMMIT_MSG
Commit Message:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: addendum - add missing RAT check
..
Patch Set 2:
Thanks for fixing this.
@Alex The test job had a known spurious failure cleaning up the
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 7:
> The rat-check job actually failed because of a file introduced here
> - it
Matthew Jacobs has submitted this change and it was merged.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
IMPALA-5920: Remove admission control dependency on YARN RM jar
Impala's admission
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 6: Verified+1
The job actually passed, cleaning up the workspace failed
21:19:36
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 6: Code-Review+2
I'll count the +1s from Tim and Zach, and no further comments
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 5:
(2 comments)
Thanks for the detailed review, Zach. If nobody has further
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8035
to look at the new patch set (#5).
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 4:
(13 comments)
Thanks, Zach - some good observations. I made a bunch of the
Hello Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8035
to look at the new patch set (#4).
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 3:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5905: build-all-flag-combinations addendum
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8061
To unsubscribe, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
Patch Set 2:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/8035/2//COMMIT_MSG
Commit
Matthew Jacobs has uploaded a new patch set (#3).
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
IMPALA-5920: Remove admission control dependency on YARN RM jar
Impala's admission controller
Matthew Jacobs has posted comments on this change.
Change subject: [DOCS] Explain Boost setting needed for 96-bit timestamps
..
Patch Set 2:
(3 comments)
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 3f49724
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8040
To unsubscribe, visit
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-5920: Remove admission control dependency on YARN RM jar
..
IMPALA-5920: Remove admission control dependency on YARN RM jar
Impala's admission controller
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8035
Change subject: IMPALA-5920: Remove admission control dependency on YARN
resourcemanager
..
IMPALA-5920: Remove admission control
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 3f49724
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8028
To unsubscribe, visit
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/8000
Change subject: Bump Kudu version to a71ecfd
..
Bump Kudu version to a71ecfd
Change-Id: Ie23d852f0d630f9484d8ae4f772af6bba13ea24f
---
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7910/3//COMMIT_MSG
Commit Message:
PS3, Line 22:
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to a71ecfd
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7975
To unsubscribe, visit
Matthew Jacobs has submitted this change and it was merged.
Change subject: Bump Kudu version to a71ecfd
..
Bump Kudu version to a71ecfd
Change-Id: I4fb177b80f6c193af3f6b6bf9d7b205ab31d2f3e
---
M buildall.sh
1 file changed, 1
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7975
Change subject: Bump Kudu version to a71ecfd
..
Bump Kudu version to a71ecfd
Change-Id: I4fb177b80f6c193af3f6b6bf9d7b205ab31d2f3e
---
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5589: change "set" in impala-shell to show empty string
for unset query options
..
Patch Set 4: Code-Review+2
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5589: change "set" in impala-shell to show empty string
for unset query options
..
Patch Set 3: Code-Review+2
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5589: change "set" in impala-shell to show empty string
for unset query options
..
Patch Set 2:
Please fix the typos before submitting
--
To view,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5589: change "set" in impala-shell to show empty string
for unset query options
..
Patch Set 2: Code-Review+2
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5891: fix PeriodicCounterUpdater initialization
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7942
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5867: Fix bugs parsing 2-digit year
..
Patch Set 3:
(1 comment)
The fact that we found 3 issues in this code (after IMPALA-3894) makes me
nervous. I
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5871: KuduPartitionExpr incorrectly handles its child
types
..
Patch Set 1: Code-Review+1
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)
..
Patch Set 3: Code-Review+1
(3 comments)
Looks good, thanks! Just a few small things. Clearly
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1c70e5d
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7903
To unsubscribe, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5854: Update external hadoop versions
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh
File
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5863: Include-what-you-use for Kudu client
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7872
To unsubscribe, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5854: Update external hadoop versions
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7892/1/bin/impala-config.sh
File
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5589: change "set" in imapla-shell to show empty string
for unset query options
..
Patch Set 1:
(5 comments)
Matthew Jacobs has posted comments on this change.
Change subject: Include-what-you-use for Kudu client
..
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7872/2//COMMIT_MSG
Commit Message:
Line 7:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5857: avoid invalid free of hedged read metrics
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7885
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1c70e5d
..
Patch Set 1:
(1 comment)
does the code not compile without the header changes? It's best to separate
code changes from
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5855: reserve enough memory for preaggs
..
Patch Set 2:
I think you may need to update test admission-reject-min-reservation.test now
too, since that
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..
Patch Set 1:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5852: improve MINIMUM_RESERVATION_UNAVAILABLE error
..
Patch Set 1: Code-Review+1
Looks more helpful to me, thanks
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 6: Code-Review+2
Agg memory changed in the test cases after Tim's recent patch for pre-agg
Hello Philip Zeyliger, Impala Public Jenkins, Tim Armstrong, Dan Hecht,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7834
to look at the new patch set (#6).
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5211: Simplifying conditionals (istrue, nullif, etc.)
..
Patch Set 2:
(16 comments)
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1c70e5d
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7855
To unsubscribe, visit
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 1c70e5d
..
Patch Set 2:
> (1 comment)
Ah, that's on Cloudera's github mirror. Let's choose the Apache repo.
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 22a19d9
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7855/1//COMMIT_MSG
Commit Message:
PS1, Line 7: 22a19d9
where is
Hello Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7834
to look at the new patch set (#5).
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Hello Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7834
to look at the new patch set (#4).
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Hello Philip Zeyliger,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7834
to look at the new patch set (#3).
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 2:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 2:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
Patch Set 1:
(1 comment)
Matthew Jacobs has uploaded a new patch set (#2).
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
IMPALA-5838: Improve errors on AC buffer mem rejection
The error message returned when a query is
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7834
Change subject: IMPALA-5838: Improve errors on AC buffer mem rejection
..
IMPALA-5838: Improve errors on AC buffer mem rejection
The
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 6:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 5:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7688
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/7787
To unsubscribe, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 11: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7560
To
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5780,IMPALA-5779: extra spilling tests
..
Patch Set 1:
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784: Separate planner and user set query options in
profile
..
Patch Set 4: Code-Review+1
Great, thanks!
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 10:
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5602: Fix query optimization for kudu and datasource
tables
..
Patch Set 8:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7721/3//COMMIT_MSG
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 3:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 3:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5211: Simplifying ifnull/isnull/nvl where conditional is
a literal.
..
Patch Set 3:
Might be nice to have some tests like those added in this patch
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 3:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7640
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 9:
(1 comment)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 1:
> > > > (1 comment)
> > > Relying to Dan and Balasz:
> > >
> > > It's
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 1:
> > > (1 comment)
> > Relying to Dan and Balasz:
> >
> > It's actually
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 8: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7640
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5798: ASAN use-after-poison in Parquet decoder
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7769
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7640
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5784 : Separate planner and user set query options in
profile
..
Patch Set 1:
> (1 comment)
Relying to Dan and Balasz:
It's actually hard to determine
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7688/3/be/src/exec/kudu-table-sink.cc
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
..
Patch Set 10: Code-Review+2
String msg changed and an existing test needed to be updated
--
To view,
Hello Impala Public Jenkins, Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7678
to look at the new patch set (#10).
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/7688/3/be/src/exec/kudu-table-sink.cc
Hello Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7678
to look at the new patch set (#9).
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/7678
To unsubscribe,
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
..
Patch Set 8:
(1 comment)
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7767
Change subject: Bump Kudu version to 44a820b
..
Bump Kudu version to 44a820b
Change-Id: I1e86ce13d1fdc73487b8067f3670ee73b9269366
---
Matthew Jacobs has posted comments on this change.
Change subject: Bump Kudu version to 44a820b
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7755
To unsubscribe, visit
Matthew Jacobs has submitted this change and it was merged.
Change subject: Bump Kudu version to 44a820b
..
Bump Kudu version to 44a820b
Change-Id: I599843a7c230ec75699b9f236f9f0a97949278b9
---
M buildall.sh
1 file changed, 1
Matthew Jacobs has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7755
Change subject: Bump Kudu version to 44a820b
..
Bump Kudu version to 44a820b
Change-Id: I599843a7c230ec75699b9f236f9f0a97949278b9
---
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5158,IMPALA-5236: account for unused buffer pool
reservations
..
Patch Set 8: Code-Review+1
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
..
Patch Set 8:
looks like test_spilling.py will still require a lot of changes
--
To view, visit
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5799: Kudu DML can crash if schema has changed
..
Patch Set 2:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/7688/1//COMMIT_MSG
Commit Message:
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5352: Age out unused file handles from the cache
..
Patch Set 2:
(2 comments)
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5504: Fix TupleIsNullPredicate evaluation.
..
Patch Set 1: Code-Review+2
Nice catch
--
To view, visit http://gerrit.cloudera.org:8080/7737
To
Hello Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7678
to look at the new patch set (#8).
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
Matthew Jacobs has posted comments on this change.
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
..
Patch Set 7: Code-Review+2
carrying Tim's +2
--
To view, visit http://gerrit.cloudera.org:8080/7678
Hello Dan Hecht, Tim Armstrong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7678
to look at the new patch set (#7).
Change subject: IMPALA-5644,IMPALA-5810: Min reservation improvements
1 - 100 of 1020 matches
Mail list logo
