[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has submitted this change and it was merged. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. IMPALA-3308: Get expr-test passing on PPC64LE When using gcc 5+ (which introduced a new library ABI

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 6: Code-Review+2 Rebase, carry +2 -- To view, visit http://gerrit.cloudera.org:8080/4186 To

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 5: I'll merge this -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-28 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4186 To unsubscribe, visit

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-27 Thread Dan Hecht (Code Review)
Dan Hecht has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 4: Let's also disallow the copy constructor (see DISALLOW_COPY_AND_ASSIGN macro). -- To view, visit

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-20 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-20 Thread segelyang (Code Review)
segelyang has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 4: Thanks for your comments. I have re-uploaded the patch. -- To view, visit

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-20 Thread segelyang (Code Review)
segelyang has uploaded a new patch set (#4). Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. IMPALA-3308: Get expr-test passing on PPC64LE When using gcc 5+ (which introduced a new library ABI that includes new

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4186/3/be/src/exprs/expr-value.h File

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: (2 comments) No problems, just wanted to make sure that this patch made it it.

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread segelyang (Code Review)
segelyang has posted comments on this change. Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. Patch Set 3: I had a holiday last week and am sorry for late. I have uploaded a new patch. Please help to review.

[Impala-ASF-CR] IMPALA-3308: Get expr-test passing on PPC64LE

2016-09-19 Thread segelyang (Code Review)
segelyang has uploaded a new patch set (#3). Change subject: IMPALA-3308: Get expr-test passing on PPC64LE .. IMPALA-3308: Get expr-test passing on PPC64LE When using gcc 5+ (which introduced a new library ABI that includes new