Re: [Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-21 Thread Alex Behm
Thanks for your contribution! On Fri, Oct 21, 2016 at 12:45 AM, Internal Jenkins (Code Review) < ger...@cloudera.org> wrote: > Internal Jenkins has submitted this change and it was merged. > > Change subject: IMPALA-4325: StmtRewrite lost parentheses of > CompoundPredicate >

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-21 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 5: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4753 To

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Internal Jenkins (Code Review)
Internal Jenkins has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 4: Verified-1 Build failed:

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Great, thanks! I'll get this merged for you. -- To view, visit

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Yes, I have walk around other planner tests in this file(but not other files), and

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 4: Code-Review+2 rebased -- To view, visit http://gerrit.cloudera.org:8080/4753 To

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Code-Review+2 Did you check whether the expected output of other planner tests

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has uploaded a new patch set (#3). Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate StmtRewrite lost parentheses of

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-20 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 3: Thank you for your patience. -- To view, visit

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 2: (3 comments) Thanks for adding the test. Almost good to be merged.

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-19 Thread Yuanhao Luo (Code Review)
Yuanhao Luo has uploaded a new patch set (#2). Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate StmtRewrite lost parentheses of

[Impala-ASF-CR] IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate

2016-10-19 Thread Alex Behm (Code Review)
Alex Behm has posted comments on this change. Change subject: IMPALA-4325: StmtRewrite lost parentheses of CompoundPredicate .. Patch Set 1: (1 comment) Thanks for finding and fixing this! Let me know if you have trouble with