[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6819 To unsubscribe, visit http

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. IMPALA-5245: fix ASAN buffer-allocator-test * Use the allocator_may_return_null=1 ASAN option so

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/546/ -- To view, visi

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6819 To unsubscribe, visit http://gerrit

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: I ran buffer-allocator-test locally with an ASAN build. I was able to reproduce the problem before t

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 2: Looks good. One last question - how did you test? -- To view, visit http://gerrit.cloudera.org:8080/681

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6819/1/be/src/runtime/bufferpool/system-allocator.cc

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. IMPALA-5245: fix ASAN buffer-allocator-test * Use the allocator_may_return_null=1 ASAN option so that the allocation

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Jim Apple (Code Review)
Jim Apple has posted comments on this change. Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. Patch Set 1: (1 comment) Thanks for fixing this! http://gerrit.cloudera.org:8080/#/c/6819/1/be/src/runtime/bufferpoo

[Impala-ASF-CR] IMPALA-5245: fix ASAN buffer-allocator-test

2017-05-08 Thread Tim Armstrong (Code Review)
Tim Armstrong has uploaded a new change for review. http://gerrit.cloudera.org:8080/6819 Change subject: IMPALA-5245: fix ASAN buffer-allocator-test .. IMPALA-5245: fix ASAN buffer-allocator-test * Use the allocator_may_retur