[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has submitted this change and it was merged. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. IMPALA-5275: Avoid printing status stack trace on hot paths Currently, creation o

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 3: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7449 To unsubsc

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Mostafa Mokhtar (Code Review)
Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7449/3//COMMIT_MSG Commit Message:

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/903/ -- T

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7449 To unsubscribe

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-20 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7449/2/be/src/common/status.cc Fil

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 2: Code-Review+1 (1 comment) Looks good, this should be a big improvement. There's an a

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 2: Code-Review+1 Looks good to me. Lets give Tim and/or Sailesh another chance to comme

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new patch set (#2). Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. IMPALA-5275: Avoid printing status stack trace on hot paths Currently, creation of a Status object

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-19 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: Yes I think never printing stacktraces for MemLimitExceeded() makes sense. We have o

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) > I think we should do this for MemLimitExceeded() too: > > Joe poi

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-server

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) This should be a good improvement! Just have a couple of comments. htt

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Tim Armstrong (Code Review)
Tim Armstrong has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: I think we should do this for MemLimitExceeded() too: Joe pointed out on IMPALA-5598

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-18 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7449/1/be/src/service/impala-serve

[Impala-ASF-CR] IMPALA-5275: Avoid printing status stack trace on hot paths

2017-07-17 Thread Bikramjeet Vig (Code Review)
Bikramjeet Vig has uploaded a new change for review. http://gerrit.cloudera.org:8080/7449 Change subject: IMPALA-5275: Avoid printing status stack trace on hot paths .. IMPALA-5275: Avoid printing status stack trace on hot pat