[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has submitted this change and it was merged. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. IMPALA-5529: Add additional function signatures for TRUNC() The following signatures to

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-29 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7450 To unsubscribe

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 7: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/7450 To unsubsc

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-29 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 7: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/958/ -- T

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/941/ -- To

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-27 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/941/ -- T

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Failure was unrelated, Henry filed IMPALA-5729 -- To view, visit http://gerrit.clo

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/937/ -- T

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7450 To unsubscribe

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 4: I think you need to rebase on the latest master -- To view, visit http://gerrit.cl

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 4: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 4: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/933/ -- T

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7450 To unsubscribe

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-26 Thread Kim Jin Chul (Code Review)
Hello Impala Public Jenkins, Matthew Jacobs, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7450 to look at the new patch set (#4). Change subject: IMPALA-5529: Add additional function signatures for TRUNC()

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7450/3/fe/src/test/java/org

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 3: Verified-1 Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7450/2/fe/src/test/java/org/apache/im

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 2: (2 comments) Thanks for all your reviews! http://gerrit.cloudera.org:8080/#/c/7450/2

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Impala Public Jenkins (Code Review)
Impala Public Jenkins has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 3: Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/906/ -- T

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 3: Code-Review+2 Thanks, Jinchul! -- To view, visit http://gerrit.cloudera.org:8080/7

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-21 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new patch set (#3). Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. IMPALA-5529: Add additional function signatures for TRUNC() The following signatures to be added: +--

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-20 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7450/2/fe/src/test/java/org

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-20 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 2: (1 comment) Thanks for doing this! Looks pretty good to me. Please make the 1 small

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-20 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new patch set (#2). Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. IMPALA-5529: Add additional function signatures for TRUNC() The following signatures to be added: +--

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-19 Thread Thomas Tauber-Marshall (Code Review)
Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 1: (1 comment) > (4 comments) > > Hi, > > Would you please review my cod

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has posted comments on this change. Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. Patch Set 1: (4 comments) Hi, Would you please review my code with comments? Thanks. I would like

[Impala-ASF-CR] IMPALA-5529: Add additional function signatures for TRUNC()

2017-07-18 Thread Kim Jin Chul (Code Review)
Kim Jin Chul has uploaded a new change for review. http://gerrit.cloudera.org:8080/7450 Change subject: IMPALA-5529: Add additional function signatures for TRUNC() .. IMPALA-5529: Add additional function signatures for TRUNC()