[GitHub] [incubator-iotdb] yuqi1129 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

yuqi1129 commented on pull request #1728: URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691600279 @jixuan1989 OK This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1728: [IOTDB-892] Replace fastjson with Gson

jixuan1989 commented on pull request #1728: URL: https://github.com/apache/incubator-iotdb/pull/1728#issuecomment-691597506 1. please notice the CI. 2. can you introduce more about what benefit we can get from this replacement? --

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

qiaojialin commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r486802944 ## File path: server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java ## @@ -273,6 +274,112 @@ public void

[GitHub] [incubator-iotdb] shutter-cp commented on a change in pull request #1642: In Session, the JDBC module can set the Boolean return data type to 0/1 or true/false.

shutter-cp commented on a change in pull request #1642: URL: https://github.com/apache/incubator-iotdb/pull/1642#discussion_r487178748 ## File path: service-rpc/src/main/java/org/apache/iotdb/rpc/Config.java ## @@ -0,0 +1,42 @@ +package org.apache.iotdb.rpc; + + +/** + * @autho

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

HTHou commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486737169 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/MTree.java ## @@ -1002,55 +1008,74 @@ private void findNodes(MNode node, PartialPath

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

mychaow commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486764762 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogWriter.java ## @@ -0,0 +1,350 @@ +/* + * Licensed to the Apache Softw

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

qiaojialin commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486791004 ## File path: docs/zh/SystemDesign/DataQuery/OrderByTimeQuery.md ## @@ -0,0 +1,190 @@ + + +# 按时间倒序查询 + +## 实现原理 + +倒序分为 3 个维度来实现，由内核层到用户层分别为: `

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1650: [IOTDB-848] support order by time asc/desc

sonarcloud[bot] commented on pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#issuecomment-690915826 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

liutaohua commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486789846 ## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithValueFilterDataSet.java ## @@ -122,13 +127,18 @@ protec

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

neuyilan commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486809083 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1486,7 +1485,11 @@ private TSStatus proc

[GitHub] [incubator-iotdb] HTHou commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

HTHou commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690877249 > please add the design doc. > @HTHou I'm working on it. It'll be available to share once it's finished.

[GitHub] [incubator-iotdb] Alima777 commented on pull request #1717: [IOTDB-881] Fix Double quotes bug in Align by device

Alima777 commented on pull request #1717: URL: https://github.com/apache/incubator-iotdb/pull/1717#issuecomment-690968732 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-iotdb] neuyilan commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

neuyilan commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691376996 The CI failed, please take a look This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-iotdb] yhwang-hbl closed pull request #1708: [IOTDB-877] fix prefix bug on show storage group and show devices

yhwang-hbl closed pull request #1708: URL: https://github.com/apache/incubator-iotdb/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-iotdb] LebronAl commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

LebronAl commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486860025 ## File path: session/src/main/java/org/apache/iotdb/session/SessionConnection.java ## @@ -0,0 +1,401 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

samperson1997 commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486799334 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogWriter.java ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iotdb] Genius-pig commented on pull request #1717: [IOTDB-881] Fix Double quotes bug in Align by device

Genius-pig commented on pull request #1717: URL: https://github.com/apache/incubator-iotdb/pull/1717#issuecomment-690856050 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iotdb] yuqi1129 commented on issue #1726: Refactor `SingleFileLogReader` iteraotor logic

yuqi1129 commented on issue #1726: URL: https://github.com/apache/incubator-iotdb/issues/1726#issuecomment-691144265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-iotdb] jixuan1989 commented on issue #1726: Refactor `SingleFileLogReader` iteraotor logic

jixuan1989 commented on issue #1726: URL: https://github.com/apache/incubator-iotdb/issues/1726#issuecomment-691141940 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1692: fix some importcsv tool bug

qiaojialin commented on a change in pull request #1692: URL: https://github.com/apache/incubator-iotdb/pull/1692#discussion_r486807081 ## File path: cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java ## @@ -378,7 +388,12 @@ private static String createOneSql(Map.Entry> entr

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1650: [IOTDB-848] support order by time asc/desc

sonarcloud[bot] removed a comment on pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#issuecomment-690034269 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-687038561 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-iotdb] haimeiguo commented on a change in pull request #1698: [IoTDB-850] check list user/role privilege

haimeiguo commented on a change in pull request #1698: URL: https://github.com/apache/incubator-iotdb/pull/1698#discussion_r487023608 ## File path: server/src/main/java/org/apache/iotdb/db/qp/physical/sys/AuthorPlan.java ## @@ -39,12 +39,13 @@ public class AuthorPlan extends

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690860711 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-690264150 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

samperson1997 commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691450276 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1727: [IOTDB-888] Refactor `SingleFileLogReader` iterator logic

jixuan1989 commented on pull request #1727: URL: https://github.com/apache/incubator-iotdb/pull/1727#issuecomment-691387514 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1727: [IOTDB-888] Refactor `SingleFileLogReader` iterator logic

jixuan1989 commented on a change in pull request #1727: URL: https://github.com/apache/incubator-iotdb/pull/1727#discussion_r487414891 ## File path: server/src/main/java/org/apache/iotdb/db/writelog/io/SingleFileLogReader.java ## @@ -53,54 +54,69 @@ private boolean fileCo

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1710: Supplement the document

HTHou commented on a change in pull request #1710: URL: https://github.com/apache/incubator-iotdb/pull/1710#discussion_r487362343 ## File path: docs/UserGuide/Operation Manual/DDL Data Definition Language.md ## @@ -41,14 +41,15 @@ Msg: org.apache.iotdb.exception.MetadataErrorEx

[GitHub] [incubator-iotdb] yhwang-hbl commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

yhwang-hbl commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691398624 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iotdb] haimeiguo commented on pull request #1722: [IOTDB-872] Use system timezone in CLI

haimeiguo commented on pull request #1722: URL: https://github.com/apache/incubator-iotdb/pull/1722#issuecomment-690951553 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1692: fix some importcsv tool bug

mychaow commented on a change in pull request #1692: URL: https://github.com/apache/incubator-iotdb/pull/1692#discussion_r486835735 ## File path: cross-tests/src/test/java/org/apache/iotdb/cross/tests/tools/importCsv/AbstractScript.java ## @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] [incubator-iotdb] HTHou merged pull request #1702: fix mem setting on windows when using 64-bit Java

HTHou merged pull request #1702: URL: https://github.com/apache/incubator-iotdb/pull/1702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

SilverNarcissus commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r486811407 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -706,8 +714,11 @@ public void

[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

JackieTien97 commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486749377 ## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithValueFilterDataSet.java ## @@ -122,13 +127,18 @@ pro

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-690976244 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-iotdb] HTHou commented on pull request #1722: [IOTDB-872] Use system timezone in CLI

HTHou commented on pull request #1722: URL: https://github.com/apache/incubator-iotdb/pull/1722#issuecomment-690938589 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

liutaohua commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486789846 ## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithValueFilterDataSet.java ## @@ -122,13 +127,18 @@ protec

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1650: [IOTDB-848] support order by time asc/desc

sonarcloud[bot] commented on pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#issuecomment-690857074 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

neuyilan commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486809083 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1486,7 +1485,11 @@ private TSStatus proc

[GitHub] [incubator-iotdb] yhwang-hbl commented on a change in pull request #1710: Supplement the document

yhwang-hbl commented on a change in pull request #1710: URL: https://github.com/apache/incubator-iotdb/pull/1710#discussion_r486747363 ## File path: docs/UserGuide/Operation Manual/DDL Data Definition Language.md ## @@ -309,6 +310,20 @@ IoTDB> unset ttl to root.ln After unse

[GitHub] [incubator-iotdb] Alima777 commented on pull request #1717: [IOTDB-881] Fix Double quotes bug in Align by device

Alima777 commented on pull request #1717: URL: https://github.com/apache/incubator-iotdb/pull/1717#issuecomment-690968732 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-iotdb] neuyilan commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

neuyilan commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691376996 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-iotdb] HTHou commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

HTHou commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690877249 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

[GitHub] [incubator-iotdb] yhwang-hbl closed pull request #1708: [IOTDB-877] fix prefix bug on show storage group and show devices

yhwang-hbl closed pull request #1708: URL: https://github.com/apache/incubator-iotdb/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

mychaow commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486736109 ## File path: server/src/main/java/org/apache/iotdb/db/writelog/io/LogWriter.java ## @@ -41,13 +42,26 @@ private IoTDBConfig config = IoTDBDesc

[GitHub] [incubator-iotdb] Genius-pig commented on pull request #1717: [IOTDB-881] Fix Double quotes bug in Align by device

Genius-pig commented on pull request #1717: URL: https://github.com/apache/incubator-iotdb/pull/1717#issuecomment-690856050 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

samperson1997 commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486799334 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogWriter.java ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

jt2594838 commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486728689 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1688,13 +1693,20 @@ private TSStatus fo

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

qiaojialin commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r486802944 ## File path: server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java ## @@ -273,6 +274,112 @@ public void

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

HTHou commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486726741 ## File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfigCheck.java ## @@ -203,6 +203,13 @@ public void checkConfig() throws IOExcepti

[GitHub] [incubator-iotdb] shutter-cp commented on a change in pull request #1642: In Session, the JDBC module can set the Boolean return data type to 0/1 or true/false.

shutter-cp commented on a change in pull request #1642: URL: https://github.com/apache/incubator-iotdb/pull/1642#discussion_r487178748 ## File path: service-rpc/src/main/java/org/apache/iotdb/rpc/Config.java ## @@ -0,0 +1,42 @@ +package org.apache.iotdb.rpc; + + +/** + * @autho

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

qiaojialin commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486748080 ## File path: docs/zh/UserGuide/Operation Manual/DML Data Manipulation Language.md ## @@ -156,6 +156,14 @@ select wf01.wt01.status,wf02.wt02.ha

[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1692: fix some importcsv tool bug

qiaojialin commented on a change in pull request #1692: URL: https://github.com/apache/incubator-iotdb/pull/1692#discussion_r486807081 ## File path: cli/src/main/java/org/apache/iotdb/tool/ImportCsv.java ## @@ -378,7 +388,12 @@ private static String createOneSql(Map.Entry> entr

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1650: [IOTDB-848] support order by time asc/desc

sonarcloud[bot] removed a comment on pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#issuecomment-690034269 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

sonarcloud[bot] removed a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-687038561 This is an automated message from the Apache Git Service. To respond to the message, plea

[GitHub] [incubator-iotdb] LebronAl edited a comment on pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

LebronAl edited a comment on pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#issuecomment-689985530 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iotdb] yuqi1129 commented on issue #1726: Refactor `SingleFileLogReader` iteraotor logic

yuqi1129 commented on issue #1726: URL: https://github.com/apache/incubator-iotdb/issues/1726#issuecomment-691144265 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [incubator-iotdb] haimeiguo commented on a change in pull request #1698: [IoTDB-850] check list user/role privilege

haimeiguo commented on a change in pull request #1698: URL: https://github.com/apache/incubator-iotdb/pull/1698#discussion_r486717423 ## File path: server/src/test/java/org/apache/iotdb/db/integration/IoTDBAuthorizationIT.java ## @@ -793,15 +793,19 @@ public void testListRoleP

[GitHub] [incubator-iotdb] sonarcloud[bot] removed a comment on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] removed a comment on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-690264150 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

samperson1997 commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691450276 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [incubator-iotdb] jixuan1989 commented on pull request #1727: [IOTDB-888] Refactor `SingleFileLogReader` iterator logic

jixuan1989 commented on pull request #1727: URL: https://github.com/apache/incubator-iotdb/pull/1727#issuecomment-691387514 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1727: [IOTDB-888] Refactor `SingleFileLogReader` iterator logic

jixuan1989 commented on a change in pull request #1727: URL: https://github.com/apache/incubator-iotdb/pull/1727#discussion_r487414891 ## File path: server/src/main/java/org/apache/iotdb/db/writelog/io/SingleFileLogReader.java ## @@ -53,54 +54,69 @@ private boolean fileCo

[GitHub] [incubator-iotdb] liukun4515 commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

liukun4515 commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690829483 please add the design doc. This is an automated message from the Apache Git Service. To respond to th

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #1710: Supplement the document

HTHou commented on a change in pull request #1710: URL: https://github.com/apache/incubator-iotdb/pull/1710#discussion_r487362343 ## File path: docs/UserGuide/Operation Manual/DDL Data Definition Language.md ## @@ -41,14 +41,15 @@ Msg: org.apache.iotdb.exception.MetadataErrorEx

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1692: fix some importcsv tool bug

mychaow commented on a change in pull request #1692: URL: https://github.com/apache/incubator-iotdb/pull/1692#discussion_r486835735 ## File path: cross-tests/src/test/java/org/apache/iotdb/cross/tests/tools/importCsv/AbstractScript.java ## @@ -0,0 +1,75 @@ +/* + * Licensed to

[GitHub] [incubator-iotdb] haimeiguo commented on pull request #1722: [IOTDB-872] Use system timezone in CLI

haimeiguo commented on pull request #1722: URL: https://github.com/apache/incubator-iotdb/pull/1722#issuecomment-690951553 This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[GitHub] [incubator-iotdb] yhwang-hbl commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

yhwang-hbl commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691398624 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [incubator-iotdb] HTHou merged pull request #1702: fix mem setting on windows when using 64-bit Java

HTHou merged pull request #1702: URL: https://github.com/apache/incubator-iotdb/pull/1702 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [incubator-iotdb] liukun4515 edited a comment on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

liukun4515 edited a comment on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690829483 please add the design doc. @HTHou This is an automated message from the Apache Git Service

[GitHub] [incubator-iotdb] mychaow commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

mychaow commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486736109 ## File path: server/src/main/java/org/apache/iotdb/db/writelog/io/LogWriter.java ## @@ -41,13 +42,26 @@ private IoTDBConfig config = IoTDBDesc

[GitHub] [incubator-iotdb] SilverNarcissus commented on a change in pull request #1693: [IOTDB-863]: add a switch to drop ouf-of-order data that is recognized by IoTDB

SilverNarcissus commented on a change in pull request #1693: URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r486811407 ## File path: server/src/main/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessor.java ## @@ -706,8 +714,11 @@ public void

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #460: [IOTDB-68] New shared-nothing cluster

sonarcloud[bot] commented on pull request #460: URL: https://github.com/apache/incubator-iotdb/pull/460#issuecomment-690976244 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=460&resolved=false&types=BUG) [](https:/

[GitHub] [incubator-iotdb] JackieTien97 commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

JackieTien97 commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486749377 ## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithValueFilterDataSet.java ## @@ -122,13 +127,18 @@ pro

[GitHub] [incubator-iotdb] HTHou commented on pull request #1722: [IOTDB-872] Use system timezone in CLI

HTHou commented on pull request #1722: URL: https://github.com/apache/incubator-iotdb/pull/1722#issuecomment-690938589 `org.apache.iotdb.jdbc.IoTDBConnectionTest.testGetTimeZone` failed, please take a look. :) This is an aut

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1650: [IOTDB-848] support order by time asc/desc

sonarcloud[bot] commented on pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#issuecomment-690857074 This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [incubator-iotdb] liutaohua commented on a change in pull request #1650: [IOTDB-848] support order by time asc/desc

liutaohua commented on a change in pull request #1650: URL: https://github.com/apache/incubator-iotdb/pull/1650#discussion_r486789846 ## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithValueFilterDataSet.java ## @@ -122,13 +127,18 @@ protec

[GitHub] [incubator-iotdb] yhwang-hbl commented on a change in pull request #1710: Supplement the document

yhwang-hbl commented on a change in pull request #1710: URL: https://github.com/apache/incubator-iotdb/pull/1710#discussion_r486747363 ## File path: docs/UserGuide/Operation Manual/DDL Data Definition Language.md ## @@ -309,6 +310,20 @@ IoTDB> unset ttl to root.ln After unse

[GitHub] [incubator-iotdb] neuyilan commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

neuyilan commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486809083 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1486,7 +1485,11 @@ private TSStatus proc

[GitHub] [incubator-iotdb] HTHou commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

HTHou commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690877249 > please add the design doc. > @HTHou I'm working on it. It'll be available to share once it's finished.

[GitHub] [incubator-iotdb] Alima777 commented on pull request #1717: [IOTDB-881] Fix Double quotes bug in Align by device

Alima777 commented on pull request #1717: URL: https://github.com/apache/incubator-iotdb/pull/1717#issuecomment-690968732 This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [incubator-iotdb] qiaojialin merged pull request #1720: [IOTDB-871] change port to rpc port in session

qiaojialin merged pull request #1720: URL: https://github.com/apache/incubator-iotdb/pull/1720 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [incubator-iotdb] neuyilan commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

neuyilan commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691376996 The CI failed, please take a look This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-iotdb] yhwang-hbl closed pull request #1708: [IOTDB-877] fix prefix bug on show storage group and show devices

yhwang-hbl closed pull request #1708: URL: https://github.com/apache/incubator-iotdb/pull/1708 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

samperson1997 commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r486721209 ## File path: server/src/main/java/org/apache/iotdb/db/conf/IoTDBConfigCheck.java ## @@ -203,6 +203,13 @@ public void checkConfig() throws I

[GitHub] [incubator-iotdb] Genius-pig commented on pull request #1717: [IOTDB-881] Fix Double quotes bug in Align by device

Genius-pig commented on pull request #1717: URL: https://github.com/apache/incubator-iotdb/pull/1717#issuecomment-690856050 Can you add support nested double quotes in `Path`? This is an automated message from the Apache Git

[GitHub] [incubator-iotdb] sonarcloud[bot] commented on pull request #1524: [IOTDB-776] Control the memory usage of flushing the memtable

sonarcloud[bot] commented on pull request #1524: URL: https://github.com/apache/incubator-iotdb/pull/1524#issuecomment-690860711 Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=1524&resolved=false&types=BUG) [](http

[GitHub] [incubator-iotdb] LebronAl commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

LebronAl commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486860025 ## File path: session/src/main/java/org/apache/iotdb/session/SessionConnection.java ## @@ -0,0 +1,401 @@ +/* + * Licensed to the Apache Software

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1691: [IOTDB-814] Cache and redirect distributed IoTDB's leader for write requests in IoTDB's client

jt2594838 commented on a change in pull request #1691: URL: https://github.com/apache/incubator-iotdb/pull/1691#discussion_r486728689 ## File path: cluster/src/main/java/org/apache/iotdb/cluster/server/member/MetaGroupMember.java ## @@ -1688,13 +1693,20 @@ private TSStatus fo

[GitHub] [incubator-iotdb] jt2594838 commented on a change in pull request #1698: [IoTDB-850] check list user/role privilege

jt2594838 commented on a change in pull request #1698: URL: https://github.com/apache/incubator-iotdb/pull/1698#discussion_r486717381 ## File path: server/src/main/java/org/apache/iotdb/db/qp/executor/PlanExecutor.java ## @@ -1116,14 +1125,26 @@ private ListDataSet executeList

[GitHub] [incubator-iotdb] yuqi1129 opened a new pull request #1728: [IOTDB-892] Replace fastjson with Gson

yuqi1129 opened a new pull request #1728: URL: https://github.com/apache/incubator-iotdb/pull/1728 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [incubator-iotdb] jixuan1989 commented on a change in pull request #1727: [IOTDB-888] Refactor `SingleFileLogReader` iterator logic

jixuan1989 commented on a change in pull request #1727: URL: https://github.com/apache/incubator-iotdb/pull/1727#discussion_r487414891 ## File path: server/src/main/java/org/apache/iotdb/db/writelog/io/SingleFileLogReader.java ## @@ -53,54 +54,69 @@ private boolean fileCo

[GitHub] [incubator-iotdb] yhwang-hbl commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

yhwang-hbl commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691460839 > > > The CI failed, please take a look > > > > > > I ran the server integration test locally and it was successful,Therefore, I think 1 failure check may b

[GitHub] [incubator-iotdb] samperson1997 commented on a change in pull request #1721: [IOTDB-868] fix comma bug for mlog

samperson1997 commented on a change in pull request #1721: URL: https://github.com/apache/incubator-iotdb/pull/1721#discussion_r487388298 ## File path: server/src/main/java/org/apache/iotdb/db/metadata/logfile/MLogWriter.java ## @@ -0,0 +1,340 @@ +/* + * Licensed to the Apache

[GitHub] [incubator-iotdb] samperson1997 commented on pull request #1723: [IOTDB-877] fix prefix bug on show storage group and show devices

samperson1997 commented on pull request #1723: URL: https://github.com/apache/incubator-iotdb/pull/1723#issuecomment-691450276 > > The CI failed, please take a look > > I ran the server integration test locally and it was successful,Therefore, I think 1 failure check may be due to un