Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577310909 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Try to fix timezone [iotdb]

2024-04-23 Thread via GitHub
sonarcloud[bot] commented on PR #12401: URL: https://github.com/apache/iotdb/pull/12401#issuecomment-2074096303 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Pipe: Added batch to schema snapshot execution in template activation and timeseries creation & Fixed the bug that the "CreateMultiTimeSeries" group with alias is not idempotent [iotdb]

2024-04-23 Thread via GitHub
SteveYurongSu merged PR #12380: URL: https://github.com/apache/iotdb/pull/12380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577222419 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/CompactionSchedulerWithFastPerformerTest.java: ## @@ -154,7 +154,7 @@

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-23 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2073942021 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577180788 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577175083 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577172088 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577167260 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Pipe: Fixed the bug that pure data transfer is forbidden when SchemaRegion is in Simple consensus [iotdb]

2024-04-23 Thread via GitHub
SteveYurongSu merged PR #12397: URL: https://github.com/apache/iotdb/pull/12397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] update Export/ImportDataTestIT [iotdb]

2024-04-23 Thread via GitHub
2b3c511 opened a new pull request, #12399: URL: https://github.com/apache/iotdb/pull/12399 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-04-23 Thread via GitHub
JackieTien97 commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1577089745 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

[PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-04-23 Thread via GitHub
liuminghui233 opened a new pull request, #12398: URL: https://github.com/apache/iotdb/pull/12398 see doc https://apache-iotdb.feishu.cn/docx/JiREdjYz3oBjrJxVozXcgs9inS1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-23 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2072746986 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576397733 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

[PR] Pipe: Fixed the bug that pure data transfer is forbidden when SchemaRegion is in Simple consensus [iotdb]

2024-04-23 Thread via GitHub
Caideyipi opened a new pull request, #12397: URL: https://github.com/apache/iotdb/pull/12397 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-23 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2072023828 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Fixed backup data backend running issues [iotdb]

2024-04-23 Thread via GitHub
CloudWise-Lukemiao merged PR #12396: URL: https://github.com/apache/iotdb/pull/12396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix effective ratio calculation method [iotdb]

2024-04-23 Thread via GitHub
OneSizeFitsQuorum merged PR #12394: URL: https://github.com/apache/iotdb/pull/12394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576047456 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576040934 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576037933 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/schema/ttl/TTLCache.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576029400 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/exception/TTLException.java: ## @@ -0,0 +1,38 @@ +/* + * Licensed to the Apache Software

Re: [PR] Fixed backup data backend running issues [iotdb]

2024-04-23 Thread via GitHub
CloudWise-Lukemiao closed pull request #12395: Fixed backup data backend running issues URL: https://github.com/apache/iotdb/pull/12395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Some region migration related work [iotdb]

2024-04-23 Thread via GitHub
OneSizeFitsQuorum merged PR #12376: URL: https://github.com/apache/iotdb/pull/12376 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576021262 ## iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonConfig.java: ## @@ -119,6 +119,9 @@ public class CommonConfig { */ private

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576020607 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576019303 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576014872 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576011751 ## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-common.properties: ## @@ -450,6 +450,25 @@ data_replication_factor=1 # Unit: ms #

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1576000190 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/compaction/settle/SettleCompactionRecoverTest.java: ## @@ -0,0 +1,1137 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575992167 ## iotdb-core/datanode/src/test/java/org/apache/iotdb/db/storageengine/dataregion/TsFileResourceProgressIndexTest.java: ## @@ -277,6 +278,7 @@ public void

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575990673 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

[PR] Fix effective ratio calculation method [iotdb]

2024-04-23 Thread via GitHub
HeimingZ opened a new pull request, #12394: URL: https://github.com/apache/iotdb/pull/12394 Use wal node disk size instead of wal manager total size. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575929452 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575918974 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575911991 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/SettleCompactionTask.java: ## @@ -0,0 +1,389 @@ +/* + *

Re: [I] [Bug] iotdb 压缩线程处理异常之后,会无限处理错误数据。手动删除对应的序列也没用 [iotdb]

2024-04-23 Thread via GitHub
lintao666 commented on issue #12360: URL: https://github.com/apache/iotdb/issues/12360#issuecomment-2071687177 升级到1.3.1之后,这个压缩路径处理 还是有些问题。路径中包含root 无法压缩,但是对应的时间序列是存在的,也可以查询到数据。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] Enhance estimatation of FI memory usage [iotdb]

2024-04-23 Thread via GitHub
codecov[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2071684287 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12393?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575827285 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ## @@ -283,30 +227,87 @@

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575818839 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/schema/DataNodeTTLCache.java: ## @@ -0,0 +1,111 @@ +/* + * Licensed to the

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575815531 ## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/TTLInfo.java: ## @@ -0,0 +1,166 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [rel/1.3] Fixed rest insertTablet http api lost data event [iotdb]

2024-04-23 Thread via GitHub
CloudWise-Lukemiao commented on PR #12386: URL: https://github.com/apache/iotdb/pull/12386#issuecomment-2071648982 http://127.0.0.1:18080/rest/v2/insertTablet When inserting with the following parameters, when there are duplicates in the timestamp and more than half of the values in the

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575802400 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Enhance estimatation of FI memory usage [iotdb]

2024-04-23 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2071616292 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575781065 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-23 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2071612225 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

[PR] Enhance estimatation of FI memory usage [iotdb]

2024-04-23 Thread via GitHub
lancelly opened a new pull request, #12393: URL: https://github.com/apache/iotdb/pull/12393 Pipelines can be organized into a tree structure. This PR is used to estimate the memory usage during the execution of a pipeline. Currently, it is assumed that in the most extreme cases, the child

Re: [PR] feature add iotdb backup [iotdb]

2024-04-23 Thread via GitHub
HTHou merged PR #12365: URL: https://github.com/apache/iotdb/pull/12365 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] fix: 下载换行样式 [iotdb-docs]

2024-04-23 Thread via GitHub
qiaojialin merged PR #225: URL: https://github.com/apache/iotdb-docs/pull/225 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed rest service insertTablet lost data event return SUCCESS_STATUS [iotdb]

2024-04-23 Thread via GitHub
CloudWise-Lukemiao commented on PR #12387: URL: https://github.com/apache/iotdb/pull/12387#issuecomment-2071548937 http://127.0.0.1:18080/rest/v2/insertTablet When inserting with the following parameters, when there are duplicates in the timestamp and more than half of the values in the

Re: [PR] Provide more precise info for exception during conf loading [iotdb]

2024-04-23 Thread via GitHub
OneSizeFitsQuorum merged PR #12382: URL: https://github.com/apache/iotdb/pull/12382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix: 下载换行样式 [iotdb-docs]

2024-04-23 Thread via GitHub
tongshs opened a new pull request, #225: URL: https://github.com/apache/iotdb-docs/pull/225 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] [Bug] insertTablet http api lost data event return SUCCESS_STATUS [iotdb]

2024-04-23 Thread via GitHub
CritasWang commented on issue #12375: URL: https://github.com/apache/iotdb/issues/12375#issuecomment-2071513726 https://github.com/apache/iotdb/pull/12387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575714841 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduleTaskManager.java: ## Review Comment:

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1575710663 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/memory/SystemInfo.java: ## Review Comment: Resolved. -- This is an automated

Re: [PR] Implementation of device TTL [iotdb]

2024-04-23 Thread via GitHub
shuwenwei commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1565391622 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/memory/SystemInfo.java: ## Review Comment: Method `addCompactionMemoryCost(