Re: [PR] Pipe: remove unnecessary fsync operations for file pieces' transferring [iotdb]

2024-04-24 Thread via GitHub
SteveYurongSu merged PR #12410: URL: https://github.com/apache/iotdb/pull/12410 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] update Export/ImportDataTestIT [iotdb]

2024-04-24 Thread via GitHub
2b3c511 commented on PR #12399: URL: https://github.com/apache/iotdb/pull/12399#issuecomment-2076287220 https://github.com/apache/iotdb/assets/43237967/5aab06c3-6da9-46a1-8838-74f0f0459cb1;> -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] update Export/ImportDataTestIT [iotdb]

2024-04-24 Thread via GitHub
2b3c511 commented on PR #12399: URL: https://github.com/apache/iotdb/pull/12399#issuecomment-2076280586 ![img_v3_02a9_58447371-e77d-4417-b347-dbabcb68450g](https://github.com/apache/iotdb/assets/43237967/71c00a3d-f876-420c-99eb-9187c00e)

Re: [PR] Change log level and opt error msg for source path of view is deleted [iotdb]

2024-04-24 Thread via GitHub
Beyyes merged PR #12409: URL: https://github.com/apache/iotdb/pull/12409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] [Bug] iotdb 压缩线程处理异常之后,会无限处理错误数据。手动删除对应的序列也没用 [iotdb]

2024-04-24 Thread via GitHub
lintao666 commented on issue #12360: URL: https://github.com/apache/iotdb/issues/12360#issuecomment-2076184512 [error.log](https://github.com/apache/iotdb/files/15102931/error.log) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[PR] Colin fix pipe snapshot parser. [iotdb]

2024-04-24 Thread via GitHub
shuolinl opened a new pull request, #12413: URL: https://github.com/apache/iotdb/pull/12413 In this pr: 1. auth model can create user with raw password in pipe. 2. fix pipe snapshot parser will lose aligned timeseries' tags and attributes. -- This is an automated message from the

Re: [PR] Pipe: remove unnecessary fsync operations for file pieces' transferring [iotdb]

2024-04-24 Thread via GitHub
codecov[bot] commented on PR #12410: URL: https://github.com/apache/iotdb/pull/12410#issuecomment-2075372608 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12410?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All

[PR] Pipe: Support partial insert [iotdb]

2024-04-24 Thread via GitHub
MiniSho opened a new pull request, #12412: URL: https://github.com/apache/iotdb/pull/12412 ## Description As title. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] Pipe: remove unnecessary fsync operations for file pieces' transferring [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12410: URL: https://github.com/apache/iotdb/pull/12410#issuecomment-2075270388 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Fix Concurrency Instability When IoTConsensus LogDispatcher Exits [iotdb]

2024-04-24 Thread via GitHub
BUAAserein opened a new pull request, #12411: URL: https://github.com/apache/iotdb/pull/12411 ## Description - Immediately check `Thread.interrupted()` for interrupts after `getBatch()` - Fix configuration logic in ReplicateTest -- This is an automated message from the Apache

Re: [PR] Implement new plan optimizer: AggregationPushDown [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12398: URL: https://github.com/apache/iotdb/pull/12398#issuecomment-2075084336 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Pipe: Two stage aggregate framework & count-point-processor plugin [iotdb]

2024-04-24 Thread via GitHub
SteveYurongSu merged PR #12328: URL: https://github.com/apache/iotdb/pull/12328 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pipe: refine procedure timeout message [iotdb]

2024-04-24 Thread via GitHub
SteveYurongSu merged PR #12402: URL: https://github.com/apache/iotdb/pull/12402 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Pipe: Two stage aggregate framework & count-point-processor plugin [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2074906017 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Change log level and opt error msg for source path of view is deleted [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12409: URL: https://github.com/apache/iotdb/pull/12409#issuecomment-2074802047 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Change log level and opt error msg for source path of view is deleted [iotdb]

2024-04-24 Thread via GitHub
JackieTien97 opened a new pull request, #12409: URL: https://github.com/apache/iotdb/pull/12409 1. chaneg the log level from error to warn when https://jira.infra.timecho.com:8443/browse/TIMECHODB-689 2. opt error msg for source path of view is deleted

[PR] Pipe: Added check for wal disable and ratis consensus when including insertNode in realtime mode in data transmission [iotdb]

2024-04-24 Thread via GitHub
Caideyipi opened a new pull request, #12407: URL: https://github.com/apache/iotdb/pull/12407 ## Description As the title said. This PR has: - [ ] been self-reviewed. - [ ] concurrent read - [ ] concurrent write - [

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2074631361 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Pipe: Fixed FileNotFoundException caused by processing files deleted by compaction & Changed the "isEmpty()" judgement to avoid "getDevice()" attempts to read from a deleted file when using f

2024-04-24 Thread via GitHub
SteveYurongSu merged PR #12405: URL: https://github.com/apache/iotdb/pull/12405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix IoTDBTimezoneIT [iotdb]

2024-04-24 Thread via GitHub
JackieTien97 merged PR #12401: URL: https://github.com/apache/iotdb/pull/12401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fix partition cache after region migration [iotdb]

2024-04-24 Thread via GitHub
OneSizeFitsQuorum merged PR #12404: URL: https://github.com/apache/iotdb/pull/12404 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed rest service insertTablet lost data event return SUCCESS_STATUS [iotdb]

2024-04-24 Thread via GitHub
HTHou merged PR #12387: URL: https://github.com/apache/iotdb/pull/12387 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Changed the ' [iotdb]

2024-04-24 Thread via GitHub
Caideyipi opened a new pull request, #12405: URL: https://github.com/apache/iotdb/pull/12405 ## Description ### Content1 ... ### Content2 ... ### Content3 ... This PR has: - [ ] been self-reviewed. - [ ]

Re: [PR] Fixed concurrency issues with RegionMigration thread pool [iotdb]

2024-04-24 Thread via GitHub
OneSizeFitsQuorum merged PR #12403: URL: https://github.com/apache/iotdb/pull/12403 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Fixed concurrency issues with RegionMigration thread pool [iotdb]

2024-04-24 Thread via GitHub
codecov[bot] commented on PR #12403: URL: https://github.com/apache/iotdb/pull/12403#issuecomment-2074323504 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12403?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report

Re: [PR] Pipe: Two stage aggregate counter [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12328: URL: https://github.com/apache/iotdb/pull/12328#issuecomment-2074309063 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Try to fix timezone [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12401: URL: https://github.com/apache/iotdb/pull/12401#issuecomment-2074257917 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

Re: [PR] Fixed concurrency issues with RegionMigration thread pool [iotdb]

2024-04-24 Thread via GitHub
sonarcloud[bot] commented on PR #12403: URL: https://github.com/apache/iotdb/pull/12403#issuecomment-2074256098 ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate

[PR] Pipe: refine procedure timeout message [iotdb]

2024-04-24 Thread via GitHub
DanielWang2035 opened a new pull request, #12402: URL: https://github.com/apache/iotdb/pull/12402 As title -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Pipe: distinguish between old and new process subtasks before and after stuck restart to avoid unexpected hashmap override and removal [iotdb]

2024-04-24 Thread via GitHub
SteveYurongSu merged PR #12400: URL: https://github.com/apache/iotdb/pull/12400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Implementation of device TTL [iotdb]

2024-04-24 Thread via GitHub
choubenson commented on PR #12122: URL: https://github.com/apache/iotdb/pull/12122#issuecomment-2074191685 > meta sync support The TTL synchronization between clusters is a relatively independent feature, which will be implemented in a subsequent new PR. -- This is an automated

Re: [PR] Implementation of device TTL [iotdb]

2024-04-24 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577350238 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ## @@ -483,6 +476,13 @@

Re: [PR] Try to fix timezone [iotdb]

2024-04-24 Thread via GitHub
codecov[bot] commented on PR #12401: URL: https://github.com/apache/iotdb/pull/12401#issuecomment-2074174843 ## [Codecov](https://app.codecov.io/gh/apache/iotdb/pull/12401?dropdown=coverage=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=apache) Report All

Re: [PR] Implementation of device TTL [iotdb]

2024-04-24 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577328532 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/utils/MultiTsFileDeviceIterator.java: ## @@ -578,7 +583,27 @@

Re: [PR] Implementation of device TTL [iotdb]

2024-04-24 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577328114 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/selector/impl/SettleSelectorImpl.java: ## @@ -0,0 +1,328 @@ +/* + *

Re: [PR] Implementation of device TTL [iotdb]

2024-04-24 Thread via GitHub
choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577311884 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/schema/source/DeviceSchemaSource.java: ## @@ -98,6 +100,8 @@ public void