Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-07 Thread via GitHub
JackieTien97 merged PR #12393: URL: https://github.com/apache/iotdb/pull/12393 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-07 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2098197224 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-07 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1592317226 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/MemoryMeasurable.java: ## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-07 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1592316379 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/LastQueryOperator.java: ## @@ -173,4 +178,15 @@ public long

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-07 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1592315583 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/UpdateLastCacheOperator.java: ## @@ -89,4 +94,14 @@ protected

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-07 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1592314017 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/OperatorTreeGenerator.java: ## @@ -2947,6 +2949,18 @@ public List

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
JackieTien97 commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590950784 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/last/LastQueryOperator.java: ## @@ -173,4 +178,15 @@ public long

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095302936 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095272672 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590580947 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590580899 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
lancelly commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1590580783 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-06 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095261780 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095186924 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-05-05 Thread via GitHub
sonarcloud[bot] commented on PR #12393: URL: https://github.com/apache/iotdb/pull/12393#issuecomment-2095107647 ## [![Quality Gate Failed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-failed-20px.png 'Quality Gate

Re: [PR] Enhance estimate of FI memory usage [iotdb]

2024-04-23 Thread via GitHub
JackieTien97 commented on code in PR #12393: URL: https://github.com/apache/iotdb/pull/12393#discussion_r1577089745 ## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java: ## @@ -209,6 +209,8 @@ public enum PlanNodeType {