[kudu-CR] block manager: various changes to disk space reservation checking

2016-10-24 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4831 to review the following change. Change subject: block_manager: various changes to disk space reservation checking

[kudu-CR] block manager: disk space checking everywhere

2016-10-24 Thread Adar Dembo (Code Review)
Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4832 to review the following change. Change subject: block_manager: disk space checking everywhere ..

[kudu-CR] rpc: support GSSAPI authentication

2016-10-24 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4763 to look at the new patch set (#4). Change subject: rpc: support GSSAPI authentication .. rpc: support GSSAPI

[kudu-CR] rpc: support GSSAPI authentication

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/CMakeLists.txt File

[kudu-CR] rpc: support GSSAPI authentication

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/rpc/sasl_helper.cc File

[kudu-CR] rpc: support GSSAPI authentication

2016-10-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/CMakeLists.txt File

[kudu-CR] rpc: support GSSAPI authentication

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/rpc/sasl_rpc-test.cc File

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add a design doc for rpc retry/failover semantics .. Add a design doc for rpc retry/failover semantics This adds the final version of the rpc

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics .. Patch Set 8: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/2642 To unsubscribe, visit

[kudu-CR] [util/crypto] certificate management (part 1)

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) .. Patch Set 5: (20 comments)

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle .. Patch Set 2: thanks for doing this. looks pretty good, just a minor nit. -- To

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle .. Patch Set 2: (1 comment)

[kudu-CR] [java client] Identify client-local TabletClients

2016-10-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [java client] Identify client-local TabletClients .. [java client] Identify client-local TabletClients This patch adds building blocks to enable

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 2: (44 comments) http://gerrit.cloudera.org:8080/#/c/4789/2//COMMIT_MSG Commit Message: Line 34: - Make SSL

[kudu-CR] KUDU-1611 - [python] Enable setting scanner selection policy

2016-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1611 - [python] Enable setting scanner selection policy .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] WIP: enable GSSAPI for servers

2016-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: enable GSSAPI for servers .. Patch Set 4: Code-Review+1 Looks good as a stopgap solution. -- To view, visit http://gerrit.cloudera.org:8080/4765 To

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: MiniKdc for Java .. MiniKdc for Java Change-Id: Ie24eaa94fae14ca91fb4fdd2deae1f9aec58438b Reviewed-on: http://gerrit.cloudera.org:8080/4788 Tested-by:

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: MiniKdc for Java .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe, visit

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-10-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2642 to look at the new patch set (#8). Change subject: Add a design doc for rpc retry/failover semantics .. Add a

[kudu-CR] Add support for reinsert encoding on delta files

2016-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has abandoned this change. Change subject: Add support for reinsert encoding on delta files .. Abandoned this got superceded by a new version -- To view, visit http://gerrit.cloudera.org:8080/4627 To

[kudu-CR] Add a design doc for rpc retry/failover semantics

2016-10-24 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add a design doc for rpc retry/failover semantics .. Patch Set 7: (11 comments)

[kudu-CR] [util/crypto] certificate management (part 1)

2016-10-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4799 to look at the new patch set (#5). Change subject: [util/crypto] certificate management (part 1) .. [util/crypto]

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Dan Burkert (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4788 to look at the new patch set (#4). Change subject: MiniKdc for Java .. MiniKdc for Java Change-Id:

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-100 make RLE encoder handle 64-bit integer.

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-100 make RLE encoder handle 64-bit integer. .. Patch Set 1: (6 comments) Are you planning on another patch which will enable the ability to use RLE for the

[kudu-CR] [util/crypto] certificate management (part 1)

2016-10-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4799 to look at the new patch set (#4). Change subject: [util/crypto] certificate management (part 1) .. [util/crypto]

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

2016-10-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4819 to look at the new patch set (#4). Change subject: KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

2016-10-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4819 to look at the new patch set (#5). Change subject: KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

[kudu-CR] block manager: consolidate data directory management

2016-10-24 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4793 to look at the new patch set (#2). Change subject: block_manager: consolidate data directory management ..

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: MiniKdc for Java .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

2016-10-24 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4800/1//COMMIT_MSG Commit

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-24 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 1: (2 comments)

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: MiniKdc for Java .. Patch Set 3: Code-Review+1 Looks OK to me but I'll defer to Alexey/JD. -- To view, visit http://gerrit.cloudera.org:8080/4788 To unsubscribe,

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4789/2/src/kudu/util/net/ssl_factory.cc File

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: MiniKdc for Java .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4788/2/java/kudu-client/src/test/java/org/apache/kudu/client/MiniKdc.java File

[kudu-CR] MiniKdc for Java

2016-10-24 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4788 to look at the new patch set (#3). Change subject: MiniKdc for Java .. MiniKdc for Java Change-Id:

[kudu-CR] KUDU-237 - Add support for REINSERT deltas in delta files

2016-10-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4819 to look at the new patch set (#3). Change subject: KUDU-237 - Add support for REINSERT deltas in delta files ..

[kudu-CR] KUDU-237 - Add support for REINSERT deltas in delta files

2016-10-24 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4819 to look at the new patch set (#2). Change subject: KUDU-237 - Add support for REINSERT deltas in delta files ..

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-24 Thread Anonymous Coward (Code Review)
g.kocu...@gmail.com has uploaded a new patch set (#2). Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle .. KUDU-1691 - [python] Replaced group varint encoding with bitshuffle GROUP_VARINT is

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-24 Thread Anonymous Coward (Code Review)
g.kocu...@gmail.com has abandoned this change. Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4797 To unsubscribe, visit

[kudu-CR] [util/crypto] first certificate management (part 1)

2016-10-24 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4799 to look at the new patch set (#2). Change subject: [util/crypto] first certificate management (part 1) ..

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

2016-10-24 Thread Anonymous Coward (Code Review)
g.kocu...@gmail.com has uploaded a new change for review. http://gerrit.cloudera.org:8080/4824 Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle .. KUDU-1691 - [python] Replaced group varint

[kudu-CR] KUDU-1648 - [python] Expose Setting of Range Partitions

2016-10-24 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4795 to look at the new patch set (#2). Change subject: KUDU-1648 - [python] Expose Setting of Range Partitions ..

[kudu-CR] [WIP]KUDU-1638 - [python] Add Alter Table Support

2016-10-24 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/4823 Change subject: [WIP]KUDU-1638 - [python] Add Alter Table Support .. [WIP]KUDU-1638 - [python] Add Alter Table Support The Python

[kudu-CR] KUDU-100 - make RLE encoder handle 64-bit integer type.

2016-10-24 Thread Haijie Hong (Code Review)
Haijie Hong has abandoned this change. Change subject: KUDU-100 - make RLE encoder handle 64-bit integer type. .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4821 To unsubscribe, visit

[kudu-CR] KUDU-100 - make RLE encoder handle 64-bit integer type.

2016-10-24 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4821 to look at the new patch set (#2). Change subject: KUDU-100 - make RLE encoder handle 64-bit integer type. ..

[kudu-CR] KUDU-100 - make RLE encoder handle 64-bit integer type.

2016-10-24 Thread Haijie Hong (Code Review)
Haijie Hong has uploaded a new change for review. http://gerrit.cloudera.org:8080/4821 Change subject: KUDU-100 - make RLE encoder handle 64-bit integer type. .. KUDU-100 - make RLE encoder handle 64-bit integer type. Fix