[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment)

[kudu-CR] TODO cleanup in TransactionManager

David Ribeiro Alves has submitted this change and it was merged. Change subject: TODO cleanup in TransactionManager .. TODO cleanup in TransactionManager This removes a couple of TODOs that were now wrong because we now have

[kudu-CR] block manager: consolidate data directory management

Todd Lipcon has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 4: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4793 To unsubscribe, visit

[kudu-CR] block manager: cosmetic changes to the LBM

Alexey Serbin has posted comments on this change. Change subject: block_manager: cosmetic changes to the LBM .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4847/2/src/kudu/util/pb_util.h File

[kudu-CR] TODO cleanup in TransactionManager

Todd Lipcon has posted comments on this change. Change subject: TODO cleanup in TransactionManager .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4826 To unsubscribe, visit

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT deltas in delta files .. Patch Set 7: I'm surprised you didn't need to make any changes to

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment)

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT deltas in delta files

Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT deltas in delta files .. Patch Set 7: (12 comments) A little nervous about the interaction of this with tablet

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (12 comments)

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#6). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] [util/crypto] certificate management (part 1)

Alexey Serbin has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) .. Patch Set 6: (6 comments)

[kudu-CR] block manager: better preallocation in log block manager

Adar Dembo has uploaded a new patch set (#2). Change subject: block_manager: better preallocation in log block manager .. block_manager: better preallocation in log block manager As has been discussed to death, the LBM's

[kudu-CR] block manager: disk space checking everywhere

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4832 to look at the new patch set (#3). Change subject: block_manager: disk space checking everywhere .. block_manager:

[kudu-CR] block manager: consolidate data directory management

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4793 to look at the new patch set (#4). Change subject: block_manager: consolidate data directory management ..

[kudu-CR] block manager: cosmetic changes to the LBM

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4847 to review the following change. Change subject: block_manager: cosmetic changes to the LBM ..

[kudu-CR] block manager: various changes to disk space reservation checking

Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4831 to look at the new patch set (#2). Change subject: block_manager: various changes to disk space reservation checking

[kudu-CR] block manager: disk space checking everywhere

Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4832 to look at the new patch set (#2). Change subject: block_manager: disk space checking everywhere

[kudu-CR] block manager: better preallocation in log block manager

Hello Mike Percy, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4848 to review the following change. Change subject: block_manager: better preallocation in log block manager

[kudu-CR] block manager: consolidate data directory management

Hello Mike Percy, Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4793 to look at the new patch set (#3). Change subject: block_manager: consolidate data directory management

[kudu-CR] block manager: various changes to disk space reservation checking

Adar Dembo has posted comments on this change. Change subject: block_manager: various changes to disk space reservation checking .. Patch Set 1: (6 comments)

[kudu-CR] block manager: consolidate data directory management

Adar Dembo has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4793/2/src/kudu/fs/data_dirs.cc File

[kudu-CR] [WIP]KUDU-1638 - [python] Add Alter Table Support

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4823 to look at the new patch set (#2). Change subject: [WIP]KUDU-1638 - [python] Add Alter Table Support ..

[kudu-CR] block manager: consolidate data directory management

Adar Dembo has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4793/2/src/kudu/fs/data_dirs.cc File

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

Jean-Daniel Cryans has uploaded a new patch set (#3). Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. KUDU-1715. Add a way to set ReplicaSelection to the java client This patch adds a

[kudu-CR] WIP [java client] Implement RPC tracing

Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 2: This is just a rebase on top of my other Java patches that I'm now depending on in this patch. --

[kudu-CR] [java client] Refactor all server info into a single class, add locality

Jean-Daniel Cryans has uploaded a new patch set (#3). Change subject: [java client] Refactor all server info into a single class, add locality .. [java client] Refactor all server info into a single class, add locality Having

[kudu-CR] WIP [java client] Implement RPC tracing

Jean-Daniel Cryans has uploaded a new patch set (#2). Change subject: WIP [java client] Implement RPC tracing .. WIP [java client] Implement RPC tracing First stab at getting traces in the Java client. This patch is using a

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 2: (7 comments)

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (12 comments)

[kudu-CR] Redirect krb5 stdout to SLF4j

Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4843 to review the following change. Change subject: Redirect krb5 stdout to SLF4j .. Redirect krb5 stdout to SLF4j

[kudu-CR] [java client] Refactor all server info into a single class, add locality

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 2: (4 comments)

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void .. KUDU-78. Fix pb_util functions which return bool to return Status or void

[kudu-CR] Redirect krb5 stdout to SLF4j

Todd Lipcon has posted comments on this change. Change subject: Redirect krb5 stdout to SLF4j .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4843 To unsubscribe, visit

[kudu-CR] [util/crypto] certificate management (part 1)

Alexey Serbin has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) .. Patch Set 5: (33 comments) Thank you for the review. Will post the updated version in a moment.

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 2: (5 comments)

[kudu-CR] Redirect krb5 stdout to SLF4j

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4843 to look at the new patch set (#2). Change subject: Redirect krb5 stdout to SLF4j .. Redirect krb5 stdout to SLF4j

[kudu-CR] [util/crypto] certificate management (part 1)

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4799 to look at the new patch set (#6). Change subject: [util/crypto] certificate management (part 1) .. [util/crypto]

[kudu-CR] block manager: various changes to disk space reservation checking

Todd Lipcon has posted comments on this change. Change subject: block_manager: various changes to disk space reservation checking .. Patch Set 1: (6 comments)

[kudu-CR] block manager: consolidate data directory management

Todd Lipcon has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4793/2/src/kudu/fs/data_dirs.cc File

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

Maxim Smyatkin has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/4800/3//COMMIT_MSG

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status or void

Hello Dinesh Bhat, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4800 to look at the new patch set (#4). Change subject: KUDU-78. Fix pb_util functions which return bool to return Status or void

[kudu-CR] KUDU-78. Fix pb util functions which return bool to return Status

Dinesh Bhat has posted comments on this change. Change subject: KUDU-78. Fix pb_util functions which return bool to return Status .. Patch Set 3: Code-Review+1 (1 comment) Nice cleanups, LGTM.

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

Adar Dembo has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 2: (3 comments) Would it be possible to test that we're actually scanning a

[kudu-CR] [java client] Refactor all server info into a single class, add locality

Dan Burkert has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 1: (5 comments)

[kudu-CR] WIP [java client] Implement RPC tracing

Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 1: (3 comments)

[kudu-CR] [java client] Refactor all server info into a single class, add locality

Jean-Daniel Cryans has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 2: > Removed the following votes: > > * Verified-1 by Kudu

[kudu-CR] Fix MiniKdc dtor crash

Dan Burkert has posted comments on this change. Change subject: Fix MiniKdc dtor crash .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4839 To unsubscribe, visit

[kudu-CR] Add krb5 dependency to Java README

Dan Burkert has submitted this change and it was merged. Change subject: Add krb5 dependency to Java README .. Add krb5 dependency to Java README I think it's a little premature to add it to installation.adoc, since it isn't

[kudu-CR] Fix MiniKdc dtor crash

Dan Burkert has submitted this change and it was merged. Change subject: Fix MiniKdc dtor crash .. Fix MiniKdc dtor crash The C++ MiniKdc had a bug that caused a CHECK failure when the dtor ran while stopped. Change-Id:

[kudu-CR] Add krb5 dependency to Java README

Dan Burkert has posted comments on this change. Change subject: Add krb5 dependency to Java README .. Patch Set 1: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/4840 To unsubscribe, visit

[kudu-CR] [tools] Manual recovery tools (part 1)

Adar Dembo has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 1: (32 comments) http://gerrit.cloudera.org:8080/#/c/4834/1/src/kudu/integration-tests/cluster_itest_util.cc

[kudu-CR] Add krb5 dependency to Java README

Jean-Daniel Cryans has posted comments on this change. Change subject: Add krb5 dependency to Java README .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4840 To unsubscribe, visit

[kudu-CR] Fix MiniKdc dtor crash

Adar Dembo has posted comments on this change. Change subject: Fix MiniKdc dtor crash .. Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4839/1/src/kudu/security/mini_kdc-test.cc File

[kudu-CR] Add krb5 dependency to Java README

Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4840 to review the following change. Change subject: Add krb5 dependency to Java README .. Add krb5 dependency to

[kudu-CR] [util/crypto] certificate management (part 1)

Dan Burkert has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4799/5/CMakeLists.txt File CMakeLists.txt: PS5,

[kudu-CR] [java client] Refactor all server info into a single class, add locality

Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4836 to look at the new patch set (#2). Change subject: [java client] Refactor all server info into a single class, add locality

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/4837 Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. KUDU-1715. Add a way to set ReplicaSelection to

[kudu-CR] KUDU-1691 - [python] Replaced group varint encoding with bitshuffle

Jordan Birdsell has posted comments on this change. Change subject: KUDU-1691 - [python] Replaced group varint encoding with bitshuffle .. Patch Set 2: (3 comments) Good work greg, just some small things. Thanks for the

[kudu-CR] [tools] Manual recovery tools (part 1)

Hello Mike Percy, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4834 to review the following change. Change subject: [tools] Manual recovery tools (part 1) ..