[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-26 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Will Berkeley, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4852 to review the following change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-26 Thread Dinesh Bhat (Code Review)
Hello Jean-Daniel Cryans, Will Berkeley, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4852 to look at the new patch set (#2). Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

[kudu-CR] KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc

2016-10-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1566: [scripts] Update jira fields automatically with gerrit link, commit SHA etc .. Patch Set 2: (12 comments) http://gerrit.cloudera.org:8080/#/c/4852/2

[kudu-CR] [util/crypto] certificate management (part 1)

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [util/crypto] certificate management (part 1) .. Patch Set 6: (16 comments) Thank you for the review. I'll post new version shortly. http://gerrit.cloudera.or

[kudu-CR] [util/crypto] certificate management (part 1)

2016-10-26 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4799 to look at the new patch set (#7). Change subject: [util/crypto] certificate management (part 1) .. [util/crypto] c

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4791/5/src/kudu/tablet/compact

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#3). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with Ope

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 2: (83 comments) Thanks Dan, Alexey and Todd. I've made the changes. Sorry for the delay. http://gerrit.cloudera

[kudu-CR] block manager: cosmetic changes to the LBM

2016-10-26 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: block_manager: cosmetic changes to the LBM .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4847/2/src/kudu/util/pb_util.h File src/kudu/util/pb_uti

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-10-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4791/5/src/kudu/tablet

[kudu-CR] rpc: support GSSAPI authentication

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/4763/4/src/kudu/security/mini_kdc-test.cc File src/kudu/secu

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-10-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4791/5/src/kudu/tablet

[kudu-CR] rpc: support GSSAPI authentication

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: support GSSAPI authentication .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/4763/3/src/kudu/security/mini_kdc.cc File src/kudu/security/m

[kudu-CR] KUDU-1715. Add a way to set ReplicaSelection to the java client

2016-10-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1715. Add a way to set ReplicaSelection to the java client .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4837/2/java/

[kudu-CR] block manager: cosmetic changes to the LBM

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: block_manager: cosmetic changes to the LBM .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4847 To unsubscribe, visit http://ger

[kudu-CR] [java client] Refactor all server info into a single class, add locality

2016-10-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [java client] Refactor all server info into a single class, add locality .. Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/4836/3/java/kud

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4791/5/src/kudu/tablet/compact

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-10-26 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts .. Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/4791/5/src/kudu/tablet

[kudu-CR] rpc: improve error messages and logging for bad authentication

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: improve error messages and logging for bad authentication .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/4764/4/src/kudu/rpc/sasl_client.

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 3: (6 comments) http://gerrit.cloudera.org:8080/#/c/4789/3/src/kudu/rpc/reactor.cc File src/kudu/rpc/reactor.cc:

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4789 to look at the new patch set (#4). Change subject: KuduRPC integration with OpenSSL .. KuduRPC integration with Ope

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 2: (3 comments) so far looks good, just a couple of additional nits. http://gerrit.cloudera.org:8080/#/c/4

[kudu-CR] WIP [java client] Implement RPC tracing

2016-10-26 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Implement RPC tracing .. Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/4781/2/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc File src/kudu/rpc/connection

[kudu-CR] block manager: consolidate data directory management

2016-10-26 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: block_manager: consolidate data directory management .. Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/4793/4/src/kudu/fs/data_dirs.cc File src/kud

[kudu-CR] KuduRPC integration with OpenSSL

2016-10-26 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KuduRPC integration with OpenSSL .. Patch Set 4: (24 comments) http://gerrit.cloudera.org:8080/#/c/4789/4/src/kudu/rpc/connection.cc File src/kudu/rpc/connection.

[kudu-CR] KUDU-1690 - [python] Enable setting of default values

2016-10-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1690 - [python] Enable setting of default values .. Patch Set 3: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4818 To unsubscribe, visit

[kudu-CR] WIP: enable GSSAPI for servers

2016-10-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: WIP: enable GSSAPI for servers .. Patch Set 4: Code-Review+1 (3 comments) Just trying to follow along with security stuff a bit...feel free to disregard commen

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4760/3/python/kudu/client.pyx Fi

[kudu-CR] KUDU-1680 - [python] Improve PartialRow Usability

2016-10-26 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-1680 - [python] Improve PartialRow Usability .. Patch Set 3: -Code-Review -- To view, visit http://gerrit.cloudera.org:8080/4760 To unsubscribe, visit http