[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#10). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4929 to look at the new patch set (#3). Change subject: WIP KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#9). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#10). Change subject: [tools] Manual recovery tools (part 1)

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 2: (1 comment) I think as long as we upgrade in step with Impala, we shouldn't have any backwards

[kudu-CR] [OpenSSL] require at least 1.0.1 version

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [OpenSSL] require at least 1.0.1 version .. Patch Set 2: > Yea, I think we need to build against RHEL6.4's OpenSSL. (I have > the local hack necessary to use

[kudu-CR] rpc: add basic service and method-level authorization

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: rpc: add basic service and method-level authorization .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4897/1/src/kudu/rpc/protoc-gen-krpc.cc

[kudu-CR] [OpenSSL] require at least 1.0.1 version

2016-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [OpenSSL] require at least 1.0.1 version .. Patch Set 2: Yea, I think we need to build against RHEL6.4's OpenSSL. (I have the local hack necessary to use the

[kudu-CR] [OpenSSL] require at least 1.0.1 version

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [OpenSSL] require at least 1.0.1 version .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4937/1/CMakeLists.txt File CMakeLists.txt: Line 833:

[kudu-CR] [OpenSSL] require at least 1.0.1 version

2016-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [OpenSSL] require at least 1.0.1 version .. Patch Set 1: (1 comment) But el6.4 ships with 1.0.0, which I think we intend to build against (since it's the last

[kudu-CR] [OpenSSL] require at least 1.0.1 version

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4937 Change subject: [OpenSSL] require at least 1.0.1 version .. [OpenSSL] require at least 1.0.1 version To build the project, it's

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-03 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Add KuduTable.getFormattedRangePartitions method .. Patch Set 2: (1 comment) Just passing through; not a real review. Logistically, what needs to happen in order

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 9: (14 comments) http://gerrit.cloudera.org:8080/#/c/4834/6/src/kudu/integration-tests/cluster_itest_util.h

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2016-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] added TlsServer and TlsClient wrappers .. Patch Set 3: sure, I'd support moving minikdc into security/test/ (to correspond to the security-test cmake

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2016-11-03 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4926 to look at the new patch set (#3). Change subject: [security] added TlsServer and TlsClient wrappers .. [security]

[kudu-CR] [java client] Implement RPC tracing, part 1

2016-11-03 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java client] Implement RPC tracing, part 1 .. Patch Set 5: (1 comment)

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-03 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4934 to look at the new patch set (#2). Change subject: Add KuduTable.getFormattedRangePartitions method .. Add

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] added TlsServer and TlsClient wrappers .. Patch Set 2: > These are just useful for tests, right? Maybe we should move them > into a security/test/

[kudu-CR] Add KuduTable.getFormattedRangePartitions method

2016-11-03 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Matthew Jacobs, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/4934 to review the following change. Change subject: Add KuduTable.getFormattedRangePartitions method

[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()

2016-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus() .. Patch Set 1: One question related to this: if we already have existing data

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2016-11-03 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] added TlsServer and TlsClient wrappers .. Patch Set 2: These are just useful for tests, right? Maybe we should move them into a security/test/

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. [kudu-spark] Clean up some build warnings from Scala 2.11 The new Spark 2.x with

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/4924 To

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4924/1/java/kudu-spark/pom.xml File

[kudu-CR] [kudu-spark] Clean up some build warnings from Scala 2.11

2016-11-03 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: [kudu-spark] Clean up some build warnings from Scala 2.11 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4924/1/java/kudu-spark/pom.xml

[kudu-CR] Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4928 Change subject: Make RowChangeListDecoder::RemoveColumnIdsFromChangeList() take a RowChangeListEncoder as an out param .. Make

[kudu-CR] KUDU-237 (part 4) - Account for reinserts in delta stats

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4932 Change subject: KUDU-237 (part 4) - Account for reinserts in delta stats .. KUDU-237 (part 4) - Account for reinserts in delta

[kudu-CR] KUDU-237 (part 1) - Support proper mutation encoding for reinserts

2016-11-03 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4791 to look at the new patch set (#7). Change subject: KUDU-237 (part 1) - Support proper mutation encoding for reinserts

[kudu-CR] WIP: KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4929 Change subject: WIP: KUDU-237 (part 2) - Make DeltaStore::CheckRowDeleted() return an enum .. WIP: KUDU-237 (part 2) - Make

[kudu-CR] KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus()

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4931 Change subject: KUDU-237 (part 3) - Transform RowSet::CheckRowPresent() in RowSet::GetRowStatus() .. KUDU-237 (part 3) -

[kudu-CR] Improve debuggability of the delta/compaction path

2016-11-03 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/4930 Change subject: Improve debuggability of the delta/compaction path .. Improve debuggability of the delta/compaction path This

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#9). Change subject: [tools] Manual recovery tools (part 1)

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: [tools] Manual recovery tools (part 1) .. Patch Set 8: (1 comment) Hi Mike, I have reworked the entire tablet-copy test to make it less convoluted and much

[kudu-CR] [tools] Manual recovery tools (part 1)

2016-11-03 Thread Dinesh Bhat (Code Review)
Hello Mike Percy, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4834 to look at the new patch set (#8). Change subject: [tools] Manual recovery tools (part 1)

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [security] added TlsServer and TlsClient wrappers .. [security] added TlsServer and TlsClient wrappers Added TlsServer and TlsClient classes as wrappers for

[kudu-CR] [security] added TlsServer and TlsClient wrappers

2016-11-03 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/4926 Change subject: [security] added TlsServer and TlsClient wrappers .. [security] added TlsServer and TlsClient wrappers Added TlsServer