Dan Burkert has posted comments on this change.

Change subject: Add KuduTable.getFormattedRangePartitions method
......................................................................


Patch Set 2:

(1 comment)

I think as long as we upgrade in step with Impala, we shouldn't have any 
backwards compat concerns.  This is completely client-side, so we won't need to 
support it forever.

http://gerrit.cloudera.org:8080/#/c/4934/2/java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java
File java/kudu-client/src/main/java/org/apache/kudu/util/StringUtil.java:

PS2, Line 27: 
org.apache.hadoop.hive.ql.parse.BaseSemanticAnalyzer.escapeSQLString
> Can you use a {@link} here so that it's possible to navigate to it in an ID
At least in IntelliJ this doesn't work because Hive isn't a dependency of the 
project.  Does it work in Eclipse?  If so I can add it.


-- 
To view, visit http://gerrit.cloudera.org:8080/4934
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9b263d2444314d46533191918833840e75b7ba7
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com>
Gerrit-HasComments: Yes

Reply via email to