[kudu-CR] KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp"

2016-11-25 Thread Maxim Smyatkin (Code Review)
Maxim Smyatkin has posted comments on this change. Change subject: KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp" .. Patch Set 2: > I'm not really sold on this being in pb_util, since it's used for > n

[kudu-CR] KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp"

2016-11-25 Thread Maxim Smyatkin (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5123 to look at the new patch set (#3). Change subject: KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp" .

[kudu-CR] tablet copy: Rename tablet copy session source files

2016-11-25 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5042 to look at the new patch set (#3). Change subject: tablet copy: Rename tablet copy session source files .. tablet c

[kudu-CR] cmake: Throw cmake error if unit test does not exist

2016-11-25 Thread Mike Percy (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5222 to review the following change. Change subject: cmake: Throw cmake error if unit test does not exist .. cmake: Throw cm

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 16: (7 comments) Overall LGTM, I didn't review the new tests yet though http://gerrit.clo

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files .. Patch Set 16: (7 comments) http://gerrit.cloudera.org:8080/#/c/4995/16/src/kudu/tablet/comp

[kudu-CR] KUDU-237 (part 2) - Add support for REINSERT in delta files

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4995 to look at the new patch set (#17). Change subject: KUDU-237 (part 2) - Add support for REINSERT in delta files ..

[kudu-CR] Reduce the number of batches in FuzzTest::TestFuzzHugeBatches

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5223 Change subject: Reduce the number of batches in FuzzTest::TestFuzzHugeBatches .. Reduce the number of batches in FuzzTest::TestFuzz

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4996 to look at the new patch set (#11). Change subject: Add snapshot scans to fuzz-itest .. Add snapshot scans to fuzz-

[kudu-CR] Add snapshot scans to fuzz-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add snapshot scans to fuzz-itest .. Patch Set 10: (10 comments) http://gerrit.cloudera.org:8080/#/c/4996/10//COMMIT_MSG Commit Message: PS10, Line 12: op

[kudu-CR] cmake: Throw cmake error if unit test does not exist

2016-11-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: cmake: Throw cmake error if unit test does not exist .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5222/1/CMakeLists.txt File CMakeLists.txt: L

[kudu-CR] KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp"

2016-11-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1634 (part 3). Changed tmp files' infix from ".tmp" to ".kudutmp" .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5123 To uns

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/4997 to look at the new patch set (#11). Change subject: Add Reinserts to tablet_history_gc-itest .. Add Reinserts to ta

[kudu-CR] Add Reinserts to tablet history gc-itest

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Add Reinserts to tablet_history_gc-itest .. Patch Set 10: (16 comments) http://gerrit.cloudera.org:8080/#/c/4997/10//COMMIT_MSG Commit Message: Line 17:

[kudu-CR] Change TabletHistoryGCITest back to manual flushes

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5224 Change subject: Change TabletHistoryGCITest back to manual flushes .. Change TabletHistoryGCITest back to manual flushes Mike foun

[kudu-CR] [WIP] try checkstyle excludes

2016-11-25 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new change for review. http://gerrit.cloudera.org:8080/5225 Change subject: [WIP] try checkstyle excludes .. [WIP] try checkstyle excludes Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e --

[kudu-CR] [WIP] try checkstyle excludes

2016-11-25 Thread Jordan Birdsell (Code Review)
Jordan Birdsell has uploaded a new patch set (#2). Change subject: [WIP] try checkstyle excludes .. [WIP] try checkstyle excludes Change-Id: I22e8dd001543fca7cdd5778fc8f461685071fe9e --- M java/pom.xml 1 file changed, 3 insertio

[kudu-CR] [WIP] try checkstyle excludes

2016-11-25 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5225 to look at the new patch set (#3). Change subject: [WIP] try checkstyle excludes .. [WIP] try checkstyle excludes

[kudu-CR] [WIP] try checkstyle excludes

2016-11-25 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5225 to look at the new patch set (#4). Change subject: [WIP] try checkstyle excludes .. [WIP] try checkstyle excludes

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5226 Change subject: Remove/downgrade a few very verbose useless log statements .. Remove/downgrade a few very verbose useless log state

[kudu-CR] [WIP] try checkstyle excludes

2016-11-25 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5225 to look at the new patch set (#5). Change subject: [WIP] try checkstyle excludes .. [WIP] try checkstyle excludes

[kudu-CR] Remove/downgrade a few very verbose useless log statements

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5226 to look at the new patch set (#2). Change subject: Remove/downgrade a few very verbose useless log statements .. Re

[kudu-CR] [build] - Suppress generated sources from checkstyle plugin

2016-11-25 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5225 to look at the new patch set (#6). Change subject: [build] - Suppress generated sources from checkstyle plugin .. [

[kudu-CR] [build] - Suppress generated sources from checkstyle plugin

2016-11-25 Thread Jordan Birdsell (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5225 to look at the new patch set (#7). Change subject: [build] - Suppress generated sources from checkstyle plugin .. [

[kudu-CR] c++11'ize CompactionInput descedants with 'override'

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5227 Change subject: c++11'ize CompactionInput descedants with 'override' .. c++11'ize CompactionInput descedants with 'override' Chang

[kudu-CR] Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5228 Change subject: Finish incomplete sentence in docs/design-docs/rpc-retry-and-failover.md .. Finish incomplete sentence in docs/des

[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior .. Patch Set 6: (11 comments) http://gerrit.cloudera.org:8080/#/c/5055/6//COMMIT_MSG Commit Messag

[kudu-CR] [WIP] Design doc for repeatable reads

2016-11-25 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5229 Change subject: [WIP] Design doc for repeatable reads .. [WIP] Design doc for repeatable reads This is not really a design doc, ju

[kudu-CR] KUDU-798 (part 1) - Unify leader/follower mvcc behavior

2016-11-25 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5055 to look at the new patch set (#7). Change subject: KUDU-798 (part 1) - Unify leader/follower mvcc behavior .. KUDU-

[kudu-CR] [build] - Suppress generated sources from checkstyle plugin

2016-11-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [build] - Suppress generated sources from checkstyle plugin .. Patch Set 7: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5225 To unsubscribe, v

[kudu-CR] [build] - Suppress generated sources from checkstyle plugin

2016-11-25 Thread Dan Burkert (Code Review)
Dan Burkert has submitted this change and it was merged. Change subject: [build] - Suppress generated sources from checkstyle plugin .. [build] - Suppress generated sources from checkstyle plugin The Maven Checkstyle plugin is

[kudu-CR] Disable checkstyle plugin on Jenkins

2016-11-25 Thread Dan Burkert (Code Review)
Dan Burkert has abandoned this change. Change subject: Disable checkstyle plugin on Jenkins .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/5209 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Ge