[kudu-CR] [jepen.kudu] some updates

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [jepen.kudu] some updates .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5500/2//COMMIT_MSG Commit Message: PS2, Line 7: epen > jepsen Done

[kudu-CR] [jepsen.kudu] some updates

2016-12-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5500 to look at the new patch set (#4). Change subject: [jepsen.kudu] some updates .. [jepsen.kudu] some updates Update

[kudu-CR] WIP: Kudu Jepsen Tests - Initial Commit

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: Kudu Jepsen Tests - Initial Commit .. Patch Set 1: This is David's patch originally available at: https://gerrit.cloudera.org/#/c/5492/ This patch appear

[kudu-CR] WIP [jepsen.kudu] run tests from clojure-maven-plugin

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: WIP [jepsen.kudu] run tests from clojure-maven-plugin .. WIP [jepsen.kudu] run tests from clojure-maven-plugin Changes to allow the jepsen Kudu tests to run from t

[kudu-CR] [jepsen.kudu] run tests from clojure-maven-plugin

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5551 Change subject: [jepsen.kudu] run tests from clojure-maven-plugin .. [jepsen.kudu] run tests from clojure-maven-plugin Changes to allow

[kudu-CR] WIP: Kudu Jepsen Tests - Initial Commit

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5550 Change subject: WIP: Kudu Jepsen Tests - Initial Commit .. WIP: Kudu Jepsen Tests - Initial Commit This patch contains the basic jepsen

[kudu-CR] [jepen.kudu] some updates

2016-12-19 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5500 to look at the new patch set (#3). Change subject: [jepen.kudu] some updates .. [jepen.kudu] some updates Updated

[kudu-CR] [spark] KUDU-1631 push down StringStartsWith filters

2016-12-19 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5461 to look at the new patch set (#3). Change subject: [spark] KUDU-1631 push down StringStartsWith filters .. [spark]

[kudu-CR] KUDU-1812: redact sensitive partition keys from logs

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1812: redact sensitive partition keys from logs .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/5548/1/src/kudu/client/meta_cache.cc File

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 1: OK it's looking good to me. I want to make a pass through the Java client myself and look at al

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5549 to look at the new patch set (#2). Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812:

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5549/1/java/kudu-client/src/main/java/or

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1812: don't log user data in the Java client .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5549/1/java/kudu-client/src/main/java/org/apach

[kudu-CR] KUDU-1812: redact sensitive partition keys from logs

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1812: redact sensitive partition keys from logs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5548 To unsubscribe, v

[kudu-CR] KUDU-1812: don't log user data in the Java client

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5549 Change subject: KUDU-1812: don't log user data in the Java client .. KUDU-1812: don't log user data in the Java client I manually i

[kudu-CR] KUDU-1812: redact sensitive partition keys from logs

2016-12-19 Thread Dan Burkert (Code Review)
Hello Jean-Daniel Cryans, Adar Dembo, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5548 to review the following change. Change subject: KUDU-1812: redact sensitive partition keys from logs ..

[kudu-CR] KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5488 To u

[kudu-CR] delete table test: improve test runtime in ASAN/TSAN

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: delete_table_test: improve test runtime in ASAN/TSAN .. delete_table_test: improve test runtime in ASAN/TSAN TestDeleteTableWhileScanInProgress was runn

[kudu-CR] delete table test: improve test runtime in ASAN/TSAN

2016-12-19 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: delete_table_test: improve test runtime in ASAN/TSAN .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5544 To unsubscribe, visit

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2016-12-19 Thread Haijie Hong (Code Review)
Haijie Hong has posted comments on this change. Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates .. Patch Set 11: (8 comments) > (8 comments) http://gerrit.cloudera.org:8080/#/c/5176/8/src/kudu/comm

[kudu-CR] KUDU-1643 Prune hash partitions based on IN-list predicates

2016-12-19 Thread Haijie Hong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5176 to look at the new patch set (#11). Change subject: KUDU-1643 Prune hash partitions based on IN-list predicates ..

[kudu-CR] Persistent cache support for NVM

2016-12-19 Thread Sarah Jelinek (Code Review)
Sarah Jelinek has posted comments on this change. Change subject: Persistent cache support for NVM .. Patch Set 21: Not sure I posted a reply before. No changes since 12/13. -- To view, visit http://gerrit.cloudera.org:8080/2

[kudu-CR] [delete table-test] parameterized DeleteTableWhileScanInProgress

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [delete_table-test] parameterized DeleteTableWhileScanInProgress .. Patch Set 2: Code-Review+2 lgtm modulo Will's nits -- To view, visit http://gerrit.cl

[kudu-CR](branch-1.2.x) spark: continue scanning after encountering empty batch

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: spark: continue scanning after encountering empty batch .. spark: continue scanning after encountering empty batch The Spark connector would previo

[kudu-CR](branch-1.2.x) spark: continue scanning after encountering empty batch

2016-12-19 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: spark: continue scanning after encountering empty batch .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5541 To unsubscribe

[kudu-CR] WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1369. client: fail over scans to a new replica if current replica is out-of-date .. Patch Set 1: anything in here you think we should still take

[kudu-CR] KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1760. Add test coverage of reading pre-REINSERT after ALTER .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5488/1/src/kudu/integrati

[kudu-CR] WIP: KUDU-1622. Stripe the ResultTracker to lessen contention

2016-12-19 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: KUDU-1622. Stripe the ResultTracker to lessen contention .. Patch Set 1: with your recent changes is striping still needed? -- To view, visit http:/

[kudu-CR] delete table test: improve test runtime in ASAN/TSAN

2016-12-19 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5544 to review the following change. Change subject: delete_table_test: improve test runtime in ASAN/TSAN .. delete_table

[kudu-CR] Fix flakiness in ToolTest.TestRemoteReplicaCopy

2016-12-19 Thread Todd Lipcon (Code Review)
Hello Dinesh Bhat, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5543 to review the following change. Change subject: Fix flakiness in ToolTest.TestRemoteReplicaCopy .. Fix fla

[kudu-CR] KUDU-699 followup: fix flakiness of raft consensus quorum-test

2016-12-19 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5542 to review the following change. Change subject: KUDU-699 followup: fix flakiness of raft_consensus_quorum-test .

[kudu-CR] dist test: set death signal on forked processes

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has abandoned this change. Change subject: dist_test: set death signal on forked processes .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/4330 To unsubscribe, visit http://gerrit.cloudera.org:8080/s

[kudu-CR] dist test: set death signal on forked processes

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: dist_test: set death signal on forked processes .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4330/1/build-support/dist_test.py File build-suppo

[kudu-CR] csd: add another path for KUDU HOME

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: csd: add another path for KUDU_HOME .. csd: add another path for KUDU_HOME Kudu is provided in the CDH parcel in some new versions of CDH, and the convent

[kudu-CR] KUDU-699. consensus: Peer::Close() should not block on outstanding requests

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-699. consensus: Peer::Close() should not block on outstanding requests .. KUDU-699. consensus: Peer::Close() should not block on outstanding requests

[kudu-CR] KUDU-699. consensus: Peer::Close() should not block on outstanding requests

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-699. consensus: Peer::Close() should not block on outstanding requests .. Patch Set 4: Code-Review+2 Carrying +2 after a trivial nit fix and rebase -- To v

[kudu-CR] threadpool: use move semantics where possible

2016-12-19 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5518 to look at the new patch set (#2). Change subject: threadpool: use move semantics where possible .. thr

[kudu-CR] threadpool: use move semantics where possible

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: threadpool: use move semantics where possible .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5518/1/src/kudu/util/threadpool.cc File src/kudu/uti

[kudu-CR] KUDU-699. consensus: Peer::Close() should not block on outstanding requests

2016-12-19 Thread Todd Lipcon (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5490 to look at the new patch set (#4). Change subject: KUDU-699. consensus: Peer::Close() should not block on outstanding requests

[kudu-CR] threadpool: avoid calling task destructors while holding lock

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: threadpool: avoid calling task destructors while holding lock .. threadpool: avoid calling task destructors while holding lock Currently, the ThreadPool c

[kudu-CR] threadpool: avoid calling task destructors while holding lock

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: threadpool: avoid calling task destructors while holding lock .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5517/1/src/kudu/util/threadpool.cc F

[kudu-CR] KUDU-699. consensus: Peer::Close() should not block on outstanding requests

2016-12-19 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-699. consensus: Peer::Close() should not block on outstanding requests .. Patch Set 3: (1 comment) OK, I looped the raft itest 1000 times in ASAN and consen