[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/5741/2//COMMIT_MSG Commit Message: PS2, Li

[kudu-CR] Control mutex stack walking in DEBUG mode with a gflag

2017-01-27 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5741 to look at the new patch set (#9). Change subject: Control mutex stack walking in DEBUG mode with a gflag .. Contro

[kudu-CR] [security] method to extract public part of RSA key

2017-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] method to extract public part of RSA key .. Patch Set 6: (7 comments) http://gerrit.cloudera.org:8080/#/c/5783/6/src/kudu/security/ca/cert_management

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type This adds a new timestamp type that matches Impala's. The new type can be used as a key and ha

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. Patch Set 1: I'm having a hard time testing it properly as I don't know how to set up a kerb

[kudu-CR] KUDU-1845: Kerberos client keytab should be periodically renewed

2017-01-27 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has uploaded a new change for review. http://gerrit.cloudera.org:8080/5820 Change subject: KUDU-1845: Kerberos client keytab should be periodically renewed .. KUDU-1845: Kerberos client keytab should be periodica

[kudu-CR] [security] do actual token signing/verification

2017-01-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] do actual token signing/verification .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5812/2/src/kudu/security/token_signing_key.cc File

[kudu-CR] [security] method to extract public part of RSA key

2017-01-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] method to extract public part of RSA key .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5783/6/src/kudu/security/crypto.cc File src/k

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] sign/verify data using RSA key pair .. Patch Set 6: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5805 To unsubscribe, visit http://g

[kudu-CR] [security] introduced crypto-test

2017-01-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] introduced crypto-test .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5798 To unsubscribe, visit http://gerrit.clouder

[kudu-CR] [security] method to extract public part of RSA key

2017-01-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] method to extract public part of RSA key .. Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/5783/6/src/kudu/security/ca/cert_management.c

[kudu-CR] [timestamp] Build and and add boost's date time lib

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5818 Change subject: [timestamp] Build and and add boost's date_time lib .. [timestamp] Build and and add boost's date_time lib Change-

[kudu-CR] WIP: Add a new TIMESTAMP type

2017-01-27 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5819 Change subject: WIP: Add a new TIMESTAMP type .. WIP: Add a new TIMESTAMP type This adds a new timestamp type that matches Impala'

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-27 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5808 to look at the new patch set (#2). Change subject: tls: hook up internal PKI system to TlsContext ..

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-27 Thread Mike Percy (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5620 to look at the new patch set (#25). Change subject: Add Google Breakpad support to Kudu .. Add Google Breakpad supp

[kudu-CR] Add Google Breakpad support to Kudu

2017-01-27 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: Add Google Breakpad support to Kudu .. Patch Set 21: (2 comments) http://gerrit.cloudera.org:8080/#/c/5620/21/src/kudu/util/minidump-test.cc File src/kudu/util/min

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-27 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tls: hook up internal PKI system to TlsContext .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5808/1/src/kudu/master/master_service.cc File src/k

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: tls: hook up internal PKI system to TlsContext .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/5808/1/src/kudu/master/master_service.cc File sr

[kudu-CR] Update Impala docs for upcoming Impala 2.8 release

2017-01-27 Thread Ambreen Kazi (Code Review)
Ambreen Kazi has posted comments on this change. Change subject: Update Impala docs for upcoming Impala 2.8 release .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5733/2/docs/kudu_impala_integration.adoc File

[kudu-CR] KUDU-1853. Tablet copy: Don't orphan blocks on failure

2017-01-27 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1853. Tablet copy: Don't orphan blocks on failure .. Patch Set 4: (2 comments) Looks good, though the test failures look real. http://gerrit.cloudera.org:808

[kudu-CR] [security] do actual token signing/verification

2017-01-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5812 to look at the new patch set (#2). Change subject: [security] do actual token signing/verification .. [security] do

[kudu-CR] tls: hook up internal PKI system to TlsContext

2017-01-27 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: tls: hook up internal PKI system to TlsContext .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5808/1//COMMIT_MSG Commit Message: Line 28: * Cha

[kudu-CR] [security] do actual signing/verify for tokens

2017-01-27 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5812 Change subject: [security] do actual signing/verify for tokens .. [security] do actual signing/verify for tokens Replaced temporary stub

[kudu-CR] WIP: KUDU-1713: add a client Partitioner API

2017-01-27 Thread Matthew Jacobs (Code Review)
Matthew Jacobs has posted comments on this change. Change subject: WIP: KUDU-1713: add a client Partitioner API .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5775/1/src/kudu/client/client.h File src/kudu/cli

[kudu-CR] [security] method to extract public part of RSA key

2017-01-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5783 to look at the new patch set (#6). Change subject: [security] method to extract public part of RSA key .. [security

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.clouder

[kudu-CR] KUDU-1831. Java client does not check if the primary key columns are specified first

2017-01-27 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1831. Java client does not check if the primary key columns are specified first .. KUDU-1831. Java client does not check if the primary key co

[kudu-CR] [security] introduced crypto-test

2017-01-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5798 to look at the new patch set (#5). Change subject: [security] introduced crypto-test .. [security] introduced crypt

[kudu-CR] [security] method to extract public part of RSA key

2017-01-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5783 to look at the new patch set (#5). Change subject: [security] method to extract public part of RSA key .. [security

[kudu-CR] [security] sign/verify data using RSA key pair

2017-01-27 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5805 to look at the new patch set (#5). Change subject: [security] sign/verify data using RSA key pair .. [security] sig