[kudu-CR] WIP: Add a new TIMESTAMP type

2017-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: WIP: Add a new TIMESTAMP type .. Patch Set 3: (44 comments) Addressed all comments on the TimestampValue class (posted in another patch). Remaining stuff

[kudu-CR] [timestamp] Add a new TimestampValue class to support the TIMESTAMP type

2017-02-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/5965 Change subject: [timestamp] Add a new TimestampValue class to support the TIMESTAMP type .. [timestamp] Add a new TimestampValue c

[kudu-CR] WIP [security] load/store public TSK in the system table

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#5). Change subject: WIP [security] load/store public TSK in the system table .. WIP

[kudu-CR] [client] retry operation in case of ServiceUnavailable

2017-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [client] retry operation in case of ServiceUnavailable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5964/1/src/kudu/client/client-internal.cc

[kudu-CR] [security] generate self-signed certs on server startup

2017-02-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5955 to look at the new patch set (#3). Change subject: [security] generate self-signed certs on server startup .. [secu

[kudu-CR] [client] retry operation in case of ServiceUnavailable

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [client] retry operation in case of ServiceUnavailable .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5964/1/src/kudu/client/client-internal.cc F

[kudu-CR] exactly once rpc-test: properly propagate sleep parameter

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: exactly_once_rpc-test: properly propagate sleep parameter .. exactly_once_rpc-test: properly propagate sleep parameter Change-Id: I043647661b1b1c83479b3c9

[kudu-CR] exactly once rpc-test: properly propagate sleep parameter

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: exactly_once_rpc-test: properly propagate sleep parameter .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5883 To unsubscribe, vis

[kudu-CR] [client] retry operation in case of ServiceUnavailable

2017-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5964 Change subject: [client] retry operation in case of ServiceUnavailable .. [client] retry operation in case of ServiceUnavailable Follow

[kudu-CR] [rpc] Assume existence of TlsContext during negotiation

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/5946 To unsubscribe, visit

[kudu-CR] [all types-itest] wait for catalog manager

2017-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/5963 Change subject: [all_types-itest] wait for catalog manager .. [all_types-itest] wait for catalog manager Before starting client requests

[kudu-CR] java: add TLS support

2017-02-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5949 to look at the new patch set (#4). Change subject: java: add TLS support .. java:

[kudu-CR] java: implement Channel Bindings

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: implement Channel Bindings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5953/2/java/kudu-client/src/main/java/org/apache/kudu/client/Nego

[kudu-CR] java: add TLS support

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: add TLS support .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5949/3/java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java

[kudu-CR] WIP [security] load/store public TSK in the system table

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#4). Change subject: WIP [security] load/store public TSK in the system table .. WIP

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#7). Change subject: [security] tailored TokenSigner for system catalog .. [security]

[kudu-CR] java: implement Channel Bindings

2017-02-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: implement Channel Bindings .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5953/2/java/kudu-client/src/main/java/org/apache/kudu/client/Nego

[kudu-CR] java: add TLS support

2017-02-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: add TLS support .. Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5949/3/java/kudu-client/src/main/java/org/apache/kudu/client/N

[kudu-CR] [java client] Limit the message size in Status

2017-02-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Limit the message size in Status .. Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/5956/1//COMMIT_MSG Commit Message: Line 16: With t

[kudu-CR] [rpc] Assume existence of TlsContext during negotiation

2017-02-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] Assume existence of TlsContext during negotiation .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5946/1/src/kudu/rpc/server_negotiation.cc

[kudu-CR] WIP: generate self-signed certs on server startup, remove server cert manager

2017-02-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5955 to look at the new patch set (#2). Change subject: WIP: generate self-signed certs on server startup, remove server_cert_manager ..

[kudu-CR] java: add TLS support

2017-02-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5949 to look at the new patch set (#3). Change subject: java: add TLS support .. java:

[kudu-CR] WIP: generate self-signed certs on server startup, remove server cert manager

2017-02-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: generate self-signed certs on server startup, remove server_cert_manager .. Patch Set 1: (6 comments) some nits so far. It seems you are working on revis

[kudu-CR] java: implement Channel Bindings

2017-02-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Jean-Daniel Cryans, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5953 to look at the new patch set (#2). Change subject: java: implement Channel Bindings ...

[kudu-CR] java: implement Channel Bindings

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: implement Channel Bindings .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5953/1/java/kudu-client/src/main/java/org/apache/kudu/client/Neg

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-02-09 Thread Sailesh Mukil (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5905 to look at the new patch set (#2). Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. KUDU

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-02-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 1: nope... doesn't ring a bell. I wouldn't let those block some perf testing, and then if we

[kudu-CR] KUDU-1865 (part 1): reduce some cross-thread allocations

2017-02-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: KUDU-1865 (part 1): reduce some cross-thread allocations .. Patch Set 1: > (2 comments) > > I found a couple of bugs, but there are still some memory leaks I

[kudu-CR] WIP [security] load/store public TSK in the system table

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#3). Change subject: WIP [security] load/store public TSK in the system table .. WIP

[kudu-CR] WIP [security] tailored TokenSigner for system catalog

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#6). Change subject: WIP [security] tailored TokenSigner for system catalog .. WIP [s

[kudu-CR] WIP [security] tailored TokenSigner for system catalog

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#5). Change subject: WIP [security] tailored TokenSigner for system catalog .. WIP [s

[kudu-CR] WIP [security] tailored TokenSigner for system catalog

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#4). Change subject: WIP [security] tailored TokenSigner for system catalog .. WIP [s

[kudu-CR] WIP [security] load/store public TSK in the system table

2017-02-09 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#2). Change subject: WIP [security] load/store public TSK in the system table .. WIP

[kudu-CR] KUDU-1866: Add request-side sidecars

2017-02-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 6: Rebased to include boost changes. -- To view, visit http://gerrit.cloudera.org:8080/5908 To unsubscribe,

[kudu-CR] KUDU-1866: Add request-side sidecars

2017-02-09 Thread Henry Robinson (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5908 to look at the new patch set (#5). Change subject: KUDU-1866: Add request-side sidecars .. KUDU-1866: Add request-s

[kudu-CR] KUDU-1866: Add request-side sidecars

2017-02-09 Thread Henry Robinson (Code Review)
Henry Robinson has posted comments on this change. Change subject: KUDU-1866: Add request-side sidecars .. Patch Set 4: (20 comments) http://gerrit.cloudera.org:8080/#/c/5908/4//COMMIT_MSG Commit Message: Line 7: KUDU-1866: [

[kudu-CR] tls socket: fix handling of syscall errors

2017-02-09 Thread Sailesh Mukil (Code Review)
Sailesh Mukil has posted comments on this change. Change subject: tls_socket: fix handling of syscall errors .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5954/1/src/kudu/security/tls_socket.cc File src/kudu/

[kudu-CR] java: implement Channel Bindings

2017-02-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: implement Channel Bindings .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/5953/1/java/kudu-client/src/main/java/org/apache/kudu/client/Neg

[kudu-CR] [java client] Limit the message size in Status

2017-02-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/5956 Change subject: [java client] Limit the message size in Status .. [java client] Limit the message size in Status We've seen cases w

[kudu-CR] tls socket: fix handling of syscall errors

2017-02-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: tls_socket: fix handling of syscall errors .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5954/1/src/kudu/security/tls_socket.cc File src/kudu/se

[kudu-CR] WIP: generate self-signed certs on server startup, remove server cert manager

2017-02-09 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5955 to review the following change. Change subject: WIP: generate self-signed certs on server startup, remove server_cert_manager .

[kudu-CR] tls socket: fix handling of syscall errors

2017-02-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/5954 to review the following change. Change subject: tls_socket: fix handling of syscall errors .. tls_socke