[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#16). Change subject: [security] tailored TokenSigner for system catalog

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] load/store public TSK in the system table .. Patch Set 13: (4 comments)

[kudu-CR] [security] leader master sends public TSKs to tservers

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] leader master sends public TSKs to tservers .. Patch Set 3: (2 comments)

[kudu-CR] WIP: java: fetch and adopt authn token and CA from master

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: WIP: java: fetch and adopt authn token and CA from master .. Patch Set 2: (3 comments)

[kudu-CR] java: support token authentication in negotiation

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: support token authentication in negotiation .. Patch Set 3: (6 comments) The truststore stuff is nasty, but I guess that's not surprising. All nits, code

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] load/store public TSK in the system table .. Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/5935/13/src/kudu/master/sys_catalog.h File

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] load/store public TSK in the system table .. Patch Set 13: (3 comments)

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#15). Change subject: [security] load/store public TSK in the system table ..

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] load/store public TSK in the system table .. Patch Set 13: (10 comments) > (4 comments) > > Now that I'm seeing the TSK deletion code alongside

[kudu-CR] [security] make Kudu CA issue certs valid for 10 years

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. Change subject: [security] make Kudu CA issue certs valid for 10 years .. [security] make Kudu CA issue certs valid for 10 years Set default expiration interval for

[kudu-CR] [security] make Kudu CA issue certs valid for 10 years

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] make Kudu CA issue certs valid for 10 years .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5984 To unsubscribe, visit

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 15: > Checkout server_base.h, it's grown a TokenVerifier field. In the master, > we'll want to

[kudu-CR] [security] leader master sends public TSKs to tservers

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] leader master sends public TSKs to tservers .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6065/1/src/kudu/master/master_service.cc

[kudu-CR] [security] leader master sends public TSKs to tservers

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] leader master sends public TSKs to tservers .. Patch Set 1: (3 comments)

[kudu-CR] [security] leader master sends public TSKs to tservers

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#3). Change subject: [security] leader master sends public TSKs to tservers .. [security] leader master sends public TSKs to tservers Leader master responds with list of public TSK

[kudu-CR] WIP: java: fetch and adopt authn token and CA from master

2017-02-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6054 to look at the new patch set (#2). Change subject: WIP: java: fetch and adopt authn token and CA from master ..

[kudu-CR] WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-02-17 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6066 to review the following change. Change subject: WIP KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR] [security] leader master sends public TSKs to tservers

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] leader master sends public TSKs to tservers .. Patch Set 1: (3 comments)

[kudu-CR] [security] leader master sends public TSKs to tservers

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6065 Change subject: [security] leader master sends public TSKs to tservers .. [security] leader master sends public TSKs to tservers Leader

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [security] load/store public TSK in the system table .. Patch Set 13: (4 comments) Now that I'm seeing the TSK deletion code alongside the insertion code, I think

[kudu-CR] KUDU-1601. Delete ancient UNDO delta blocks in the background

2017-02-17 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6063 Change subject: KUDU-1601. Delete ancient UNDO delta blocks in the background .. KUDU-1601. Delete ancient UNDO delta blocks in the

[kudu-CR] WIP: Delete ancient UNDO delta blocks in the background

2017-02-17 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: WIP: Delete ancient UNDO delta blocks in the background .. Patch Set 2: (7 comments) http://gerrit.cloudera.org:8080/#/c/4363/2/src/kudu/tablet/delta_tracker.cc

[kudu-CR] compaction: Flush tablet metadata before updating stores

2017-02-17 Thread Mike Percy (Code Review)
Mike Percy has abandoned this change. Change subject: compaction: Flush tablet metadata before updating stores .. Abandoned I am going to merge this into https://gerrit.cloudera.org/4363 for now -- To view, visit

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 3: I feel somewhat vindicated now:

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/5930/14/src/kudu/master/master.h File

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] load/store public TSK in the system table .. Patch Set 13: (6 comments)

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 14: (18 comments) http://gerrit.cloudera.org:8080/#/c/5930/14/src/kudu/master/master.cc File

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: On Slack there was a concern that this might break Eclipse, have you had a chance to test

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 8: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/7/src/kudu/security/tls_context.cc

[kudu-CR] KUDU-1493: Implement SchemaRelationProvider

2017-02-17 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1493: Implement SchemaRelationProvider .. Patch Set 5: (1 comment)

[kudu-CR] [security] make Kudu CA issue certs valid for 10 years

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5984 to look at the new patch set (#2). Change subject: [security] make Kudu CA issue certs valid for 10 years ..

[kudu-CR] [security] make Kudu CA issue certs valid for 10 years

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] make Kudu CA issue certs valid for 10 years .. Patch Set 1: (1 comment)

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/6055/7/src/kudu/security/tls_context.cc File

[kudu-CR] [security] add --rpc tls min protocol flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6059 to look at the new patch set (#4). Change subject: [security] add --rpc_tls_min_protocol flag .. [security] add

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6055 to look at the new patch set (#8). Change subject: [security] add --rpc_tls_ciphers flag .. [security] add

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/6055/7/src/kudu/security/tls_context.cc File

[kudu-CR] java: enable error-prone for java builds

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: enable error-prone for java builds .. Patch Set 2: > 23:08:57 [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-compiler-plugin:3.3:compile

[kudu-CR] java: enable error-prone for java builds

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: java: enable error-prone for java builds .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/4425 To unsubscribe, visit

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/6/src/kudu/security/tls_context.cc File

[kudu-CR] [security] security-flags

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6052 to look at the new patch set (#3). Change subject: [security] security-flags .. [security] security-flags This

[kudu-CR] [security] security-flags

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] security-flags .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/6052/2//COMMIT_MSG Commit Message: PS2, Line 20: A follow up commit

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 14: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5930 To unsubscribe, visit

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/5930/13/src/kudu/security/token_signer.cc

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#13). Change subject: [security] load/store public TSK in the system table ..

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#14). Change subject: [security] tailored TokenSigner for system catalog ..

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/6/src/kudu/security/tls_context.cc File

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/6055/6/src/kudu/security/tls_context.cc File

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6055 to look at the new patch set (#7). Change subject: [security] add --rpc_tls_ciphers flag .. [security] add

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc File

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 13: (4 comments) http://gerrit.cloudera.org:8080/#/c/5930/13/src/kudu/security/token_signer.cc

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6055 to look at the new patch set (#6). Change subject: [security] add --rpc_tls_ciphers flag .. [security] add

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6060/3/java/kudu_style.xml File

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: Verified+1 Todd fixed the test that failed. -- To view, visit

[kudu-CR] KUDU-1402. Ensure session.flush() returns an empty list

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1402. Ensure session.flush() returns an empty list .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6061 To

[kudu-CR] KUDU-1402. Ensure session.flush() returns an empty list

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: KUDU-1402. Ensure session.flush() returns an empty list .. KUDU-1402. Ensure session.flush() returns an empty list Adds a test to ensure that

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#13). Change subject: [security] tailored TokenSigner for system catalog ..

[kudu-CR] [security] security-flags

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [security] security-flags .. Patch Set 2: (2 comments) Just commenting on the overall approach; didn't look at the implementation.

[kudu-CR] [java client] Fix TestMiniKuduCluster flakiness

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: [java client] Fix TestMiniKuduCluster flakiness .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6058 To unsubscribe, visit

[kudu-CR] [java client] Fix TestMiniKuduCluster flakiness

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: [java client] Fix TestMiniKuduCluster flakiness .. [java client] Fix TestMiniKuduCluster flakiness Servers are now taking longer to start, and this test

[kudu-CR] KUDU-1844: /varz should not expose potentially sensitive configs

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: KUDU-1844: /varz should not expose potentially sensitive configs .. KUDU-1844: /varz should not expose potentially sensitive configs This adds a new flag

[kudu-CR] KUDU-1844: /varz should not expose potentially sensitive configs

2017-02-17 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1844: /varz should not expose potentially sensitive configs .. Patch Set 3: Code-Review+2 Verified+1 (1 comment) Yeah, that's a known flaky test. I can't

[kudu-CR] [security] load/store public TSK in the system table

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5935 to look at the new patch set (#11). Change subject: [security] load/store public TSK in the system table ..

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/5930 to look at the new patch set (#12). Change subject: [security] tailored TokenSigner for system catalog ..

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc File

[kudu-CR] [security] add --rpc tls min protocol flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6059 to look at the new patch set (#2). Change subject: [security] add --rpc_tls_min_protocol flag .. [security] add

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6055 to look at the new patch set (#5). Change subject: [security] add --rpc_tls_ciphers flag .. [security] add

[kudu-CR] [security] add --rpc tls min protocol flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_min_protocol flag .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6059/1/src/kudu/security/tls_context.cc File

[kudu-CR] KUDU-1402. Ensure session.flush() returns an empty list

2017-02-17 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6061 Change subject: KUDU-1402. Ensure session.flush() returns an empty list .. KUDU-1402. Ensure session.flush() returns an empty list Adds a

[kudu-CR] java: set max status error length to 32KB

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: java: set max status error length to 32KB .. java: set max status error length to 32KB The 256 byte error max made the error strings for traces

[kudu-CR] Minor updates to the installation from source docs

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Minor updates to the installation from source docs .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6041 To unsubscribe,

[kudu-CR] Minor updates to the installation from source docs

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: Minor updates to the installation from source docs .. Minor updates to the installation from source docs A few small changes for the various

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. Change subject: Fix checkstyle suppressions in submodule builds .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6060/1//COMMIT_MSG Commit Message: PS1, Line 7:

[kudu-CR] Fix checkstyle suppressions in submodule builds

2017-02-17 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6060 to look at the new patch set (#3). Change subject: Fix checkstyle suppressions in submodule builds .. Fix

[kudu-CR] Fix checkstlye suppressions in submodule builds

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Fix checkstlye suppressions in submodule builds .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6060/1//COMMIT_MSG Commit Message: PS1,

[kudu-CR] Fix checkstlye suppressions in submodule builds

2017-02-17 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new patch set (#2). Change subject: Fix checkstlye suppressions in submodule builds .. Fix checkstlye suppressions in submodule builds Removes the use of relative paths via “samedir=.” in the

[kudu-CR] Fix checkstlye suppressions in submodule builds

2017-02-17 Thread Grant Henke (Code Review)
Grant Henke has uploaded a new change for review. http://gerrit.cloudera.org:8080/6060 Change subject: Fix checkstlye suppressions in submodule builds .. Fix checkstlye suppressions in submodule builds Removes the use of

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6055 to look at the new patch set (#4). Change subject: [security] add --rpc_tls_ciphers flag

[kudu-CR] [security] add --rpc tls min protocol flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Todd Lipcon, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6059 to review the following change. Change subject: [security] add --rpc_tls_min_protocol flag ..

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc File

[kudu-CR] [java client] Fix TestMiniKuduCluster flakiness

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Hello Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6058 to review the following change. Change subject: [java client] Fix TestMiniKuduCluster flakiness .. [java client] Fix

[kudu-CR] Tag kerberos principal flag as unsafe

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Tag kerberos_principal flag as unsafe .. Patch Set 2: Code-Review+2 carrying +2 -- To view, visit http://gerrit.cloudera.org:8080/6036 To unsubscribe, visit

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc File

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: use new ConnectToMaster RPC with fallback .. java: use new ConnectToMaster RPC with fallback This changes the Java client from using

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (1 comment)

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6035 To unsubscribe, visit

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (1 comment)

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc File

[kudu-CR] java: use new ConnectToMaster RPC with fallback

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: use new ConnectToMaster RPC with fallback .. Patch Set 1: (2 comments)

[kudu-CR] [security] tailored TokenSigner for system catalog

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] tailored TokenSigner for system catalog .. Patch Set 11: (1 comment) http://gerrit.cloudera.org:8080/#/c/5930/11/src/kudu/security/token_signer.h File

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [security] add --rpc_tls_ciphers flag .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6055/3/src/kudu/security/tls_context.cc File

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: fix a missing lock in TabletClient .. java: fix a missing lock in TabletClient The recent synchronization changes introduced a race on the

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6050 To unsubscribe, visit

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6050 to look at the new patch set (#3). Change subject: java: fix a missing lock in TabletClient .. java: fix a missing

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 2: (1 comment)

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 2: (1 comment)

[kudu-CR] [security] add --rpc tls ciphers flag

2017-02-17 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6055 to look at the new patch set (#3). Change subject: [security] add --rpc_tls_ciphers flag .. [security] add

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 2: (1 comment)

[kudu-CR] java: refactor logic for fanning out master connection into a class

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: refactor logic for fanning out master connection into a class .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6028

[kudu-CR] KUDU-1888. java: fix handling of RPCs which fail before they are sent

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: KUDU-1888. java: fix handling of RPCs which fail before they are sent .. Patch Set 2: (1 comment)

[kudu-CR] java: fix a missing lock in TabletClient

2017-02-17 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix a missing lock in TabletClient .. Patch Set 2: (1 comment)

  1   2   >