Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6283
to review the following change.
Change subject: log: improve mt-log-test benchmark
..
log: improve mt-log-test
Hello David Ribeiro Alves,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6284
to review the following change.
Change subject: log: simplify log append code path, reduce contention
..
log:
David Ribeiro Alves has posted comments on this change.
Change subject: [catalog_manager] categorization of rw operation failures
..
Patch Set 11:
(1 comment)
I think the previous rev demonstrated that this is lacking coverage
Alexey Serbin has posted comments on this change.
Change subject: [catalog_manager] categorization of rw operation failures
..
Patch Set 10:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/6170/10/src/kudu/master/catalog_man
Hello Adar Dembo, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6170
to look at the new patch set (#11).
Change subject: [catalog_manager] categorization of rw operation failures
..
Alexey Serbin has submitted this change and it was merged.
Change subject: [util] fixed env_util-test.cc compilation on OS X
..
[util] fixed env_util-test.cc compilation on OS X
The prior version failed to compile on OS X with
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6281
to look at the new patch set (#3).
Change subject: subprocess: Don't require process-wide SIG_IGN for SIGPIPE
..
su
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6281
to look at the new patch set (#2).
Change subject: subprocess: Don't require process-wide SIG_IGN for SIGPIPE
..
su
Mike Percy has posted comments on this change.
Change subject: [util] fixed env_util-test.cc compilation on OS X
..
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6282
To unsubscribe, visit http:/
Alexey Serbin has uploaded a new patch set (#2).
Change subject: [util] fixed env_util-test.cc compilation on OS X
..
[util] fixed env_util-test.cc compilation on OS X
The prior version failed to compile on OS X with clang versi
Alexey Serbin has posted comments on this change.
Change subject: [util] fixed env_util-test.cc compilation on OS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6282/1/src/kudu/util/env_util-test.cc
File src
Mike Percy has posted comments on this change.
Change subject: [util] fixed env_util-test.cc compilation on OS X
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6282/1/src/kudu/util/env_util-test.cc
File src/ku
Alexey Serbin has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6282
Change subject: [util] fixed env_util-test.cc compilation on OS X
..
[util] fixed env_util-test.cc compilation on OS X
The prior version
Hello David Ribeiro Alves, Adar Dembo, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6281
to review the following change.
Change subject: subprocess: Don't require process-wide SIG_IGN for SIGPIPE
...
David Ribeiro Alves has uploaded a new patch set (#2).
Change subject: [exactly_once_rpc-test] Reduce flakyness of
TestExactlyOnceSemanticsGarbageCollection
..
[exactly_once_rpc-test] Reduce flakyness of
TestExactlyOnceSemantic
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6280
Change subject: [exactly_once_rpc-test] Reduce flakyness of
TestExactlyOnceSemanticsGarbageCollection
..
[exactly_once_rpc-test] R
Henry Robinson has posted comments on this change.
Change subject: KUDU-1866: Add request-side sidecars
..
Patch Set 8:
Test failures due to Java client incompatibility. Will have to rethink (and
probably revert) use of 64-bit
David Ribeiro Alves has submitted this change and it was merged.
Change subject: [ts_recovery-itest] Reduce flakyness of
TestCrashBeforeWriteLogSegmentHeader
..
[ts_recovery-itest] Reduce flakyness of TestCrashBeforeWriteLogSeg
David Ribeiro Alves has submitted this change and it was merged.
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Make ExternalDaemon::StartProcess() handle fault injection
Occasionally starting a k
Alexey Serbin has submitted this change and it was merged.
Change subject: [security] added TokenSigner::IsCurrentKeyValid() method
..
[security] added TokenSigner::IsCurrentKeyValid() method
Introduced TokenSigner::IsCurrentKe
Alexey Serbin has posted comments on this change.
Change subject: WIP [client] retry RPC if authn token expires
..
Patch Set 2:
After adding a test and trying to make it work, I figured out that some
substantial surgery is req
Mike Percy has posted comments on this change.
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6211
To unsubscribe, vis
Todd Lipcon has posted comments on this change.
Change subject: [ts_recovery-itest] Reduce flakyness of
TestCrashBeforeWriteLogSegmentHeader
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6279
David Ribeiro Alves has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6279
Change subject: [ts_recovery-itest] Reduce flakyness of
TestCrashBeforeWriteLogSegmentHeader
..
[ts_recovery-itest] Reduce flakyne
Henry Robinson has posted comments on this change.
Change subject: KUDU-1866: Add request-side sidecars
..
Patch Set 8:
(13 comments)
Thanks for the review!
http://gerrit.cloudera.org:8080/#/c/5908/8/src/kudu/rpc/rpc_controll
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5908
to look at the new patch set (#9).
Change subject: KUDU-1866: Add request-side sidecars
..
KUDU-1866: Add request-s
Todd Lipcon has posted comments on this change.
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Patch Set 9: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6211
To unsubscribe, vi
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6211
to look at the new patch set (#9).
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Ma
Hello David Ribeiro Alves, Jean-Daniel Cryans, Todd Lipcon, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6277
to look at the new patch set (#2).
Change subject: env: Add support for getting FS capacity
..
Hello Jean-Daniel Cryans, Adar Dembo, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6278
to review the following change.
Change subject: Reserve 1% of disk space by default
..
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6277
Change subject: env: Add support for getting FS capacity
..
env: Add support for getting FS capacity
We need a way to get FS capacity in a
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6211
to look at the new patch set (#8).
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Ma
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6276
Change subject: Ignore SIGPIPE earlier in startup process
..
Ignore SIGPIPE earlier in startup process
This change resolves a race during s
David Ribeiro Alves has posted comments on this change.
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Patch Set 7:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6211/6/src/kudu/integration-te
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6211
to look at the new patch set (#7).
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Ma
Dan Burkert has abandoned this change.
Change subject: Add test for implicit partitions
..
Abandoned
This is well covered by AlterTableTest::TestAddRangePartitionConflictExhaustive
--
To view, visit http://gerrit.cloudera.org
Mike Percy has submitted this change and it was merged.
Change subject: Reserve 1% of disk space by default
..
Reserve 1% of disk space by default
Many people are not aware that Kudu is able to reserve a certain amount
of space
Mike Percy has submitted this change and it was merged.
Change subject: env: Add support for getting FS capacity
..
env: Add support for getting FS capacity
We need a way to get FS capacity in a follow-up patch. This change add
Mike Percy has posted comments on this change.
Change subject: env: Add support for getting FS capacity
..
Patch Set 2:
Yeah I was thinking about adding ASSERT_EVENTUALLY as a macro, would be an
improvement. Anyway, as you say
David Ribeiro Alves has posted comments on this change.
Change subject: env: Add support for getting FS capacity
..
Patch Set 2: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc
Fi
Todd Lipcon has posted comments on this change.
Change subject: env: Add support for getting FS capacity
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/6255
To unsubscribe, visit http://gerrit.
Todd Lipcon has posted comments on this change.
Change subject: env: Add support for getting FS capacity
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc
File src/kudu/util/env-t
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1866: Add request-side sidecars
..
Patch Set 8:
(13 comments)
http://gerrit.cloudera.org:8080/#/c/5908/8/src/kudu/rpc/rpc_controller.cc
File src/kudu/rpc/rpc
David Ribeiro Alves has posted comments on this change.
Change subject: env: Add support for getting FS capacity
..
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6255/1/src/kudu/util/env-test.cc
File src/kudu/ut
Jean-Daniel Cryans has submitted this change and it was merged.
Change subject: KUDU-1897: disable Kerberos replay cache
..
KUDU-1897: disable Kerberos replay cache
Change-Id: Ifbce55a0b12682fdf69e7b2c361c6336495db64d
Reviewed-
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1897: disable Kerberos replay cache
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6274
To unsubscribe, visit http://gerrit.
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6274
Change subject: KUDU-1897: disable Kerberos replay cache
..
KUDU-1897: disable Kerberos replay cache
Change-Id: Ifbce55a0b12682fdf69e7b2c3
Andrew Wong has abandoned this change.
Change subject: WIP: KUDU-1908 Applying del/ins causes a crash
..
Abandoned
Could not reproduce bug, JIRA has been marked resolved to reflect this.
--
To view, visit http://gerrit.cloude
Dan Burkert has posted comments on this change.
Change subject: [catalog_manager] categorization of rw operation failures
..
Patch Set 10:
(10 comments)
http://gerrit.cloudera.org:8080/#/c/6170/10/src/kudu/master/catalog_manag
Dan Burkert has submitted this change and it was merged.
Change subject: KUDU-1897: disable Kerberos replay cache
..
KUDU-1897: disable Kerberos replay cache
Change-Id: Ifbce55a0b12682fdf69e7b2c361c6336495db64d
Reviewed-on: htt
Alexey Serbin has posted comments on this change.
Change subject: [catalog_manager] categorization of rw operation failures
..
Patch Set 10:
(1 comment)
OK, it seems I need to add some test coverage for the new scenarios.
htt
David Ribeiro Alves has posted comments on this change.
Change subject: [catalog_manager] categorization of rw operation failures
..
Patch Set 10:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/6170/10//COMMIT_MSG
Commit Mes
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1897: disable Kerberos replay cache
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6254
To unsubscribe, visit http://gerrit.
Dan Burkert has posted comments on this change.
Change subject: [security] added TokenSigner::IsCurrentKeyValid() method
..
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6246
To unsubscribe, visi
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/6254
to look at the new patch set (#3).
Change subject: KUDU-1897: disable Kerberos replay cache
..
KUDU-1897: disable K
Andrew Wong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6272
Change subject: WIP: KUDU-1908 Applying del/ins causes a crash
..
WIP: KUDU-1908 Applying del/ins causes a crash
Attempting to reproduce K
Mike Percy has submitted this change and it was merged.
Change subject: Ignore SIGPIPE earlier in startup process
..
Ignore SIGPIPE earlier in startup process
This change resolves a race during startup where we are not protecte
Mike Percy has posted comments on this change.
Change subject: Ignore SIGPIPE earlier in startup process
..
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6262/3/src/kudu/util/subprocess.cc
File src/kudu/util/sub
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
KUDU-1905 - Allow reinserts on pk only tables
Doing a reinsert to a table that has only primary key colum
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
KUDU-1905 - Allow reinserts on pk only tables
Doing a reinsert to a table that has only primary key colum
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6269
To unsubscribe, visit http://ge
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6270
To unsubscribe, visit http://ge
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6270
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
KUDU-1905 - Allow reinserts on pk only tables
Doing a reinsert to a table
Todd Lipcon has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6269
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
KUDU-1905 - Allow reinserts on pk only tables
Doing a reinsert to a table
Todd Lipcon has posted comments on this change.
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6258
To unsubscribe, visit http://ge
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1905 - Allow reinserts on pk only tables
..
KUDU-1905 - Allow reinserts on pk only tables
Doing a reinsert to a table that has only primary key colum
Todd Lipcon has posted comments on this change.
Change subject: Make ExternalDaemon::StartProcess() handle fault injection
..
Patch Set 6:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/6211/6/src/kudu/integration-tests/exte
Todd Lipcon has posted comments on this change.
Change subject: Ignore SIGPIPE earlier in startup process
..
Patch Set 3: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/6262/3/src/kudu/util/subprocess.cc
File sr
68 matches
Mail list logo