[kudu-CR](branch-1.3.x) KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923: rpc_encryption flag is not enforced The rpc_encryption flag wasn't being taken into account

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923: rpc_encryption flag is not enforced The rpc_encryption flag wasn't being taken into account

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6340 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 1: Code-Review+2 Had to manually cherry-pick against branch-1.3.x, but just a trivial conflict from

[kudu-CR](branch-1.3.x) KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6342 Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923: rpc_encryption flag is not enforced The rpc_encryption flag

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6340 to look at the new patch set (#6). Change subject: KUDU-1923: rpc_encryption flag is not enforced ..

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 5: Needed a rebase -- To view, visit http://gerrit.cloudera.org:8080/6340 To unsubscribe, visit

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6340 to look at the new patch set (#5). Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923:

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6340/4/src/kudu/rpc/client_negotiation.h File

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 5: > Not sure if Dan's working tonight so I'll address those nits on his > behalf (hoping to cut

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6340 To unsubscribe, visit

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 4: Not sure if Dan's working tonight so I'll address those nits on his behalf (hoping to cut the rc

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/6340/4/src/kudu/rpc/client_negotiation.h File

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 7: (9 comments)

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 7: (2 comments)

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 4: I think so. I'm having trouble testing locally because of OS X issues. -- To view, visit

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 4: Code-Review+2 lgtm, was that the issue that caused the test failures? -- To view, visit

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 7: (15 comments) I still need to look through the tests but here are some

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6340 to look at the new patch set (#4). Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923:

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 3: (1 comment) seems like a bunch of real test failures

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 3: (2 comments) added security-itest which disables encryption and authentication. Disabling

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6340 to look at the new patch set (#3). Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923:

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3 Change-Id: Ic974d1649859b202ecd2bd5d5eab5ffca3b8bcd8 Reviewed-on:

[kudu-CR](branch-1.3.x) docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6341 To unsubscribe, visit

[kudu-CR](branch-1.3.x) KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. KUDU-1824. KuduRDD.collect fails because of NoSerializableException The internal

[kudu-CR](branch-1.3.x) docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3 Change-Id: Ic974d1649859b202ecd2bd5d5eab5ffca3b8bcd8 Reviewed-on:

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 6: Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/6334 To unsubscribe, visit

[kudu-CR](branch-1.3.x) docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6341 Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3 Change-Id: Ic974d1649859b202ecd2bd5d5eab5ffca3b8bcd8

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1923: rpc_encryption flag is not enforced .. Patch Set 2: (2 comments) I think it's worth a spot check integration test in security-itest that we can run a

[kudu-CR] Update security-related TODOs

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Update security-related TODOs .. Update security-related TODOs heartbeater.cc: We decided not to implement rotation of the IPKI CA cert. This removes a

[kudu-CR] Update security-related TODOs

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Update security-related TODOs .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6337 To unsubscribe, visit

[kudu-CR] KUDU-1923: rpc encryption flag is not enforced

2017-03-09 Thread Dan Burkert (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6340 to look at the new patch set (#2). Change subject: KUDU-1923: rpc_encryption flag is not enforced .. KUDU-1923:

[kudu-CR] KUDU-1890 Allow renaming of primary key column

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1890 Allow renaming of primary key column .. Patch Set 8: (4 comments) http://gerrit.cloudera.org:8080/#/c/6078/8/src/kudu/common/schema-test.cc File

[kudu-CR](branch-1.3.x) KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6339 To

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 4: I think it would have if I'd used a SparkSQL "select count(*) ..." query, but

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#7). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR](branch-1.3.x) KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6339 Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. KUDU-1824. KuduRDD.collect fails because of

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/5636 To

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. KUDU-1824. KuduRDD.collect fails because of NoSerializableException The internal

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#6). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 6: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6334/5/docs/known_issues.adoc File

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 3: Oh really? I thought count() was smart enough to issue a column-less scan...

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/6334/5/docs/known_issues.adoc File docs/known_issues.adoc: PS5,

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 3: The count operation was pulling back all columns from Kudu in the table, is

[kudu-CR] Update security-related TODOs

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6337 to review the following change. Change subject: Update security-related TODOs .. Update

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 3: Any chance you can run a sum(l_linenumber) or sum(l_tax) as well? count() is

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/6334/5/docs/known_issues.adoc File docs/known_issues.adoc: PS5,

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 5: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6334 To unsubscribe, visit

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/6299/7//COMMIT_MSG Commit Message: Line 29:

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6299 to look at the new patch set (#7). Change subject: [consensus] add lock coverage for peer queue .. [consensus] add

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 5: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/6334 To unsubscribe, visit

[kudu-CR] KUDU-1824. KuduRDD.collect fails because of NoSerializableException

2017-03-09 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-1824. KuduRDD.collect fails because of NoSerializableException .. Patch Set 3: Just ran a big count job an a lineitem table, and this patch made it about

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6334 to look at the new patch set (#3). Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6334 to look at the new patch set (#4). Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 5: Code-Review+2 from my side. leaving it open if other folks want to look -- To view, visit

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6334 to look at the new patch set (#5). Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6334/1/docs/known_issues.adoc File docs/known_issues.adoc:

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6334 to look at the new patch set (#2). Change subject: docs: release notes for 1.3 .. docs: release notes for 1.3

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6334/1/docs/prior_release_notes.adoc File

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: docs: release notes for 1.3 .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6334/1/docs/prior_release_notes.adoc File

[kudu-CR] docs: release notes for 1.3

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Jean-Daniel Cryans, Mike Percy, Adar Dembo, Alexey Serbin, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6334 to review the following change. Change subject: docs: release notes for 1.3

[kudu-CR](branch-1.3.x) Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix RAT issues for 1.3 release .. Fix RAT issues for 1.3 release * x509_check_host.{cc,h} were moved from kudu/util to kudu/security. This updates the

[kudu-CR](branch-1.3.x) Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix RAT issues for 1.3 release .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6332 To unsubscribe, visit

[kudu-CR] WIP: Debugging TSK seq no non-monotonicity bug

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: WIP: Debugging TSK seq no non-monotonicity bug .. Patch Set 1: > Build Failed > > http://104.196.14.100/job/kudu-gerrit/6931/ : FAILURE I integrated these

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Dinesh Bhat (Code Review)
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas .. Patch Set 4: (7 comments)

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 26: > Build Successful > > http://104.196.14.100/job/kudu-gerrit/6937/ : SUCCESS 1024

[kudu-CR](branch-1.3.x) Change version to 1.3.0 (non-SNAPSHOT)

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Change version to 1.3.0 (non-SNAPSHOT) .. Change version to 1.3.0 (non-SNAPSHOT) Change-Id: Ibb599f932f2803f7e5cd1a2c4f6c534dd8dbec15 Reviewed-on:

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Fix RAT issues for 1.3 release .. Fix RAT issues for 1.3 release * x509_check_host.{cc,h} were moved from kudu/util to kudu/security. This updates the

[kudu-CR](branch-1.3.x) Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/6332 Change subject: Fix RAT issues for 1.3 release .. Fix RAT issues for 1.3 release * x509_check_host.{cc,h} were moved from kudu/util to

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 26: > Uploaded patch set 26. The race has gone:

[kudu-CR](branch-1.3.x) Change version to 1.3.0 (non-SNAPSHOT)

2017-03-09 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: Change version to 1.3.0 (non-SNAPSHOT) .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6331 To unsubscribe, visit

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread Alexey Serbin (Code Review)
Hello David Ribeiro Alves, Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6170 to look at the new patch set (#26). Change subject: [catalog_manager] categorization of rw operation failures

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix RAT issues for 1.3 release .. Patch Set 2: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6330 To unsubscribe, visit

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Fix RAT issues for 1.3 release .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6330/1//COMMIT_MSG Commit Message: PS1, Line 9: * Forgot to add

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6330 to look at the new patch set (#2). Change subject: Fix RAT issues for 1.3 release .. Fix RAT issues for 1.3

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix RAT issues for 1.3 release .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6330/1//COMMIT_MSG Commit Message: PS1, Line 9: * Forgot to add

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: Fix RAT issues for 1.3 release .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/6330/1/build-support/release/rat_exclude_files.txt File

[kudu-CR](branch-1.3.x) Change version to 1.3.0 (non-SNAPSHOT)

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6331 to review the following change. Change subject: Change version to 1.3.0 (non-SNAPSHOT) .. Change version to

[kudu-CR] Fix RAT issues for 1.3 release

2017-03-09 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/6330 to review the following change. Change subject: Fix RAT issues for 1.3 release .. Fix RAT issues

[kudu-CR] log: improve mt-log-test benchmark

2017-03-09 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: log: improve mt-log-test benchmark .. log: improve mt-log-test benchmark - builds the entries to be appended outside of holding any lock, which is more

[kudu-CR] [security] avoid sparse seq numbers in TokenSigner

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6329 Change subject: [security] avoid sparse seq numbers in TokenSigner .. [security] avoid sparse seq numbers in TokenSigner Changed the

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: Will try that out, so far, I'd just been using specific test cases with default threading. Found the

[kudu-CR] [consensus] add lock coverage for peer queue

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [consensus] add lock coverage for peer queue .. Patch Set 6: as a repro strategy I'd maybe try that test (and/or some others in raft_consensus-itest)

[kudu-CR] KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

2017-03-09 Thread Dinesh Bhat (Code Review)
Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6066 to look at the new patch set (#5). Change subject: KUDU-1330: Add a tool to unsafely recover from loss of majority replicas

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 25: you're right, the logs show that TSK skips a number. e.g. 23, 24, 26, 25 --

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 25: > I chased the bug. It's the following. Say node A is at term 10 and > is leader

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 25: > Sorry for the rebase. Did it to post a WIP of my debugging code: >

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 24: Sorry for the rebase. Did it to post a WIP of my debugging code:

[kudu-CR] WIP: Debugging TSK seq no non-monotonicity bug

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new change for review. http://gerrit.cloudera.org:8080/6327 Change subject: WIP: Debugging TSK seq no non-monotonicity bug .. WIP: Debugging TSK seq no non-monotonicity bug Change-Id:

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 24: > > > Given that we're still chasing strange test failures on this, > and > > >

[kudu-CR] [catalog manager] categorization of rw operation failures

2017-03-09 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: [catalog_manager] categorization of rw operation failures .. Patch Set 24: I chased the bug. It's the following. Say node A is at term 10 and is leader