[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-04-25 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6734 to look at the new patch set (#2). Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. KUDU-1981 K

[kudu-CR] KUDU-1981 Kudu should run at hosts len(FQDN) > 64

2017-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/6734 Change subject: KUDU-1981 Kudu should run at hosts len(FQDN) > 64 .. KUDU-1981 Kudu should run at hosts len(FQDN) > 64 This is a fix for

[kudu-CR] Persistent cache support for NVM

2017-04-25 Thread Sarah Jelinek (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2593 to look at the new patch set (#24). Change subject: Persistent cache support for NVM .. Persistent cache support fo

[kudu-CR] KUDU-861 Support changing column defaults and storage attributes

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-861 Support changing column defaults and storage attributes .. Patch Set 2: Code-Review+1 LGTM, going to leave open for a bit in case someone else wants to lo

[kudu-CR] KUDU-861 Support changing column defaults and storage attributes

2017-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has posted comments on this change. Change subject: KUDU-861 Support changing column defaults and storage attributes .. Patch Set 1: (12 comments) http://gerrit.cloudera.org:8080/#/c/6725/1/src/kudu/client/table_

[kudu-CR] KUDU-861 Support changing column defaults and storage attributes

2017-04-25 Thread Will Berkeley (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6725 to look at the new patch set (#2). Change subject: KUDU-861 Support changing column defaults and storage attributes

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-25 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/6566/7/java/kudu-client/src/main/java/org/apache/kudu/

[kudu-CR] tpch: allow hash partitioning

2017-04-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6709 to look at the new patch set (#2). Change subject: tpch: allow hash partitioning .. tpch: allow hash partitioning

[kudu-CR] Simplify MemTracker and move process throttling elsewhere

2017-04-25 Thread Todd Lipcon (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6620 to look at the new patch set (#4). Change subject: Simplify MemTracker and move process throttling elsewhere .. Sim

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-25 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#8). Change subject: KUDU-579 [java_client] Scanner fault tolerance .. KUDU-579 [java

[kudu-CR] Simplify MemTracker and move process throttling elsewhere

2017-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Simplify MemTracker and move process throttling elsewhere .. Patch Set 3: (18 comments) http://gerrit.cloudera.org:8080/#/c/6620/3/src/kudu/integration-tests/raft

[kudu-CR] tpch: allow hash partitioning

2017-04-25 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: tpch: allow hash partitioning .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6709/1/src/kudu/benchmarks/tpch/rpc_line_item_dao.h File src/kudu/be

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-579 [java_client] Scanner fault tolerance .. Patch Set 7: (5 comments) http://gerrit.cloudera.org:8080/#/c/6566/7/java/kudu-client/src/main/java/org/apache/k

[kudu-CR] tablet copy: Refactor to avoid separate expiration map

2017-04-25 Thread Mike Percy (Code Review)
Mike Percy has posted comments on this change. Change subject: tablet copy: Refactor to avoid separate expiration map .. Patch Set 1: Verified+1 Flaky test is KUDU-1736; overriding -- To view, visit http://gerrit.cloudera.org

[kudu-CR] KUDU-861 Support changing column defaults and storage attributes

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: KUDU-861 Support changing column defaults and storage attributes .. Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6725/1/src/kudu/client/table_alt

[kudu-CR] [c++ client] re-acquire authn token if expired

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [c++ client] re-acquire authn token if expired .. Patch Set 5: (16 comments) http://gerrit.cloudera.org:8080/#/c/6648/3//COMMIT_MSG Commit Message: PS3, Line 11:

[kudu-CR] KUDU-579 [java client] Scanner fault tolerance

2017-04-25 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#7). Change subject: KUDU-579 [java_client] Scanner fault tolerance .. KUDU-579 [java

[kudu-CR] Persistent cache support for NVM

2017-04-25 Thread Sarah Jelinek (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/2593 to look at the new patch set (#23). Change subject: Persistent cache support for NVM .. Persistent cache support fo

[kudu-CR] tablet copy: Refactor to avoid separate expiration map

2017-04-25 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6731 Change subject: tablet copy: Refactor to avoid separate expiration map .. tablet copy: Refactor to avoid separate expiration map This simpl

[kudu-CR] tablet copy: Ensure no data loss on tablet copy failure

2017-04-25 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6732 Change subject: tablet copy: Ensure no data loss on tablet copy failure .. tablet copy: Ensure no data loss on tablet copy failure This pat

[kudu-CR] Make NO FATALS work standalone

2017-04-25 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6730 Change subject: Make NO_FATALS work standalone .. Make NO_FATALS work standalone As implemented, the macro NO_FATALS() is a synonym for ASS

[kudu-CR] KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure

2017-04-25 Thread Mike Percy (Code Review)
Mike Percy has uploaded a new change for review. http://gerrit.cloudera.org:8080/6733 Change subject: KUDU-1853 (redux). tablet copy: Don't orphan blocks on failure .. KUDU-1853 (redux). tablet copy: Don't orphan blocks on fai

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 4: I'm still concerned about different modes, but given this particular one is fairly non-invasive

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/6710 To unsubscribe, visit http

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [rp

[kudu-CR] log block manager: detect and repair unpunched holes

2017-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 2: Verified+1 Unrelated failure in a Spark test. -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [rp

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-25 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#9). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add c

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [rp

[kudu-CR] KUDU-1978: avoid corruption when deleting misaligned blocks

2017-04-25 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6715 to look at the new patch set (#2). Change subject: KUDU-1978: avoid corruption when deleting misaligned blocks .. K

[kudu-CR] log block manager: corruptor test utility

2017-04-25 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Todd Lipcon, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6582 to look at the new patch set (#10). Change subject: log block manager: corruptor test utility .

[kudu-CR] log block manager: detect and repair unpunched holes

2017-04-25 Thread Adar Dembo (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6717 to look at the new patch set (#2). Change subject: log block manager: detect and repair unpunched holes .. log bloc

[kudu-CR] log block manager: detect and repair unpunched holes

2017-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: log block manager: detect and repair unpunched holes .. Patch Set 1: > I did some performance testing on the same machine as before to > gauge how expensive the "r

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 12: (26 comments) Did another pass, still not done though. http://gerrit.cloudera.org:8080/#/c/6636/

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-25 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#8). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add c

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error .. Patch Set 10: (3 comments) http://gerrit.cloudera.org:8080/#/c/6640/10/src/kudu/integration-tests/security-unknown-t

[kudu-CR] [rpc] reopen outbound connections mode for reactor

2017-04-25 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [rpc] reopen_outbound_connections mode for reactor .. Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/6710/3//COMMIT_MSG Commit Message: Line 7: [rp

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-25 Thread Grant Henke (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6630 to look at the new patch set (#7). Change subject: WIP: KUDU-463. Add checksumming to cfile .. WIP: KUDU-463. Add c

[kudu-CR] KUDU-861 Support changing column defaults and storage attributes

2017-04-25 Thread Will Berkeley (Code Review)
Will Berkeley has uploaded a new change for review. http://gerrit.cloudera.org:8080/6725 Change subject: KUDU-861 Support changing column defaults and storage attributes .. KUDU-861 Support changing column defaults and storage

[kudu-CR] WIP KUDU-579 [java client] Scanner fault tolerance

2017-04-25 Thread Hao Hao (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6566 to look at the new patch set (#6). Change subject: WIP KUDU-579 [java_client] Scanner fault tolerance .. WIP KUDU-5

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#12). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#11). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement .. Patch Set 10: (37 comments) http://gerrit.cloudera.org:8080/#/c/6636/9/src/kudu/fs/block_manager.h File src/ku

[kudu-CR] KUDU-1952 Remove round-robin for block placement

2017-04-25 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/6636 to look at the new patch set (#10). Change subject: KUDU-1952 Remove round-robin for block placement .. KUDU-1952 R