[kudu-CR] disk failure: coordinate error handling

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/tablet_server.cc File src/kudu/ts

[kudu-CR] disk failure: coordinate error handling

2017-06-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 16: (1 comment) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/tablet_server.cc File src/kudu/t

[kudu-CR] [java] separating Connection

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 22: Code-Review+2 Carrying over Todd's +2 from PS21 -- To view, visit http://gerrit.cloudera.org:8080/7146 To unsubsc

[kudu-CR] disk failure: coordinate error handling

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/7029/16/src/kudu/tserver/tablet_server.cc File src/kudu/t

[kudu-CR] [java] separating Connection

2017-06-30 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7146 to look at the new patch set (#22). Change subject: [java] separating Connection .. [java] separating C

[kudu-CR] [java] add BaseKuduTest.doSetup() method

2017-06-30 Thread Alexey Serbin (Code Review)
Hello Todd Lipcon, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7336 to look at the new patch set (#5). Change subject: [java] add BaseKuduTest.doSetup() method .. [java]

[kudu-CR] disk failure: coordinate error handling

2017-06-30 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. Change subject: disk failure: coordinate error handling .. Patch Set 16: (22 comments) http://gerrit.cloudera.org:8080/#/c/7029/15/src/kudu/fs/block_manager.h File src/kudu/fs/bl

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 8: (19 comments) http://gerrit.cloudera.org:8080/#/c/7250/8/java/kudu-client/src/main/java/org/apa

[kudu-CR] disk failure: coordinate error handling

2017-06-30 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7029 to look at the new patch set (#16). Change subject: disk failure: coordinate error handling .. disk failure: coordi

[kudu-CR] WIP disk failure: add persistent disk states

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP disk failure: add persistent disk states .. Patch Set 2: (38 comments) I didn't finish reviewing this, but hopefully these comments will still be useful. htt

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired .. Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/7250/8/java/kudu-client/src/main/java/org/apac

[kudu-CR] [java] add BaseKuduTest.doSetup() method

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/7336/4/java/kudu-client/src/test/java/org/apache/kudu/

[kudu-CR] [java] add BaseKuduTest.doSetup() method

2017-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method .. Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7336/4/java/kudu-client/src/test/java/org/apache/kudu/cl

[kudu-CR] WIP disk failure: coordinate disk failure handling

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: WIP disk failure: coordinate disk failure handling .. Patch Set 9: (23 comments) I focused on the block manager and some MM ops. You should definitely get a revie

[kudu-CR] [java] separating Connection

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 21: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7146 To unsubscribe, visit http://gerrit.cloudera.or

[kudu-CR] [java] separating Connection

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/7146/21/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncK

[kudu-CR] disk failure: test coverage for disk failure recovery

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: disk failure: test coverage for disk failure recovery .. Patch Set 7: (16 comments) I didn't look at the test failures. Looks good, though I'd recommend you go ov

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: consensus_peers: schedule raft heartbeats through messenger .. consensus_peers: schedule raft heartbeats through messenger This patch switches Peer to a M

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 4: Code-Review+2 Adar and I chatted briefly offline about the above. We decided that, even

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 4: Indeed it looks like the behavior is better with the patch. Without the patch: https:/

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 4: I guess that makes sense, since now the mean heartbeat would be 0.75*heartbeat period,

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 4: Thanks for doing this. > Any idea why the resulting heartbeat rate is higher than befo

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [monotime] deprecating MonoTime::Earliest() .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7347 To unsubscribe, visit http://gerr

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: [monotime] deprecating MonoTime::Earliest() .. [monotime] deprecating MonoTime::Earliest() Deprecating MonoTime::Earliest() in favor of std::min(). This

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 2: k, I ran the following experiment: - built a release build of master - started a three

[kudu-CR] tests: allow Wait calls for non-default tables

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. Change subject: tests: allow Wait calls for non-default tables .. tests: allow Wait calls for non-default tables WaitForReplicasAndUpdateLocations and WaitForTSAndReplicas

[kudu-CR] Create ConsensusMetadataManager

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Create ConsensusMetadataManager .. Patch Set 15: (10 comments) http://gerrit.cloudera.org:8080/#/c/7191/15/src/kudu/consensus/consensus_meta_manager-stress-test.cc

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/7331/3/src/kudu/consensus/consensus_pe

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7331 to look at the new patch set (#4). Change subject: consensus_peers: schedule raft heartbeats through messenger .

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Adar Dembo (Code Review)
Hello Mike Percy, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7331 to look at the new patch set (#3). Change subject: consensus_peers: schedule raft heartbeats through messenger .

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 2: > Any chance you've run this on a small cluster (even a localhost > one) with lots of t

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [monotime] deprecating MonoTime::Earliest() .. Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7347/1/src/kudu/client/client-internal.cc File src/

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7347 to look at the new patch set (#3). Change subject: [monotime] deprecating MonoTime::Earliest() .. [monotime] deprec

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new patch set (#2). Change subject: [monotime] deprecating MonoTime::Earliest() .. [monotime] deprecating MonoTime::Earliest() Deprecating MonoTime::Earliest() in favor of std::min(). This patch doe

[kudu-CR] [java] separating Connection

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/7146/21/java/kudu-client/src/main/java/org/apache/kudu/client/Asyn

[kudu-CR] consensus peers: schedule raft heartbeats through messenger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: consensus_peers: schedule raft heartbeats through messenger .. Patch Set 2: Any chance you've run this on a small cluster (even a localhost one) with lots of tabl

[kudu-CR] mini cluster: support multiple data dirs

2017-06-30 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: mini_cluster: support multiple data dirs .. Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/7211/9/src/kudu/integration-tests/internal_mini_cluster.c

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [monotime] deprecating MonoTime::Earliest() .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7347/1/src/kudu/util/monotime.h File src/kudu/util/mon

[kudu-CR] [monotime] deprecating MonoTime::Earliest()

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded a new change for review. http://gerrit.cloudera.org:8080/7347 Change subject: [monotime] deprecating MonoTime::Earliest() .. [monotime] deprecating MonoTime::Earliest() Deprecating MonoTime::Earlies

[kudu-CR] [java] add BaseKuduTest.doSetup() method

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method .. Patch Set 4: > lgtm. this would have been a little easier to review if the change > to DEFAULT_TIMEOUT had been a se

[kudu-CR] [java] add BaseKuduTest.doSetup() method

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] add BaseKuduTest.doSetup() method .. Patch Set 4: Code-Review+1 lgtm. this would have been a little easier to review if the change to DEFAULT_TIMEOUT had b

[kudu-CR] [java] separating Connection

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/7146/21/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncK

[kudu-CR] TabletReplica: Move Init() logic to Start()

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: TabletReplica: Move Init() logic to Start() .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7194 To unsubscribe, visit http://ge

[kudu-CR] [java] separating Connection

2017-06-30 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. Change subject: [java] separating Connection .. Patch Set 21: Verified+1 Unrelated flake RaftConsensusITest.TestChurnyElections -- To view, visit http://gerrit.cloudera.org:80

[kudu-CR](branch-1.4.x) java: fix incorrect hashmap usage in Statistics

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: java: fix incorrect hashmap usage in Statistics .. java: fix incorrect hashmap usage in Statistics 65cb2edf5661599f689e28f4eec161fe062f7cb5 changed the ha

[kudu-CR](branch-1.4.x) Work around another OpenSSL thread safety bug

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Work around another OpenSSL thread safety bug .. Work around another OpenSSL thread safety bug In the course of debugging some CHECK failures and TSAN err

[kudu-CR] [java] add BaseKuduTest.doSetup() method

2017-06-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7336 to look at the new patch set (#4). Change subject: [java] add BaseKuduTest.doSetup() method .. [java] add BaseKuduT

[kudu-CR] [java] KUDU-2013 re-acquire authn token if expired

2017-06-30 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7250 to look at the new patch set (#8). Change subject: [java] KUDU-2013 re-acquire authn token if expired .. [java] KUD

[kudu-CR] [java] separating Connection

2017-06-30 Thread Alexey Serbin (Code Review)
Hello Dan Burkert, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7146 to look at the new patch set (#21). Change subject: [java] separating Connection .. [java] separating

[kudu-CR](branch-1.2.x) [java-client] update protoc maven plugin

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: [java-client] update protoc maven plugin .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.cloudera.org:8080/7345 To unsubscribe, visit http://gerrit.

[kudu-CR](branch-1.2.x) java: fix incorrect hashmap usage in Statistics

2017-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix incorrect hashmap usage in Statistics .. Patch Set 1: > Build Failed > > http://jenkins.kudu.apache.org/job/kudu-gerrit/8821/ : FAILURE Put up

[kudu-CR](branch-1.2.x) [java-client] update protoc maven plugin

2017-06-30 Thread Jean-Daniel Cryans (Code Review)
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, Kudu Jenkins, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/7345 to review the following change. Change subject: [java-client] update protoc maven plugin ..

[kudu-CR](branch-1.3.x) java: fix incorrect hashmap usage in Statistics

2017-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: java: fix incorrect hashmap usage in Statistics .. java: fix incorrect hashmap usage in Statistics 65cb2edf5661599f689e28f4eec161fe062f7cb5 changed

[kudu-CR](branch-1.3.x) java: fix incorrect hashmap usage in Statistics

2017-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix incorrect hashmap usage in Statistics .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7339 To unsubscribe, visit

[kudu-CR](branch-1.4.x) java: fix incorrect hashmap usage in Statistics

2017-06-30 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change. Change subject: java: fix incorrect hashmap usage in Statistics .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7338 To unsubscribe, visit

[kudu-CR](branch-1.4.x) java: fix incorrect hashmap usage in Statistics

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: java: fix incorrect hashmap usage in Statistics .. Patch Set 1: Verified+1 Test failures are due to not having an unrelated bug fix in branch-1.4.x. Put up a cher

[kudu-CR](branch-1.4.x) Work around another OpenSSL thread safety bug

2017-06-30 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change. Change subject: Work around another OpenSSL thread safety bug .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/7344 To unsubscribe, visit http://ge

[kudu-CR](branch-1.4.x) Work around another OpenSSL thread safety bug

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Work around another OpenSSL thread safety bug .. Patch Set 1: Cherry-picking to 1.4.x since I got TSAN failures on an attempted cherry-pick to this branch -- To

[kudu-CR](branch-1.4.x) Work around another OpenSSL thread safety bug

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7344 Change subject: Work around another OpenSSL thread safety bug .. Work around another OpenSSL thread safety bug In the course of debugging

[kudu-CR] benchmarks: split dense-node-itest graph by different types of data

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: benchmarks: split dense-node-itest graph by different types of data .. benchmarks: split dense-node-itest graph by different types of data The current gr

[kudu-CR] benchmarks: split dense-node-itest graph by different types of data

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: benchmarks: split dense-node-itest graph by different types of data .. Patch Set 1: Verified+1 committing without jenkins since precommit doesn't run this script

[kudu-CR] mini cluster: support multiple data dirs

2017-06-30 Thread Andrew Wong (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/7211 to look at the new patch set (#9). Change subject: mini_cluster: support multiple data dirs .. mini_cluster: suppor

[kudu-CR] nonsense change to test gerrit trigger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new patch set (#2). Change subject: nonsense change to test gerrit trigger .. nonsense change to test gerrit trigger Change-Id: Ie0748293e0973b19e36ed07dedbfd01e3c8edeaf --- M README.adoc 1 file change

[kudu-CR] nonsense change to test gerrit trigger

2017-06-30 Thread Todd Lipcon (Code Review)
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/7343 Change subject: nonsense change to test gerrit trigger .. nonsense change to test gerrit trigger Change-Id: Ie0748293e0973b19e36ed07dedbfd